Uh oh!
There was an error while loading. Please reload this page.
Add support for local and global chats in Discord - #4684
Merged
Conversation
3 tasks
brawaruforce-pushed
the
feat/discord-esschat-events
branch
from
December 12, 2021 22:59
3165a7e to
1741621Comparebrawaruforce-pushed
the
feat/discord-esschat-events
branch
from
February 14, 2022 08:36
1741621 to
afb5859Comparebrawaruforce-pushed
the
feat/discord-esschat-events
branch
from
June 1, 2022 03:08
afb5859 to
77c5f81Comparebrawaruforce-pushed
the
feat/discord-esschat-events
branch
from
June 16, 2022 07:27
77c5f81 to
448fcfeComparebrawaruforce-pushed
the
feat/discord-esschat-events
branch
from
July 6, 2022 19:48
448fcfe to
1db6cc9Comparebrawaruforce-pushed
the
feat/discord-esschat-events
branch
2 times, most recently
from
August 19, 2022 11:35
9fd7a6c to
d265ce3CompareJRoy
requested changes
Aug 19, 2022
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
brawaruforce-pushed
the
feat/discord-esschat-events
branch
from
August 20, 2022 12:54
d265ce3 to
f6c49ddCompareJRoy
commented
Apr 29, 2023
Member
@brawaru could you update this to the latest 2.x so we can get this merged :) |
This change makes use of added separate events for local and global chats, making it possible to change formatting of messages sent from different chat types, as well as disable them altogether (for example, if you don't want to see local chat messages in Discord). By default Essentials Discord will continue to use Bukkit chat events without any kind of separation, you must explicitly opt in to have new behaviour by changing use-essential-events to true.
brawaruforce-pushed
the
feat/discord-esschat-events
branch
from
April 30, 2023 00:52
f6c49dd to
26d8033Comparebrawaru
commented
Apr 30, 2023
ContributorAuthor
Rebased, but haven't tested anything yet. Will try to when I have time. |
JRoy
marked this pull request as ready for review
May 1, 2023 01:04
JRoy
requested changes
May 1, 2023
JRoy
left a comment
Member
There was a problem hiding this comment.
i don't know why i requested these be enabled by default, they should be disabled 😄
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
JRoy
enabled auto-merge (squash)
May 1, 2023 01:17
JRoy
approved these changes
May 1, 2023
rewsdjad1 pushed a commit
to rewsdjad1/EssentialsXPlus
that referenced
this pull request
Aug 13, 2026
Co-authored-by: Josh Roy <10731363+JRoy@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is a draft since it requires #4683 to be merged first.
Information
×
Details
Proposed feature:
This change makes use of added separate events for local and global chats in , making it possible to change the formatting of messages sent from different chat types, as well as disable them altogether (for example, if you don't want to see local chat messages in Discord).
By default Essentials Discord will continue to use Bukkit chat events without any kind of separation, you must explicitly opt in to have new behaviour by changing use-essential-events to true.
Environments tested:
OS: Windows 10 20H2.
Java version:
Demonstration:
Fixed#4989