Skip to content

Use component logger on Paper for console colors - #4941

Merged
JRoy merged 10 commits into
EssentialsX:2.xfrom
JRoy:stupid-fucking-colors
Jun 27, 2022
Merged

Use component logger on Paper for console colors#4941
JRoy merged 10 commits into
EssentialsX:2.xfrom
JRoy:stupid-fucking-colors

Conversation

@JRoy

@JRoyJRoy commented Jun 14, 2022

Copy link
Copy Markdown
Member

Fixes#4895

@JRoyJRoy added type: enhancement Features and feature requests. module: main Issues or PRs for the main Essentials module module: discord Issues or PRs for the EssentialsDiscord module module: chat Issues or PRs for the EssentialsChat module module: spawn Issues or PRs for the EssentialsSpawn module module: geo Issues or PRs for the EssentialsGeo module module: protect Issues or PRs for the EssentialsProtect module labels Jun 14, 2022
@JRoyJRoy added this to the 2.19.5 milestone Jun 14, 2022
mdcfe
mdcfe previously requested changes Jun 15, 2022
View reviewed changes

@mdcfemdcfe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm really not a fan of replacing every single usage of a logger with a static method.

@JRoy
JRoy requested a review from mdcfeJune 17, 2022 20:59
@mdcfemdcfe mentioned this pull request Jun 26, 2022
Closed
JRoy
JRoy commented Jun 27, 2022
View reviewed changes
Comment threadEssentials/src/main/java/com/earth2me/essentials/EssentialsUpgrade.java Outdated
Comment threadEssentials/src/main/java/com/earth2me/essentials/EssentialsUpgrade.java Outdated
Comment threadEssentials/src/main/java/com/earth2me/essentials/EssentialsUpgrade.java Outdated
Comment threadEssentials/src/main/java/com/earth2me/essentials/I18n.java
Comment threadEssentials/src/main/java/com/earth2me/essentials/commands/Commandgc.java Outdated
Comment threadEssentials/src/main/java/com/earth2me/essentials/items/FlatItemDb.java
@mdcfemdcfe changed the title Add providers for paper component loggingUse component logger on Paper for console colorsJun 27, 2022
@JRoy
JRoy merged commit 6816eb4 into EssentialsX:2.xJun 27, 2022
@JRoy
JRoy deleted the stupid-fucking-colors branch June 27, 2022 18:54
@mdcfemdcfe mentioned this pull request Aug 5, 2023
Merged
4 tasks
ressidell pushed a commit to ressidell/Essentials that referenced this pull request Apr 27, 2025
@JRoy@mdcfe
Use component logger on Paper for console colors (EssentialsX#4941)
77f962d
Co-authored-by: MD <1917406+mdcfe@users.noreply.github.com>
rewsdjad1 pushed a commit to rewsdjad1/EssentialsXPlus that referenced this pull request Aug 13, 2026
@JRoy@mdcfe
Use component logger on Paper for console colors (EssentialsX#4941)
942b36f
Co-authored-by: MD <1917406+mdcfe@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdcfemdcfemdcfe approved these changes

Assignees

No one assigned

Labels

module: chatIssues or PRs for the EssentialsChat modulemodule: discordIssues or PRs for the EssentialsDiscord modulemodule: geoIssues or PRs for the EssentialsGeo modulemodule: mainIssues or PRs for the main Essentials modulemodule: protectIssues or PRs for the EssentialsProtect modulemodule: spawnIssues or PRs for the EssentialsSpawn moduletype: enhancementFeatures and feature requests.

Projects

None yet

Milestone

2.19.5

Development

Successfully merging this pull request may close these issues.

Paper console colors are broken

2 participants

@JRoy@mdcfe