Skip to content

Fix "heer" typo in messages_en.properties - #6135

Merged
mdcfe merged 2 commits into
EssentialsX:2.xfrom
luftwafflezz:patch-1
Apr 29, 2025
Merged

Fix "heer" typo in messages_en.properties#6135
mdcfe merged 2 commits into
EssentialsX:2.xfrom
luftwafflezz:patch-1

Conversation

@luftwafflezz

@luftwafflezzluftwafflezz commented Apr 28, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Information

This PR fixes N/A (it is only a simple fix for typos)

Details

Proposed fix:

Change "heer" to "here" in messages_en.properties

Environments tested:

OS: Arch Linux

Java version: 21.0.7

  • Most recent Paper version (1.XX.Y, git-Paper-BUILD)
  • CraftBukkit/Spigot/Paper 1.12.2
  • CraftBukkit 1.8.8

Demonstration:

@luftwafflezzluftwafflezz changed the title Fixed "heer" typo in messages_en.propertiesFix "heer" typo in messages_en.propertiesApr 28, 2025
@JasonHorkles

JasonHorkles commented Apr 28, 2025

Copy link
Copy Markdown
Contributor

Honestly this file shouldn't even be used in favor of messages.properties

@luftwafflezz

luftwafflezz commented Apr 28, 2025

Copy link
Copy Markdown
ContributorAuthor

Honestly this file shouldn't even be used in favor of messages.properties

I noticed this issue when I ran ess ver on my server, and it said that I could download the latest development build "heer: https://essentialsx.net/downloads.html", so it seems that it is being used.

@JasonHorkles

JasonHorkles commented Apr 28, 2025

Copy link
Copy Markdown
Contributor

In the config, does locale have a # before it? If not, that's probably why. If you're just using English, then feel free to add that # back and it should be the correct file.

@luftwafflezz

luftwafflezz commented Apr 28, 2025

Copy link
Copy Markdown
ContributorAuthor

Yes, the # is there. I believe that's how it is by default.

@JasonHorkles

JasonHorkles commented Apr 28, 2025

Copy link
Copy Markdown
Contributor

Yep
I've brought this up with the team to see if it's worth making this file sync with the main one or something similar

@luftwafflezz

luftwafflezz commented Apr 28, 2025

Copy link
Copy Markdown
ContributorAuthor

Ok, thank you :)

@mdcfe

mdcfe commented Apr 29, 2025

Copy link
Copy Markdown
Member

Hey, thanks for catching this. We don't usually take PRs to translation files on GitHub (as they're handled on Crowdin), but since this affects English I'm happy to merge this for now.

We're likely going to remove English (US) from Crowdin - it's already the source language, so there isn't much reason for it to be translatable in the first place.

mdcfe
mdcfe requested changes Apr 29, 2025
View reviewed changes
Comment threadEssentials/src/main/resources/messages_en.properties Outdated
@luftwafflezz@mdcfe
Update Essentials/src/main/resources/messages_en.properties
156574a
Co-authored-by: MD <1917406+mdcfe@users.noreply.github.com>
@mdcfe
mdcfe enabled auto-merge (squash) April 29, 2025 20:07
@mdcfe
mdcfe merged commit fe43017 into EssentialsX:2.xApr 29, 2025
@mdcfemdcfe added this to the 2.21.1 milestone May 25, 2025
Euphillya added a commit to Euphillya/Essentials-Folia that referenced this pull request Jun 27, 2025
@Euphillya
Update Upstream EssentialsX:
1070216
EssentialsX@40540eb Expose IUser#getLastActivityTime to API (EssentialsX#6101)
EssentialsX@50b696b Adds social spy message type for in EssentialsDiscord (EssentialsX#5620)
EssentialsX@dabe687 Add SignTransactionEvent for buy and sell signs (EssentialsX#6071)
EssentialsX@0cb387f Fix NPE when unlinking offline players (EssentialsX#6111)
EssentialsX@f09541c Update to Minecraft 1.21.5 (EssentialsX#6109)
EssentialsX@c7ff994 Fire GlobalChatEvent even when local chat is disabled (EssentialsX#6113)
EssentialsX@06c886c Fix /baltop on 1.15.2 and below (EssentialsX#6115)
EssentialsX@2bb4438 Fix further trade sign validation mismatches (EssentialsX#6116)
EssentialsX@8455212 Fix /spawnmob on < 1.21.5 (EssentialsX#6121)
EssentialsX@be3e641 New Crowdin updates (EssentialsX#6089)
EssentialsX@3f5b122 Use legacy text for TranslatableException#getMessage (EssentialsX#6134)
EssentialsX@fe43017 Fix heer typo in messages_en.properties (EssentialsX#6135)
EssentialsX@a58db23 Update English source strings with fixes from Crowdin (EssentialsX#6140)
EssentialsX@d137031 Improve config comments & ordering (EssentialsX#6108)
EssentialsX@3b0c229 New Crowdin updates (EssentialsX#6131)
EssentialsX@3fe1495 Fix unexpected behavior with essentials.home.bed & essentials.sethome.bed permissions (EssentialsX#5991)
EssentialsX@aebe851 Fix double messages when deleting a non-existent home (EssentialsX#6150)
EssentialsX@3a5c7c4 Revert changes to /home and /sethome that break bed interactions (EssentialsX#6151)
EssentialsX@3d28d82 Release 2.21.1
EssentialsX@e836747 Prepare for 2.21.2 dev builds (EssentialsX#6128)
EssentialsX@d42347f Fix sending message during /editsign paste if SignChangeEvent is cancelled (EssentialsX#6136)
EssentialsX@997f600 Update adventure dependencies (EssentialsX#6163)
EssentialsX@4057326 Update to Minecraft 1.21.6
EssentialsX@2796399 Add 1.21.6 Mobs
EssentialsX@31ea903 Move tests to MockBukkit
EssentialsX@ff1b8b8 Add 1.21.6 Aliases
This was referenced Jun 29, 2025
Open
Open
Open
Open
rewsdjad1 pushed a commit to rewsdjad1/EssentialsXPlus that referenced this pull request Aug 13, 2026
@luftwafflezz@mdcfe
Fix "heer" typo in messages_en.properties (EssentialsX#6135)
fe87cb9
Co-authored-by: MD <1917406+mdcfe@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdcfemdcfemdcfe approved these changes
+1 more reviewer
@JasonHorklesJasonHorklesJasonHorkles left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.21.1

Development

Successfully merging this pull request may close these issues.

3 participants

@luftwafflezz@JasonHorkles@mdcfe