Skip to content

Update Adventure - #6163

Merged
JRoy merged 7 commits into
EssentialsX:2.xfrom
iiAhmedYT:patch-1
Jun 6, 2025
Merged

Update Adventure#6163
JRoy merged 7 commits into
EssentialsX:2.xfrom
iiAhmedYT:patch-1

Conversation

@iiAhmedYT

@iiAhmedYTiiAhmedYT commented Jun 4, 2025

Copy link
Copy Markdown
Contributor

Information

This PR fixes an issue where clickable messages don't work on newer versions (1.21.5).

Details

Proposed fix:
Update Adventure

Environments tested:

OS: Windows, Linux

Java version: 21

  • Most recent Paper version (1.XX.Y, git-Paper-BUILD)
  • CraftBukkit/Spigot/Paper 1.12.2
  • CraftBukkit 1.8.8

Demonstration:

It's really not worth a demonstration lol

@JRoy

JRoy commented Jun 4, 2025

Copy link
Copy Markdown
Member

can you bump adventure platform to 4.4.0 as well? otherwise good

@iiAhmedYT

iiAhmedYT commented Jun 4, 2025

Copy link
Copy Markdown
ContributorAuthor

Yes sir captin sir 🫡

JRoy
JRoy previously approved these changes Jun 4, 2025
View reviewed changes

@JRoyJRoy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love to see it

@JRoy
JRoy enabled auto-merge (squash) June 4, 2025 23:30
@JRoy
JRoy disabled auto-merge June 4, 2025 23:30
@JRoy
JRoy enabled auto-merge (squash) June 4, 2025 23:31
@JRoy
JRoy disabled auto-merge June 4, 2025 23:31
@JRoy
JRoy enabled auto-merge (squash) June 4, 2025 23:31
@iiAhmedYT

iiAhmedYT commented Jun 4, 2025

Copy link
Copy Markdown
ContributorAuthor

how does it even fail-

@iiAhmedYT

iiAhmedYT commented Jun 5, 2025

Copy link
Copy Markdown
ContributorAuthor

Apparently it failed to find Adventure Platform related classes.. (btw it is on Maven Central, so it not being found is actually insanity) the fix is not really on my mind

@JasonHorkles

JasonHorkles commented Jun 5, 2025

Copy link
Copy Markdown
Contributor

Probs some maven cache or something silly

@iiAhmedYT
Specify the dependency section with a comment
377c505
Real intention behind this is to rerun the build. lol
auto-merge was automatically disabled June 5, 2025 12:05

Head branch was pushed to by a user without write access

@iiAhmedYT

iiAhmedYT commented Jun 5, 2025

Copy link
Copy Markdown
ContributorAuthor

The error is about a class that isn't even used in the code, im not sure why it's happening but apparently it's loading and compiling just fine, the tests on the other hand aren't doing so fine themselves

@iiAhmedYT

iiAhmedYT commented Jun 6, 2025

Copy link
Copy Markdown
ContributorAuthor

Upon further investigation, this line:
https://github.com/KyoriPowered/adventure-platform/blob/main/platform-bukkit/src/main/java/net/kyori/adventure/platform/bukkit/BukkitComponentSerializer.java#L66

which uses Bukkit#getUnsafe#getDataVersion is the reason behind it all, the tests simply cant provide it

A solution would be to use proper testing for Bukkit like MockBukkit

or.. Just temporarily disable these tests

@JRoy

JRoy commented Jun 6, 2025

Copy link
Copy Markdown
Member

I'll look in a few

JRoy
JRoy approved these changes Jun 6, 2025
View reviewed changes
@JRoy
JRoy merged commit 997f600 into EssentialsX:2.xJun 6, 2025
Euphillya added a commit to Euphillya/Essentials-Folia that referenced this pull request Jun 27, 2025
@Euphillya
Update Upstream EssentialsX:
1070216
EssentialsX@40540eb Expose IUser#getLastActivityTime to API (EssentialsX#6101)
EssentialsX@50b696b Adds social spy message type for in EssentialsDiscord (EssentialsX#5620)
EssentialsX@dabe687 Add SignTransactionEvent for buy and sell signs (EssentialsX#6071)
EssentialsX@0cb387f Fix NPE when unlinking offline players (EssentialsX#6111)
EssentialsX@f09541c Update to Minecraft 1.21.5 (EssentialsX#6109)
EssentialsX@c7ff994 Fire GlobalChatEvent even when local chat is disabled (EssentialsX#6113)
EssentialsX@06c886c Fix /baltop on 1.15.2 and below (EssentialsX#6115)
EssentialsX@2bb4438 Fix further trade sign validation mismatches (EssentialsX#6116)
EssentialsX@8455212 Fix /spawnmob on < 1.21.5 (EssentialsX#6121)
EssentialsX@be3e641 New Crowdin updates (EssentialsX#6089)
EssentialsX@3f5b122 Use legacy text for TranslatableException#getMessage (EssentialsX#6134)
EssentialsX@fe43017 Fix heer typo in messages_en.properties (EssentialsX#6135)
EssentialsX@a58db23 Update English source strings with fixes from Crowdin (EssentialsX#6140)
EssentialsX@d137031 Improve config comments & ordering (EssentialsX#6108)
EssentialsX@3b0c229 New Crowdin updates (EssentialsX#6131)
EssentialsX@3fe1495 Fix unexpected behavior with essentials.home.bed & essentials.sethome.bed permissions (EssentialsX#5991)
EssentialsX@aebe851 Fix double messages when deleting a non-existent home (EssentialsX#6150)
EssentialsX@3a5c7c4 Revert changes to /home and /sethome that break bed interactions (EssentialsX#6151)
EssentialsX@3d28d82 Release 2.21.1
EssentialsX@e836747 Prepare for 2.21.2 dev builds (EssentialsX#6128)
EssentialsX@d42347f Fix sending message during /editsign paste if SignChangeEvent is cancelled (EssentialsX#6136)
EssentialsX@997f600 Update adventure dependencies (EssentialsX#6163)
EssentialsX@4057326 Update to Minecraft 1.21.6
EssentialsX@2796399 Add 1.21.6 Mobs
EssentialsX@31ea903 Move tests to MockBukkit
EssentialsX@ff1b8b8 Add 1.21.6 Aliases
rewsdjad1 pushed a commit to rewsdjad1/EssentialsXPlus that referenced this pull request Aug 13, 2026
@iiAhmedYT@JRoy
Update adventure dependencies (EssentialsX#6163)
8c6d015
Fixes issues with clickable chat components on 1.21.5
Co-authored-by: Josh Roy <10731363+JRoy@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JRoyJRoyJRoy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@iiAhmedYT@JRoy@JasonHorkles
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Update Adventure by iiAhmedYT · Pull Request #6163 · EssentialsX/Essentials · GitHub
Skip to content
Update Adventure - #6163
Merged
JRoy merged 7 commits into
EssentialsX:2.xfrom 
iiAhmedYT:patch-1
Jun 6, 2025
Merged
Update Adventure#6163
JRoy merged 7 commits into
EssentialsX:2.xfrom 
iiAhmedYT:patch-1
Conversation
@iiAhmedYT
@iiAhmedYTiiAhmedYT
commented
Jun 4, 2025

Copy link


Copy Markdown

Contributor
Information
This PR fixes an issue where clickable messages don't work on newer versions (1.21.5).
Details
Proposed fix:

Update Adventure
Environments tested:
OS: Windows, Linux
Java version: 21
  •  Most recent Paper version (1.XX.Y, git-Paper-BUILD)
  •  CraftBukkit/Spigot/Paper 1.12.2
  •  CraftBukkit 1.8.8
Demonstration:
It's really not worth a demonstration lol
@JRoy
JRoy
commented
Jun 4, 2025

Copy link


Copy Markdown

Member
can you bump adventure platform to 4.4.0 as well? otherwise good
@iiAhmedYT
iiAhmedYT
commented
Jun 4, 2025

Copy link


Copy Markdown

ContributorAuthor
Yes sir captin sir 🫡
JRoy
JRoy
previously approved these changes
Jun 4, 2025
View reviewed changes
@JRoyJRoy
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love to see it
@JRoy
JRoy
enabled auto-merge (squash)
June 4, 2025 23:30
@JRoy
JRoy
disabled auto-merge
June 4, 2025 23:30
@JRoy
JRoy
enabled auto-merge (squash)
June 4, 2025 23:31
@JRoy
JRoy
disabled auto-merge
June 4, 2025 23:31
@JRoy
JRoy
enabled auto-merge (squash)
June 4, 2025 23:31
@iiAhmedYT
iiAhmedYT
commented
Jun 4, 2025

Copy link


Copy Markdown

ContributorAuthor
how does it even fail-
@iiAhmedYT
iiAhmedYT
commented
Jun 5, 2025

Copy link


Copy Markdown

ContributorAuthor
Apparently it failed to find Adventure Platform related classes.. (btw it is on Maven Central, so it not being found is actually insanity) the fix is not really on my mind
@JasonHorkles
JasonHorkles
commented
Jun 5, 2025

Copy link


Copy Markdown

Contributor
Probs some maven cache or something silly
@iiAhmedYT
Specify the dependency section with a comment
377c505
Real intention behind this is to rerun the build. lol

auto-merge was automatically disabled
June 5, 2025 12:05
Head branch was pushed to by a user without write access
@iiAhmedYT
iiAhmedYT
commented
Jun 5, 2025

Copy link


Copy Markdown

ContributorAuthor
The error is about a class that isn't even used in the code, im not sure why it's happening but apparently it's loading and compiling just fine, the tests on the other hand aren't doing so fine themselves
@iiAhmedYT
iiAhmedYT
commented
Jun 6, 2025

Copy link


Copy Markdown

ContributorAuthor
Upon further investigation, this line:
https://github.com/KyoriPowered/adventure-platform/blob/main/platform-bukkit/src/main/java/net/kyori/adventure/platform/bukkit/BukkitComponentSerializer.java#L66
which uses Bukkit#getUnsafe#getDataVersion is the reason behind it all, the tests simply cant provide it
A solution would be to use proper testing for Bukkit like MockBukkit
or.. Just temporarily disable these tests
@JRoy
JRoy
commented
Jun 6, 2025

Copy link


Copy Markdown

Member
I'll look in a few
JRoy
JRoy
approved these changes
Jun 6, 2025
View reviewed changes
@JRoy
JRoy
merged commit 997f600
into
EssentialsX:2.xJun 6, 2025
Euphillya added a commit
to Euphillya/Essentials-Folia
that referenced
this pull request
Jun 27, 2025
@Euphillya
Update Upstream EssentialsX:
1070216
EssentialsX@40540eb Expose IUser#getLastActivityTime to API (EssentialsX#6101)
EssentialsX@50b696b Adds social spy message type for in EssentialsDiscord (EssentialsX#5620)
EssentialsX@dabe687 Add SignTransactionEvent for buy and sell signs (EssentialsX#6071)
EssentialsX@0cb387f Fix NPE when unlinking offline players (EssentialsX#6111)
EssentialsX@f09541c Update to Minecraft 1.21.5 (EssentialsX#6109)
EssentialsX@c7ff994 Fire GlobalChatEvent even when local chat is disabled (EssentialsX#6113)
EssentialsX@06c886c Fix /baltop on 1.15.2 and below (EssentialsX#6115)
EssentialsX@2bb4438 Fix further trade sign validation mismatches (EssentialsX#6116)
EssentialsX@8455212 Fix /spawnmob on < 1.21.5 (EssentialsX#6121)
EssentialsX@be3e641 New Crowdin updates (EssentialsX#6089)
EssentialsX@3f5b122 Use legacy text for TranslatableException#getMessage (EssentialsX#6134)
EssentialsX@fe43017 Fix heer typo in messages_en.properties (EssentialsX#6135)
EssentialsX@a58db23 Update English source strings with fixes from Crowdin (EssentialsX#6140)
EssentialsX@d137031 Improve config comments & ordering (EssentialsX#6108)
EssentialsX@3b0c229 New Crowdin updates (EssentialsX#6131)
EssentialsX@3fe1495 Fix unexpected behavior with essentials.home.bed & essentials.sethome.bed permissions (EssentialsX#5991)
EssentialsX@aebe851 Fix double messages when deleting a non-existent home (EssentialsX#6150)
EssentialsX@3a5c7c4 Revert changes to /home and /sethome that break bed interactions (EssentialsX#6151)
EssentialsX@3d28d82 Release 2.21.1
EssentialsX@e836747 Prepare for 2.21.2 dev builds (EssentialsX#6128)
EssentialsX@d42347f Fix sending message during /editsign paste if SignChangeEvent is cancelled (EssentialsX#6136)
EssentialsX@997f600 Update adventure dependencies (EssentialsX#6163)
EssentialsX@4057326 Update to Minecraft 1.21.6
EssentialsX@2796399 Add 1.21.6 Mobs
EssentialsX@31ea903 Move tests to MockBukkit
EssentialsX@ff1b8b8 Add 1.21.6 Aliases
rewsdjad1 pushed a commit
to rewsdjad1/EssentialsXPlus
that referenced
this pull request
Aug 13, 2026
@iiAhmedYT@JRoy
Update adventure dependencies (EssentialsX#6163)
8c6d015
Fixes issues with clickable chat components on 1.21.5
Co-authored-by: Josh Roy <10731363+JRoy@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@JRoyJRoyJRoy approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@iiAhmedYT@JRoy@JasonHorkles

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Update Adventure by iiAhmedYT · Pull Request #6163 · EssentialsX/Essentials · GitHub
Skip to content
Update Adventure - #6163
Merged
JRoy merged 7 commits into
EssentialsX:2.xfrom 
iiAhmedYT:patch-1
Jun 6, 2025
Merged
Update Adventure#6163
JRoy merged 7 commits into
EssentialsX:2.xfrom 
iiAhmedYT:patch-1
Conversation
@iiAhmedYT
@iiAhmedYTiiAhmedYT
commented
Jun 4, 2025

Copy link


Copy Markdown

Contributor
Information
This PR fixes an issue where clickable messages don't work on newer versions (1.21.5).
Details
Proposed fix:

Update Adventure
Environments tested:
OS: Windows, Linux
Java version: 21
  •  Most recent Paper version (1.XX.Y, git-Paper-BUILD)
  •  CraftBukkit/Spigot/Paper 1.12.2
  •  CraftBukkit 1.8.8
Demonstration:
It's really not worth a demonstration lol
@JRoy
JRoy
commented
Jun 4, 2025

Copy link


Copy Markdown

Member
can you bump adventure platform to 4.4.0 as well? otherwise good
@iiAhmedYT
iiAhmedYT
commented
Jun 4, 2025

Copy link


Copy Markdown

ContributorAuthor
Yes sir captin sir 🫡
JRoy
JRoy
previously approved these changes
Jun 4, 2025
View reviewed changes
@JRoyJRoy
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love to see it
@JRoy
JRoy
enabled auto-merge (squash)
June 4, 2025 23:30
@JRoy
JRoy
disabled auto-merge
June 4, 2025 23:30
@JRoy
JRoy
enabled auto-merge (squash)
June 4, 2025 23:31
@JRoy
JRoy
disabled auto-merge
June 4, 2025 23:31
@JRoy
JRoy
enabled auto-merge (squash)
June 4, 2025 23:31
@iiAhmedYT
iiAhmedYT
commented
Jun 4, 2025

Copy link


Copy Markdown

ContributorAuthor
how does it even fail-
@iiAhmedYT
iiAhmedYT
commented
Jun 5, 2025

Copy link


Copy Markdown

ContributorAuthor
Apparently it failed to find Adventure Platform related classes.. (btw it is on Maven Central, so it not being found is actually insanity) the fix is not really on my mind
@JasonHorkles
JasonHorkles
commented
Jun 5, 2025

Copy link


Copy Markdown

Contributor
Probs some maven cache or something silly
@iiAhmedYT
Specify the dependency section with a comment
377c505
Real intention behind this is to rerun the build. lol

auto-merge was automatically disabled
June 5, 2025 12:05
Head branch was pushed to by a user without write access
@iiAhmedYT
iiAhmedYT
commented
Jun 5, 2025

Copy link


Copy Markdown

ContributorAuthor
The error is about a class that isn't even used in the code, im not sure why it's happening but apparently it's loading and compiling just fine, the tests on the other hand aren't doing so fine themselves
@iiAhmedYT
iiAhmedYT
commented
Jun 6, 2025

Copy link


Copy Markdown

ContributorAuthor
Upon further investigation, this line:
https://github.com/KyoriPowered/adventure-platform/blob/main/platform-bukkit/src/main/java/net/kyori/adventure/platform/bukkit/BukkitComponentSerializer.java#L66
which uses Bukkit#getUnsafe#getDataVersion is the reason behind it all, the tests simply cant provide it
A solution would be to use proper testing for Bukkit like MockBukkit
or.. Just temporarily disable these tests
@JRoy
JRoy
commented
Jun 6, 2025

Copy link


Copy Markdown

Member
I'll look in a few
JRoy
JRoy
approved these changes
Jun 6, 2025
View reviewed changes
@JRoy
JRoy
merged commit 997f600
into
EssentialsX:2.xJun 6, 2025
Euphillya added a commit
to Euphillya/Essentials-Folia
that referenced
this pull request
Jun 27, 2025
@Euphillya
Update Upstream EssentialsX:
1070216
EssentialsX@40540eb Expose IUser#getLastActivityTime to API (EssentialsX#6101)
EssentialsX@50b696b Adds social spy message type for in EssentialsDiscord (EssentialsX#5620)
EssentialsX@dabe687 Add SignTransactionEvent for buy and sell signs (EssentialsX#6071)
EssentialsX@0cb387f Fix NPE when unlinking offline players (EssentialsX#6111)
EssentialsX@f09541c Update to Minecraft 1.21.5 (EssentialsX#6109)
EssentialsX@c7ff994 Fire GlobalChatEvent even when local chat is disabled (EssentialsX#6113)
EssentialsX@06c886c Fix /baltop on 1.15.2 and below (EssentialsX#6115)
EssentialsX@2bb4438 Fix further trade sign validation mismatches (EssentialsX#6116)
EssentialsX@8455212 Fix /spawnmob on < 1.21.5 (EssentialsX#6121)
EssentialsX@be3e641 New Crowdin updates (EssentialsX#6089)
EssentialsX@3f5b122 Use legacy text for TranslatableException#getMessage (EssentialsX#6134)
EssentialsX@fe43017 Fix heer typo in messages_en.properties (EssentialsX#6135)
EssentialsX@a58db23 Update English source strings with fixes from Crowdin (EssentialsX#6140)
EssentialsX@d137031 Improve config comments & ordering (EssentialsX#6108)
EssentialsX@3b0c229 New Crowdin updates (EssentialsX#6131)
EssentialsX@3fe1495 Fix unexpected behavior with essentials.home.bed & essentials.sethome.bed permissions (EssentialsX#5991)
EssentialsX@aebe851 Fix double messages when deleting a non-existent home (EssentialsX#6150)
EssentialsX@3a5c7c4 Revert changes to /home and /sethome that break bed interactions (EssentialsX#6151)
EssentialsX@3d28d82 Release 2.21.1
EssentialsX@e836747 Prepare for 2.21.2 dev builds (EssentialsX#6128)
EssentialsX@d42347f Fix sending message during /editsign paste if SignChangeEvent is cancelled (EssentialsX#6136)
EssentialsX@997f600 Update adventure dependencies (EssentialsX#6163)
EssentialsX@4057326 Update to Minecraft 1.21.6
EssentialsX@2796399 Add 1.21.6 Mobs
EssentialsX@31ea903 Move tests to MockBukkit
EssentialsX@ff1b8b8 Add 1.21.6 Aliases
rewsdjad1 pushed a commit
to rewsdjad1/EssentialsXPlus
that referenced
this pull request
Aug 13, 2026
@iiAhmedYT@JRoy
Update adventure dependencies (EssentialsX#6163)
8c6d015
Fixes issues with clickable chat components on 1.21.5
Co-authored-by: Josh Roy <10731363+JRoy@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@JRoyJRoyJRoy approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@iiAhmedYT@JRoy@JasonHorkles

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Update Adventure by iiAhmedYT · Pull Request #6163 · EssentialsX/Essentials · GitHub
Skip to content
Update Adventure - #6163
Merged
JRoy merged 7 commits into
EssentialsX:2.xfrom 
iiAhmedYT:patch-1
Jun 6, 2025
Merged
Update Adventure#6163
JRoy merged 7 commits into
EssentialsX:2.xfrom 
iiAhmedYT:patch-1
Conversation
@iiAhmedYT
@iiAhmedYTiiAhmedYT
commented
Jun 4, 2025

Copy link


Copy Markdown

Contributor
Information
This PR fixes an issue where clickable messages don't work on newer versions (1.21.5).
Details
Proposed fix:

Update Adventure
Environments tested:
OS: Windows, Linux
Java version: 21
  •  Most recent Paper version (1.XX.Y, git-Paper-BUILD)
  •  CraftBukkit/Spigot/Paper 1.12.2
  •  CraftBukkit 1.8.8
Demonstration:
It's really not worth a demonstration lol
@JRoy
JRoy
commented
Jun 4, 2025

Copy link


Copy Markdown

Member
can you bump adventure platform to 4.4.0 as well? otherwise good
@iiAhmedYT
iiAhmedYT
commented
Jun 4, 2025

Copy link


Copy Markdown

ContributorAuthor
Yes sir captin sir 🫡
JRoy
JRoy
previously approved these changes
Jun 4, 2025
View reviewed changes
@JRoyJRoy
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love to see it
@JRoy
JRoy
enabled auto-merge (squash)
June 4, 2025 23:30
@JRoy
JRoy
disabled auto-merge
June 4, 2025 23:30
@JRoy
JRoy
enabled auto-merge (squash)
June 4, 2025 23:31
@JRoy
JRoy
disabled auto-merge
June 4, 2025 23:31
@JRoy
JRoy
enabled auto-merge (squash)
June 4, 2025 23:31
@iiAhmedYT
iiAhmedYT
commented
Jun 4, 2025

Copy link


Copy Markdown

ContributorAuthor
how does it even fail-
@iiAhmedYT
iiAhmedYT
commented
Jun 5, 2025

Copy link


Copy Markdown

ContributorAuthor
Apparently it failed to find Adventure Platform related classes.. (btw it is on Maven Central, so it not being found is actually insanity) the fix is not really on my mind
@JasonHorkles
JasonHorkles
commented
Jun 5, 2025

Copy link


Copy Markdown

Contributor
Probs some maven cache or something silly
@iiAhmedYT
Specify the dependency section with a comment
377c505
Real intention behind this is to rerun the build. lol

auto-merge was automatically disabled
June 5, 2025 12:05
Head branch was pushed to by a user without write access
@iiAhmedYT
iiAhmedYT
commented
Jun 5, 2025

Copy link


Copy Markdown

ContributorAuthor
The error is about a class that isn't even used in the code, im not sure why it's happening but apparently it's loading and compiling just fine, the tests on the other hand aren't doing so fine themselves
@iiAhmedYT
iiAhmedYT
commented
Jun 6, 2025

Copy link


Copy Markdown

ContributorAuthor
Upon further investigation, this line:
https://github.com/KyoriPowered/adventure-platform/blob/main/platform-bukkit/src/main/java/net/kyori/adventure/platform/bukkit/BukkitComponentSerializer.java#L66
which uses Bukkit#getUnsafe#getDataVersion is the reason behind it all, the tests simply cant provide it
A solution would be to use proper testing for Bukkit like MockBukkit
or.. Just temporarily disable these tests
@JRoy
JRoy
commented
Jun 6, 2025

Copy link


Copy Markdown

Member
I'll look in a few
JRoy
JRoy
approved these changes
Jun 6, 2025
View reviewed changes
@JRoy
JRoy
merged commit 997f600
into
EssentialsX:2.xJun 6, 2025
Euphillya added a commit
to Euphillya/Essentials-Folia
that referenced
this pull request
Jun 27, 2025
@Euphillya
Update Upstream EssentialsX:
1070216
EssentialsX@40540eb Expose IUser#getLastActivityTime to API (EssentialsX#6101)
EssentialsX@50b696b Adds social spy message type for in EssentialsDiscord (EssentialsX#5620)
EssentialsX@dabe687 Add SignTransactionEvent for buy and sell signs (EssentialsX#6071)
EssentialsX@0cb387f Fix NPE when unlinking offline players (EssentialsX#6111)
EssentialsX@f09541c Update to Minecraft 1.21.5 (EssentialsX#6109)
EssentialsX@c7ff994 Fire GlobalChatEvent even when local chat is disabled (EssentialsX#6113)
EssentialsX@06c886c Fix /baltop on 1.15.2 and below (EssentialsX#6115)
EssentialsX@2bb4438 Fix further trade sign validation mismatches (EssentialsX#6116)
EssentialsX@8455212 Fix /spawnmob on < 1.21.5 (EssentialsX#6121)
EssentialsX@be3e641 New Crowdin updates (EssentialsX#6089)
EssentialsX@3f5b122 Use legacy text for TranslatableException#getMessage (EssentialsX#6134)
EssentialsX@fe43017 Fix heer typo in messages_en.properties (EssentialsX#6135)
EssentialsX@a58db23 Update English source strings with fixes from Crowdin (EssentialsX#6140)
EssentialsX@d137031 Improve config comments & ordering (EssentialsX#6108)
EssentialsX@3b0c229 New Crowdin updates (EssentialsX#6131)
EssentialsX@3fe1495 Fix unexpected behavior with essentials.home.bed & essentials.sethome.bed permissions (EssentialsX#5991)
EssentialsX@aebe851 Fix double messages when deleting a non-existent home (EssentialsX#6150)
EssentialsX@3a5c7c4 Revert changes to /home and /sethome that break bed interactions (EssentialsX#6151)
EssentialsX@3d28d82 Release 2.21.1
EssentialsX@e836747 Prepare for 2.21.2 dev builds (EssentialsX#6128)
EssentialsX@d42347f Fix sending message during /editsign paste if SignChangeEvent is cancelled (EssentialsX#6136)
EssentialsX@997f600 Update adventure dependencies (EssentialsX#6163)
EssentialsX@4057326 Update to Minecraft 1.21.6
EssentialsX@2796399 Add 1.21.6 Mobs
EssentialsX@31ea903 Move tests to MockBukkit
EssentialsX@ff1b8b8 Add 1.21.6 Aliases
rewsdjad1 pushed a commit
to rewsdjad1/EssentialsXPlus
that referenced
this pull request
Aug 13, 2026
@iiAhmedYT@JRoy
Update adventure dependencies (EssentialsX#6163)
8c6d015
Fixes issues with clickable chat components on 1.21.5
Co-authored-by: Josh Roy <10731363+JRoy@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@JRoyJRoyJRoy approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@iiAhmedYT@JRoy@JasonHorkles

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Update Adventure by iiAhmedYT · Pull Request #6163 · EssentialsX/Essentials · GitHub
Skip to content
Update Adventure - #6163
Merged
JRoy merged 7 commits into
EssentialsX:2.xfrom 
iiAhmedYT:patch-1
Jun 6, 2025
Merged
Update Adventure#6163
JRoy merged 7 commits into
EssentialsX:2.xfrom 
iiAhmedYT:patch-1
Conversation
@iiAhmedYT
@iiAhmedYTiiAhmedYT
commented
Jun 4, 2025

Copy link


Copy Markdown

Contributor
Information
This PR fixes an issue where clickable messages don't work on newer versions (1.21.5).
Details
Proposed fix:

Update Adventure
Environments tested:
OS: Windows, Linux
Java version: 21
  •  Most recent Paper version (1.XX.Y, git-Paper-BUILD)
  •  CraftBukkit/Spigot/Paper 1.12.2
  •  CraftBukkit 1.8.8
Demonstration:
It's really not worth a demonstration lol
@JRoy
JRoy
commented
Jun 4, 2025

Copy link


Copy Markdown

Member
can you bump adventure platform to 4.4.0 as well? otherwise good
@iiAhmedYT
iiAhmedYT
commented
Jun 4, 2025

Copy link


Copy Markdown

ContributorAuthor
Yes sir captin sir 🫡
JRoy
JRoy
previously approved these changes
Jun 4, 2025
View reviewed changes
@JRoyJRoy
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love to see it
@JRoy
JRoy
enabled auto-merge (squash)
June 4, 2025 23:30
@JRoy
JRoy
disabled auto-merge
June 4, 2025 23:30
@JRoy
JRoy
enabled auto-merge (squash)
June 4, 2025 23:31
@JRoy
JRoy
disabled auto-merge
June 4, 2025 23:31
@JRoy
JRoy
enabled auto-merge (squash)
June 4, 2025 23:31
@iiAhmedYT
iiAhmedYT
commented
Jun 4, 2025

Copy link


Copy Markdown

ContributorAuthor
how does it even fail-
@iiAhmedYT
iiAhmedYT
commented
Jun 5, 2025

Copy link


Copy Markdown

ContributorAuthor
Apparently it failed to find Adventure Platform related classes.. (btw it is on Maven Central, so it not being found is actually insanity) the fix is not really on my mind
@JasonHorkles
JasonHorkles
commented
Jun 5, 2025

Copy link


Copy Markdown

Contributor
Probs some maven cache or something silly
@iiAhmedYT
Specify the dependency section with a comment
377c505
Real intention behind this is to rerun the build. lol

auto-merge was automatically disabled
June 5, 2025 12:05
Head branch was pushed to by a user without write access
@iiAhmedYT
iiAhmedYT
commented
Jun 5, 2025

Copy link


Copy Markdown

ContributorAuthor
The error is about a class that isn't even used in the code, im not sure why it's happening but apparently it's loading and compiling just fine, the tests on the other hand aren't doing so fine themselves
@iiAhmedYT
iiAhmedYT
commented
Jun 6, 2025

Copy link


Copy Markdown

ContributorAuthor
Upon further investigation, this line:
https://github.com/KyoriPowered/adventure-platform/blob/main/platform-bukkit/src/main/java/net/kyori/adventure/platform/bukkit/BukkitComponentSerializer.java#L66
which uses Bukkit#getUnsafe#getDataVersion is the reason behind it all, the tests simply cant provide it
A solution would be to use proper testing for Bukkit like MockBukkit
or.. Just temporarily disable these tests
@JRoy
JRoy
commented
Jun 6, 2025

Copy link


Copy Markdown

Member
I'll look in a few
JRoy
JRoy
approved these changes
Jun 6, 2025
View reviewed changes
@JRoy
JRoy
merged commit 997f600
into
EssentialsX:2.xJun 6, 2025
Euphillya added a commit
to Euphillya/Essentials-Folia
that referenced
this pull request
Jun 27, 2025
@Euphillya
Update Upstream EssentialsX:
1070216
EssentialsX@40540eb Expose IUser#getLastActivityTime to API (EssentialsX#6101)
EssentialsX@50b696b Adds social spy message type for in EssentialsDiscord (EssentialsX#5620)
EssentialsX@dabe687 Add SignTransactionEvent for buy and sell signs (EssentialsX#6071)
EssentialsX@0cb387f Fix NPE when unlinking offline players (EssentialsX#6111)
EssentialsX@f09541c Update to Minecraft 1.21.5 (EssentialsX#6109)
EssentialsX@c7ff994 Fire GlobalChatEvent even when local chat is disabled (EssentialsX#6113)
EssentialsX@06c886c Fix /baltop on 1.15.2 and below (EssentialsX#6115)
EssentialsX@2bb4438 Fix further trade sign validation mismatches (EssentialsX#6116)
EssentialsX@8455212 Fix /spawnmob on < 1.21.5 (EssentialsX#6121)
EssentialsX@be3e641 New Crowdin updates (EssentialsX#6089)
EssentialsX@3f5b122 Use legacy text for TranslatableException#getMessage (EssentialsX#6134)
EssentialsX@fe43017 Fix heer typo in messages_en.properties (EssentialsX#6135)
EssentialsX@a58db23 Update English source strings with fixes from Crowdin (EssentialsX#6140)
EssentialsX@d137031 Improve config comments & ordering (EssentialsX#6108)
EssentialsX@3b0c229 New Crowdin updates (EssentialsX#6131)
EssentialsX@3fe1495 Fix unexpected behavior with essentials.home.bed & essentials.sethome.bed permissions (EssentialsX#5991)
EssentialsX@aebe851 Fix double messages when deleting a non-existent home (EssentialsX#6150)
EssentialsX@3a5c7c4 Revert changes to /home and /sethome that break bed interactions (EssentialsX#6151)
EssentialsX@3d28d82 Release 2.21.1
EssentialsX@e836747 Prepare for 2.21.2 dev builds (EssentialsX#6128)
EssentialsX@d42347f Fix sending message during /editsign paste if SignChangeEvent is cancelled (EssentialsX#6136)
EssentialsX@997f600 Update adventure dependencies (EssentialsX#6163)
EssentialsX@4057326 Update to Minecraft 1.21.6
EssentialsX@2796399 Add 1.21.6 Mobs
EssentialsX@31ea903 Move tests to MockBukkit
EssentialsX@ff1b8b8 Add 1.21.6 Aliases
rewsdjad1 pushed a commit
to rewsdjad1/EssentialsXPlus
that referenced
this pull request
Aug 13, 2026
@iiAhmedYT@JRoy
Update adventure dependencies (EssentialsX#6163)
8c6d015
Fixes issues with clickable chat components on 1.21.5
Co-authored-by: Josh Roy <10731363+JRoy@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@JRoyJRoyJRoy approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@iiAhmedYT@JRoy@JasonHorkles

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Update Adventure by iiAhmedYT · Pull Request #6163 · EssentialsX/Essentials · GitHub
Skip to content
Update Adventure - #6163
Merged
JRoy merged 7 commits into
EssentialsX:2.xfrom 
iiAhmedYT:patch-1
Jun 6, 2025
Merged
Update Adventure#6163
JRoy merged 7 commits into
EssentialsX:2.xfrom 
iiAhmedYT:patch-1
Conversation
@iiAhmedYT
@iiAhmedYTiiAhmedYT
commented
Jun 4, 2025

Copy link


Copy Markdown

Contributor
Information
This PR fixes an issue where clickable messages don't work on newer versions (1.21.5).
Details
Proposed fix:

Update Adventure
Environments tested:
OS: Windows, Linux
Java version: 21
  •  Most recent Paper version (1.XX.Y, git-Paper-BUILD)
  •  CraftBukkit/Spigot/Paper 1.12.2
  •  CraftBukkit 1.8.8
Demonstration:
It's really not worth a demonstration lol
@JRoy
JRoy
commented
Jun 4, 2025

Copy link


Copy Markdown

Member
can you bump adventure platform to 4.4.0 as well? otherwise good
@iiAhmedYT
iiAhmedYT
commented
Jun 4, 2025

Copy link


Copy Markdown

ContributorAuthor
Yes sir captin sir 🫡
JRoy
JRoy
previously approved these changes
Jun 4, 2025
View reviewed changes
@JRoyJRoy
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love to see it
@JRoy
JRoy
enabled auto-merge (squash)
June 4, 2025 23:30
@JRoy
JRoy
disabled auto-merge
June 4, 2025 23:30
@JRoy
JRoy
enabled auto-merge (squash)
June 4, 2025 23:31
@JRoy
JRoy
disabled auto-merge
June 4, 2025 23:31
@JRoy
JRoy
enabled auto-merge (squash)
June 4, 2025 23:31
@iiAhmedYT
iiAhmedYT
commented
Jun 4, 2025

Copy link


Copy Markdown

ContributorAuthor
how does it even fail-
@iiAhmedYT
iiAhmedYT
commented
Jun 5, 2025

Copy link


Copy Markdown

ContributorAuthor
Apparently it failed to find Adventure Platform related classes.. (btw it is on Maven Central, so it not being found is actually insanity) the fix is not really on my mind
@JasonHorkles
JasonHorkles
commented
Jun 5, 2025

Copy link


Copy Markdown

Contributor
Probs some maven cache or something silly
@iiAhmedYT
Specify the dependency section with a comment
377c505
Real intention behind this is to rerun the build. lol

auto-merge was automatically disabled
June 5, 2025 12:05
Head branch was pushed to by a user without write access
@iiAhmedYT
iiAhmedYT
commented
Jun 5, 2025

Copy link


Copy Markdown

ContributorAuthor
The error is about a class that isn't even used in the code, im not sure why it's happening but apparently it's loading and compiling just fine, the tests on the other hand aren't doing so fine themselves
@iiAhmedYT
iiAhmedYT
commented
Jun 6, 2025

Copy link


Copy Markdown

ContributorAuthor
Upon further investigation, this line:
https://github.com/KyoriPowered/adventure-platform/blob/main/platform-bukkit/src/main/java/net/kyori/adventure/platform/bukkit/BukkitComponentSerializer.java#L66
which uses Bukkit#getUnsafe#getDataVersion is the reason behind it all, the tests simply cant provide it
A solution would be to use proper testing for Bukkit like MockBukkit
or.. Just temporarily disable these tests
@JRoy
JRoy
commented
Jun 6, 2025

Copy link


Copy Markdown

Member
I'll look in a few
JRoy
JRoy
approved these changes
Jun 6, 2025
View reviewed changes
@JRoy
JRoy
merged commit 997f600
into
EssentialsX:2.xJun 6, 2025
Euphillya added a commit
to Euphillya/Essentials-Folia
that referenced
this pull request
Jun 27, 2025
@Euphillya
Update Upstream EssentialsX:
1070216
EssentialsX@40540eb Expose IUser#getLastActivityTime to API (EssentialsX#6101)
EssentialsX@50b696b Adds social spy message type for in EssentialsDiscord (EssentialsX#5620)
EssentialsX@dabe687 Add SignTransactionEvent for buy and sell signs (EssentialsX#6071)
EssentialsX@0cb387f Fix NPE when unlinking offline players (EssentialsX#6111)
EssentialsX@f09541c Update to Minecraft 1.21.5 (EssentialsX#6109)
EssentialsX@c7ff994 Fire GlobalChatEvent even when local chat is disabled (EssentialsX#6113)
EssentialsX@06c886c Fix /baltop on 1.15.2 and below (EssentialsX#6115)
EssentialsX@2bb4438 Fix further trade sign validation mismatches (EssentialsX#6116)
EssentialsX@8455212 Fix /spawnmob on < 1.21.5 (EssentialsX#6121)
EssentialsX@be3e641 New Crowdin updates (EssentialsX#6089)
EssentialsX@3f5b122 Use legacy text for TranslatableException#getMessage (EssentialsX#6134)
EssentialsX@fe43017 Fix heer typo in messages_en.properties (EssentialsX#6135)
EssentialsX@a58db23 Update English source strings with fixes from Crowdin (EssentialsX#6140)
EssentialsX@d137031 Improve config comments & ordering (EssentialsX#6108)
EssentialsX@3b0c229 New Crowdin updates (EssentialsX#6131)
EssentialsX@3fe1495 Fix unexpected behavior with essentials.home.bed & essentials.sethome.bed permissions (EssentialsX#5991)
EssentialsX@aebe851 Fix double messages when deleting a non-existent home (EssentialsX#6150)
EssentialsX@3a5c7c4 Revert changes to /home and /sethome that break bed interactions (EssentialsX#6151)
EssentialsX@3d28d82 Release 2.21.1
EssentialsX@e836747 Prepare for 2.21.2 dev builds (EssentialsX#6128)
EssentialsX@d42347f Fix sending message during /editsign paste if SignChangeEvent is cancelled (EssentialsX#6136)
EssentialsX@997f600 Update adventure dependencies (EssentialsX#6163)
EssentialsX@4057326 Update to Minecraft 1.21.6
EssentialsX@2796399 Add 1.21.6 Mobs
EssentialsX@31ea903 Move tests to MockBukkit
EssentialsX@ff1b8b8 Add 1.21.6 Aliases
rewsdjad1 pushed a commit
to rewsdjad1/EssentialsXPlus
that referenced
this pull request
Aug 13, 2026
@iiAhmedYT@JRoy
Update adventure dependencies (EssentialsX#6163)
8c6d015
Fixes issues with clickable chat components on 1.21.5
Co-authored-by: Josh Roy <10731363+JRoy@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@JRoyJRoyJRoy approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@iiAhmedYT@JRoy@JasonHorkles

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
Update Adventure by iiAhmedYT · Pull Request #6163 · EssentialsX/Essentials · GitHub
Skip to content
Update Adventure - #6163
Merged
JRoy merged 7 commits into
EssentialsX:2.xfrom 
iiAhmedYT:patch-1
Jun 6, 2025
Merged
Update Adventure#6163
JRoy merged 7 commits into
EssentialsX:2.xfrom 
iiAhmedYT:patch-1
Conversation
@iiAhmedYT
@iiAhmedYTiiAhmedYT
commented
Jun 4, 2025

Copy link


Copy Markdown

Contributor
Information
This PR fixes an issue where clickable messages don't work on newer versions (1.21.5).
Details
Proposed fix:

Update Adventure
Environments tested:
OS: Windows, Linux
Java version: 21
  •  Most recent Paper version (1.XX.Y, git-Paper-BUILD)
  •  CraftBukkit/Spigot/Paper 1.12.2
  •  CraftBukkit 1.8.8
Demonstration:
It's really not worth a demonstration lol
@JRoy
JRoy
commented
Jun 4, 2025

Copy link


Copy Markdown

Member
can you bump adventure platform to 4.4.0 as well? otherwise good
@iiAhmedYT
iiAhmedYT
commented
Jun 4, 2025

Copy link


Copy Markdown

ContributorAuthor
Yes sir captin sir 🫡
JRoy
JRoy
previously approved these changes
Jun 4, 2025
View reviewed changes
@JRoyJRoy
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love to see it
@JRoy
JRoy
enabled auto-merge (squash)
June 4, 2025 23:30
@JRoy
JRoy
disabled auto-merge
June 4, 2025 23:30
@JRoy
JRoy
enabled auto-merge (squash)
June 4, 2025 23:31
@JRoy
JRoy
disabled auto-merge
June 4, 2025 23:31
@JRoy
JRoy
enabled auto-merge (squash)
June 4, 2025 23:31
@iiAhmedYT
iiAhmedYT
commented
Jun 4, 2025

Copy link


Copy Markdown

ContributorAuthor
how does it even fail-
@iiAhmedYT
iiAhmedYT
commented
Jun 5, 2025

Copy link


Copy Markdown

ContributorAuthor
Apparently it failed to find Adventure Platform related classes.. (btw it is on Maven Central, so it not being found is actually insanity) the fix is not really on my mind
@JasonHorkles
JasonHorkles
commented
Jun 5, 2025

Copy link


Copy Markdown

Contributor
Probs some maven cache or something silly
@iiAhmedYT
Specify the dependency section with a comment
377c505
Real intention behind this is to rerun the build. lol

auto-merge was automatically disabled
June 5, 2025 12:05
Head branch was pushed to by a user without write access
@iiAhmedYT
iiAhmedYT
commented
Jun 5, 2025

Copy link


Copy Markdown

ContributorAuthor
The error is about a class that isn't even used in the code, im not sure why it's happening but apparently it's loading and compiling just fine, the tests on the other hand aren't doing so fine themselves
@iiAhmedYT
iiAhmedYT
commented
Jun 6, 2025

Copy link


Copy Markdown

ContributorAuthor
Upon further investigation, this line:
https://github.com/KyoriPowered/adventure-platform/blob/main/platform-bukkit/src/main/java/net/kyori/adventure/platform/bukkit/BukkitComponentSerializer.java#L66
which uses Bukkit#getUnsafe#getDataVersion is the reason behind it all, the tests simply cant provide it
A solution would be to use proper testing for Bukkit like MockBukkit
or.. Just temporarily disable these tests
@JRoy
JRoy
commented
Jun 6, 2025

Copy link


Copy Markdown

Member
I'll look in a few
JRoy
JRoy
approved these changes
Jun 6, 2025
View reviewed changes
@JRoy
JRoy
merged commit 997f600
into
EssentialsX:2.xJun 6, 2025
Euphillya added a commit
to Euphillya/Essentials-Folia
that referenced
this pull request
Jun 27, 2025
@Euphillya
Update Upstream EssentialsX:
1070216
EssentialsX@40540eb Expose IUser#getLastActivityTime to API (EssentialsX#6101)
EssentialsX@50b696b Adds social spy message type for in EssentialsDiscord (EssentialsX#5620)
EssentialsX@dabe687 Add SignTransactionEvent for buy and sell signs (EssentialsX#6071)
EssentialsX@0cb387f Fix NPE when unlinking offline players (EssentialsX#6111)
EssentialsX@f09541c Update to Minecraft 1.21.5 (EssentialsX#6109)
EssentialsX@c7ff994 Fire GlobalChatEvent even when local chat is disabled (EssentialsX#6113)
EssentialsX@06c886c Fix /baltop on 1.15.2 and below (EssentialsX#6115)
EssentialsX@2bb4438 Fix further trade sign validation mismatches (EssentialsX#6116)
EssentialsX@8455212 Fix /spawnmob on < 1.21.5 (EssentialsX#6121)
EssentialsX@be3e641 New Crowdin updates (EssentialsX#6089)
EssentialsX@3f5b122 Use legacy text for TranslatableException#getMessage (EssentialsX#6134)
EssentialsX@fe43017 Fix heer typo in messages_en.properties (EssentialsX#6135)
EssentialsX@a58db23 Update English source strings with fixes from Crowdin (EssentialsX#6140)
EssentialsX@d137031 Improve config comments & ordering (EssentialsX#6108)
EssentialsX@3b0c229 New Crowdin updates (EssentialsX#6131)
EssentialsX@3fe1495 Fix unexpected behavior with essentials.home.bed & essentials.sethome.bed permissions (EssentialsX#5991)
EssentialsX@aebe851 Fix double messages when deleting a non-existent home (EssentialsX#6150)
EssentialsX@3a5c7c4 Revert changes to /home and /sethome that break bed interactions (EssentialsX#6151)
EssentialsX@3d28d82 Release 2.21.1
EssentialsX@e836747 Prepare for 2.21.2 dev builds (EssentialsX#6128)
EssentialsX@d42347f Fix sending message during /editsign paste if SignChangeEvent is cancelled (EssentialsX#6136)
EssentialsX@997f600 Update adventure dependencies (EssentialsX#6163)
EssentialsX@4057326 Update to Minecraft 1.21.6
EssentialsX@2796399 Add 1.21.6 Mobs
EssentialsX@31ea903 Move tests to MockBukkit
EssentialsX@ff1b8b8 Add 1.21.6 Aliases
rewsdjad1 pushed a commit
to rewsdjad1/EssentialsXPlus
that referenced
this pull request
Aug 13, 2026
@iiAhmedYT@JRoy
Update adventure dependencies (EssentialsX#6163)
8c6d015
Fixes issues with clickable chat components on 1.21.5
Co-authored-by: Josh Roy <10731363+JRoy@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@JRoyJRoyJRoy approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@iiAhmedYT@JRoy@JasonHorkles