Skip to content

Switch to configuration based events on Paper - #6248

Merged
JRoy merged 7 commits into
EssentialsX:2.xfrom
JRoy:feat/paper-config-api
Sep 19, 2025
Merged

Switch to configuration based events on Paper#6248
JRoy merged 7 commits into
EssentialsX:2.xfrom
JRoy:feat/paper-config-api

Conversation

@JRoy

@JRoyJRoy commented Aug 3, 2025

Copy link
Copy Markdown
Member

Moves away from PlayerLoginEvent on Paper and makes use of the new configuration state to load user/locale data during configuration phase. Not only does this ensure all I/O is done async before the player even joins but also finally allows us to actually set the join message in the PlayerJoinEvent.

This also fixes#5796 and closes#5848

@JRoyJRoy added this to the 2.22.0 milestone Aug 3, 2025
@JRoyJRoy added type: enhancement Features and feature requests. module: main Issues or PRs for the main Essentials module labels Aug 3, 2025
@JRoy
JRoy marked this pull request as ready for review August 4, 2025 05:24
@R00tB33rMan

Copy link
Copy Markdown

Moves away from PlayerLoginEvent on Paper and makes use of the new configuration state to load user/locale data during configuration phase. Not only does this ensure all I/O is done async before the player even joins but also finally allows us to actually set the join message in the PlayerJoinEvent.

This also fixes #5796 and closes #5848

Not sure if this is out of scope for this PR; however, the PlayerLoginEvent is now considered deprecated on newer versions of Paper. Maybe the AsyncPlayerPreLoginEvent should be used instead?

@JRoy

JRoy commented Aug 4, 2025

Copy link
Copy Markdown
MemberAuthor

Moves away from PlayerLoginEvent on Paper and makes use of the new configuration state to load user/locale data during configuration phase. Not only does this ensure all I/O is done async before the player even joins but also finally allows us to actually set the join message in the PlayerJoinEvent.

This also fixes #5796 and closes #5848

Not sure if this is out of scope for this PR; however, the PlayerLoginEvent is now considered deprecated on newer versions of Paper. Maybe the AsyncPlayerPreLoginEvent should be used instead?

this pr moves us away from the PlayerLoginEvent on paper :))

@R00tB33rMan

Copy link
Copy Markdown

Moves away from PlayerLoginEvent on Paper and makes use of the new configuration state to load user/locale data during configuration phase. Not only does this ensure all I/O is done async before the player even joins but also finally allows us to actually set the join message in the PlayerJoinEvent.
This also fixes #5796 and closes #5848

Not sure if this is out of scope for this PR; however, the PlayerLoginEvent is now considered deprecated on newer versions of Paper. Maybe the AsyncPlayerPreLoginEvent should be used instead?

this pr moves us away from the PlayerLoginEvent on paper :))

Ah yeah, must’ve misread. I saw the event still used elsewhere without realizing that it was intended for Spigot

# Conflicts:
#	Essentials/src/main/java/com/earth2me/essentials/perm/impl/LuckPermsHandler.java

@mdcfemdcfe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clrxbl told me to reject this

@JRoy
JRoy requested a review from mdcfeSeptember 19, 2025 14:40
@JRoy
JRoy added this pull request to the merge queueSep 19, 2025
Merged via the queue into EssentialsX:2.x with commit 37e1054Sep 19, 2025
1 check passed
@JRoy
JRoy deleted the feat/paper-config-api branch September 19, 2025 14:50
Euphillya added a commit to Euphillya/Essentials-Folia that referenced this pull request Sep 21, 2025
EssentialsX@37e1054 Switch to configuration based events on Paper (EssentialsX#6248)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: mainIssues or PRs for the main Essentials moduletype: enhancementFeatures and feature requests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Minecraft default join message is not translated

3 participants

@JRoy@R00tB33rMan@mdcfe