Skip to content

Allow UTF-8 console input - #425

Merged
ITaluone merged 1 commit into
Fallout-build:mainfrom
ITaluone:fix/utf8-console-input
Jun 30, 2026
Merged

Allow UTF-8 console input#425
ITaluone merged 1 commit into
Fallout-build:mainfrom
ITaluone:fix/utf8-console-input

Conversation

@ITaluone

@ITaluoneITaluone commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Original description

There is a problem for user wanting to input non-ascii characters (ex. cyrillic) during parameter prompt

All credits going to: @rus-art Thank you!

Taken from here: nuke-build/nuke#1321

@ITaluone
ITaluone requested a review from a team as a code ownerJune 25, 2026 05:13
@ChrisonSimtianChrisonSimtian added the Can Merge These PRs are just waiting to be merged, nothing more to do and maintainer has approved label Jun 25, 2026
@ChrisonSimtian
ChrisonSimtian self-requested a review June 26, 2026 22:15

@ChrisonSimtianChrisonSimtian left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally lgtm, might be good to pull this into a IsValidInputKey() extension and put some unit tests around it

@dennisdoomendennisdoomen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you extend the description a bit? What is it solving? Any chance for some test coverage?

@ITaluone

ITaluone commented Jun 29, 2026

Copy link
Copy Markdown
ContributorAuthor

I was just "backporting" a fix from the original repo, which I thought it would be useful*.

Like the original description says: It previously wasn't allowed to have e.g. cyrillic letters as console input.

Nothing more, nothing less :)

*) I think we should port over fixes propagated by other NUKE contributors to let them know about this one.

@ITaluone

Copy link
Copy Markdown
ContributorAuthor

generally lgtm, might be good to pull this into a IsValidInputKey() extension and put some unit tests around it

On to it

@ITaluone
ITaluoneforce-pushed the fix/utf8-console-input branch 3 times, most recently from 56fc6fc to 7263df1CompareJune 29, 2026 06:55
@ChrisonSimtianChrisonSimtian added enhancement New feature or request and removed Can Merge These PRs are just waiting to be merged, nothing more to do and maintainer has approved labels Jun 29, 2026
@ChrisonSimtian

ChrisonSimtian commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator

can we dial this one back a bit, please? Im all for the interface and such but I think this should be a smaller PR just for the UTF support. We can introduce interfaces and refactor this later :-)
Just make it an extension and give it a simple unit test, we touch it up later ;-)
@ITaluone

@ITaluone

ITaluone commented Jun 29, 2026

Copy link
Copy Markdown
ContributorAuthor

Ok.. but I don't get it.. you asked for unit tests.. and these are the changes to do so?

Edit: done

@ITaluone
ITaluoneforce-pushed the fix/utf8-console-input branch from 7263df1 to 1f5c763CompareJune 29, 2026 19:42

@ChrisonSimtianChrisonSimtian left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

way better :-) This way the blast radius is a bit smaller. And we hold off with the bigger refactoring a bit, I'm cooking something in behind the scenes that might make the refactoring obsolete ;-)

@ChrisonSimtianChrisonSimtian added the Can Merge These PRs are just waiting to be merged, nothing more to do and maintainer has approved label Jun 30, 2026
@ITaluone
ITaluone enabled auto-merge (rebase) June 30, 2026 08:10
@ITaluone
ITaluoneforce-pushed the fix/utf8-console-input branch from 1f5c763 to c7dd8e7CompareJune 30, 2026 15:10
Move the valid console key check into an extension and add test cases
All credits going to: @rus-art
Taken from here: nuke-build/nuke#1321
@ITaluone
ITaluoneforce-pushed the fix/utf8-console-input branch from c7dd8e7 to 68651afCompareJune 30, 2026 15:11
@ITaluone
ITaluone merged commit f57634c into Fallout-build:mainJun 30, 2026
1 check passed
@ITaluone
ITaluone deleted the fix/utf8-console-input branch June 30, 2026 15:54
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Can MergeThese PRs are just waiting to be merged, nothing more to do and maintainer has approvedenhancementNew feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@ITaluone@ChrisonSimtian@dennisdoomen