Skip to content

Refactor the UTF8 console input - #444

Merged
ITaluone merged 1 commit into
Fallout-build:mainfrom
ITaluone:refactor/utf8-console-input
Jul 15, 2026
Merged

Refactor the UTF8 console input#444
ITaluone merged 1 commit into
Fallout-build:mainfrom
ITaluone:refactor/utf8-console-input

Conversation

@ITaluone

@ITaluoneITaluone commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Refactor on top of #425

@ITaluone
ITaluone requested a review from a team as a code ownerJune 29, 2026 19:48
@ITaluone
ITaluone marked this pull request as draft June 29, 2026 19:51
@ITaluoneITaluone changed the title Refactor the utf8 console inputRefactor the UTF8 console inputJun 29, 2026
@ChrisonSimtian

ChrisonSimtian commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

just adding to this: https://github.com/ChrisonSimtian/Fallout/pulls
I'm doing a bigger refactoring of the underlying architecture so this might or might not become obsolete once this lands.
While I do appreciate your work in this area, I would suggest we wait until this piece has landed and then look into it again from a new perspective :-)

@ChrisonSimtianChrisonSimtian added needs-triage Dont Merge This cant be merged for various reasons (i.e. its being hold back, its broken, etc) labels Jun 30, 2026
@ChrisonSimtianChrisonSimtian added the target/vCurrent Targets the current version label Jul 8, 2026
@ChrisonSimtian

ChrisonSimtian commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

lets target this for v2026 as soon as we got the next minor release out :-)

@ITaluone
ITaluoneforce-pushed the refactor/utf8-console-input branch from cea4885 to a5759e0CompareJuly 8, 2026 06:39
@ITaluone
ITaluone marked this pull request as ready for review July 8, 2026 12:46
@ChrisonSimtianChrisonSimtian added the enhancement New feature or request label Jul 11, 2026
@ITaluone
ITaluoneforce-pushed the refactor/utf8-console-input branch from a5759e0 to 88653acCompareJuly 13, 2026 13:57
ChrisonSimtian
ChrisonSimtian approved these changes Jul 15, 2026
View reviewed changes

@ChrisonSimtianChrisonSimtian left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets get that in now, small steps but we're going into the right direction 😬 thanks for helping pushing this up the hill 😊

@ITaluone

ITaluone commented Jul 15, 2026

Copy link
Copy Markdown
ContributorAuthor

so... merge?

@ITaluoneITaluone removed the Dont Merge This cant be merged for various reasons (i.e. its being hold back, its broken, etc) label Jul 15, 2026
@ITaluone
ITaluone merged commit 91695e2 into Fallout-build:mainJul 15, 2026
1 check passed
@ITaluone
ITaluone deleted the refactor/utf8-console-input branch July 15, 2026 14:14
@dennisdoomendennisdoomen added skip-changelog Dont add to the Github Release Notes and removed enhancement New feature or request labels Jul 20, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChrisonSimtianChrisonSimtianChrisonSimtian approved these changes

Assignees

No one assigned

Labels

needs-triageskip-changelogDont add to the Github Release Notestarget/vCurrentTargets the current version

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ITaluone@ChrisonSimtian@dennisdoomen