fix(rp2040): resolve bundled Arduino-Pico libraries

[zackees]

Fixes#1248.\n\nArduino-Pico framework libraries are now discovered by the RP2040/RP2350 package and the RP orchestrator follows the shared framework-library dependency flow already used by STM32 and Teensy. This exposes headers such as WiFi.h and compiles only selected framework-library sources.\n\nIncludes a regression test for the bundled WiFi library and bumps fbuild to 2.5.8 so the FastLED RP2350W bring-up can consume the fix.

Summary by CodeRabbit

• New Features
  • RP2040 builds now automatically discover and include framework libraries, source files, and header directories.
  • Improved framework dependency selection using available cached or declared libraries.
• Bug Fixes
  • Added warnings for unsupported library dependency modes.
  • Improved WiFi framework header and source detection.
• Release
  • Updated the project version to 2.5.8.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: f8a004ee-b2b3-45e6-83d9-27441a8bb4fa

📥 Commits

Reviewing files that changed from the base of the PR and between 2c6ef53 and 48b1e44.

⛔ Files ignored due to path filters (1)

• Cargo.lock is excluded by !**/*.lock

📒 Files selected for processing (4)

• Cargo.toml
• crates/fbuild-build-arm/src/rp2040/orchestrator.rs
• crates/fbuild-library/src/library/rp2040_core.rs
• pyproject.toml

---

📝 Walkthrough

Walkthrough

RP2040 builds now discover bundled framework libraries, resolve selected dependencies, compile their sources, and include their directories. WiFi discovery is tested. Workspace and Python package versions were updated to 2.5.8.

Changes

RP2040 framework library integration

Layer / File(s)	Summary
Framework library discovery and exposure crates/fbuild-library/src/library/rp2040_core.rs	Rp2040Cores now exposes bundled framework libraries and aggregate include directories. Tests cover WiFi header and source detection.
RP2040 build orchestration crates/fbuild-build-arm/src/rp2040/orchestrator.rs	The orchestrator resolves framework dependencies, reports unsupported LDF modes, appends selected sources, and adds framework include directories.
Package version update Cargo.toml, pyproject.toml	The workspace and Python package versions changed from 2.5.7 to 2.5.8.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
participant RP2040Orchestrator
participant Rp2040Cores
participant LDFResolver
participant Compiler
RP2040Orchestrator->>Rp2040Cores: Get bundled libraries and include directories
RP2040Orchestrator->>LDFResolver: Resolve declared framework dependencies
LDFResolver-->>RP2040Orchestrator: Return selected framework sources
RP2040Orchestrator->>Compiler: Compile core and selected framework sources
RP2040Orchestrator->>Compiler: Add framework include directories

Loading

Possibly related issues

• fix(rp2040): honor bundled framework libraries and lib_deps #1247 — Covers the RP2040 bundled framework-library and lib_deps resolution implemented by this change.

Possibly related PRs

• FastLED/fbuild#1023 — Updates the same workspace and Python package version files.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/rp2040-framework-libraries-1248

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}