fix(rp2040): scope framework library includes

[zackees]

Fixes#1250.\n\nRP2040/RP2350 now passes only the transitive LDF selection's include directories to the compiler. This prevents Arduino-Pico's WiFi/lwIP_CYW43 path from resolving private headers out of the unrelated lwIP_Ethernet library.\n\nAdds a regression test for the RP2350W WiFi include collision and bumps fbuild to 2.5.9.

Summary by CodeRabbit

• New Features

  • Improved RP2040 framework library selection during builds.
  • Selected libraries now provide their required source files and include paths automatically.

• Bug Fixes

  • Prevented unrelated framework libraries, including unused lwIP backends, from affecting compiler include paths.
  • Improved reliability when using cached framework-library selections.

• Chores

  • Updated the project version to 2.5.9.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 2e269e9a-e6ec-49ea-a866-f26b6a2861ea

📥 Commits

Reviewing files that changed from the base of the PR and between 5481d87 and 7cc8945.

⛔ Files ignored due to path filters (1)

• Cargo.lock is excluded by !**/*.lock

📒 Files selected for processing (4)

• Cargo.toml
• crates/fbuild-build-arm/src/rp2040/orchestrator.rs
• crates/fbuild-build-engine/src/framework_libs.rs
• pyproject.toml

---

📝 Walkthrough

Walkthrough

The framework library resolver now returns selected source files and include directories. RP2040 builds consume both values. Regression coverage verifies that unrelated lwIP include directories are excluded. Project versions are updated to 2.5.9.

Changes

Framework library selection

Layer / File(s)	Summary
Selection API and cached resolution crates/fbuild-build-engine/src/framework_libs.rs	The build engine exposes active and cached selection resolvers. The existing source resolver extracts source_files. Cache failures fall back to active resolution. Tests verify selected transitive include directories.
RP2040 selection integration crates/fbuild-build-arm/src/rp2040/orchestrator.rs	The RP2040 orchestrator appends selected source files and passes selected include directories to the compiler.
Release version alignment Cargo.toml, pyproject.toml	The workspace and Python project versions change from 2.5.8 to 2.5.9.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
participant RP2040Orchestrator
participant FrameworkLibraryResolver
participant RP2040Compiler
RP2040Orchestrator->>FrameworkLibraryResolver: resolve framework library selection
FrameworkLibraryResolver-->>RP2040Orchestrator: return source files and include directories
RP2040Orchestrator->>RP2040Compiler: append sources and selected include paths

Loading

Possibly related issues

• fix(rp2040): restrict Arduino-Pico include paths to selected libraries #1250: Restricts RP2040 compiler include paths to selected framework libraries and their transitive include directories.
• fix(rp2040): honor bundled framework libraries and lib_deps #1247: Updates RP2040 framework-library and lib_deps resolution to compile selected sources and include directories.
• fix(rp2040): resolve bundled Arduino-Pico libraries #1248: Updates RP2040 framework-library resolution to select bundled sources and include directories.

Possibly related PRs

• FastLED/fbuild#1097: Introduces the framework-library selection APIs extended by this PR.
• FastLED/fbuild#1249: Refactors RP2040 framework-library resolution to propagate source files and include directories.

✨ Finishing Touches 💡 1

🛠️ Fix failing CI checks 💡

• Create stacked PR
• Commit on current branch

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/rp2040-selected-library-includes-1250

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}