Skip to content

feat(Engine): Evaluate from EvaluationContext - #108

Merged
emyller merged 27 commits into
mainfrom
feat/context-values
Oct 17, 2025
Merged

feat(Engine): Evaluate from EvaluationContext#108
emyller merged 27 commits into
mainfrom
feat/context-values

Conversation

@emyller

@emylleremyller commented Sep 18, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Warning

Because we decided to break this project into smaller pieces only after work started, this branch will only see the engine changes.

Contributes to #98

This is pass 1 of 3.

  1. Implement get_evaluation_result + engine tests passing. No deleted code. (this PR)
  2. Use the new engine in the client local evaluation. Minimal changes. (PR)
  3. Delete unused code. Minimal refactor. (PR)

The engine work is largely inspired by flagsmith-engine.

Note

Notes are added to call for discussion or follow up.

@emyller
emyllerforce-pushed the feat/context-values branch 6 times, most recently from 8a8c07a to 3f2eaf4CompareSeptember 24, 2025 23:22
@emylleremyller self-assigned this Sep 24, 2025
emyller
emyller commented Sep 25, 2025
View reviewed changes
Comment threadsrc/Engine/Engine.php
emyller
emyller commented Sep 25, 2025
View reviewed changes
Comment threadtests/Engine/EngineTests/EngineDataTest.php Outdated
emyller
emyller commented Sep 25, 2025
View reviewed changes
Comment threadsrc/Engine/Utils/Types/Context/FeatureContext.php Outdated
emyller
emyller commented Oct 1, 2025
View reviewed changes
Comment thread.gitmodules Outdated
@emyller
emyller changed the base branch from main to feat/context-values-umbrellaOctober 2, 2025 01:43
@emyller
emyllerforce-pushed the feat/context-values branch from 4e231b6 to cc6ae4cCompareOctober 2, 2025 01:55
@emyller
emyller marked this pull request as ready for review October 2, 2025 01:57
@emyller
emyller requested a review from a team as a code ownerOctober 2, 2025 01:57
@emyller
emyller requested review from gagantrivedi and removed request for a teamOctober 2, 2025 01:57
@khvn26
khvn26 self-requested a review October 2, 2025 08:52
khvn26
khvn26 requested changes Oct 2, 2025
View reviewed changes

@khvn26khvn26 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall — just a handful of comments, some of them relevant to Flagsmith/engine-test-data#14.

Comment threadsrc/Engine/Utils/Types/Context/EnvironmentContext.php Outdated
Comment threadsrc/Engine/Engine.php
Comment threadsrc/Engine/Engine.php
Comment threadsrc/Engine/Engine.php Outdated
Comment threadsrc/Engine/Engine.php
Comment threadsrc/Engine/Engine.php Outdated
@emyller
Please run tests
bfd03c3
(cherry picked from commit 2913611)
khvn26
khvn26 approved these changes Oct 14, 2025
View reviewed changes

@khvn26khvn26 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the current test suite passing, I'm confident to approve this.

khvn26
khvn26 requested changes Oct 14, 2025
View reviewed changes

@khvn26khvn26 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, one last comment: we need to implement https://github.com/Flagsmith/engine-test-data/pull/28/files.

@emyller

emyller commented Oct 14, 2025

Copy link
Copy Markdown
ContributorAuthor

Sorry, one last comment: we need to implement https://github.com/Flagsmith/engine-test-data/pull/28/files.

Addressed in acc06b3. The client side also follows with 4145960.

@emyller
emyller requested a review from khvn26October 14, 2025 22:21
khvn26
khvn26 reviewed Oct 15, 2025
View reviewed changes
Comment thread.gitmodules Outdated
khvn26
khvn26 reviewed Oct 15, 2025
View reviewed changes

@khvn26khvn26 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny comment and we're good to go.

khvn26
khvn26 previously approved these changes Oct 15, 2025
View reviewed changes

@khvn26khvn26 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

gagantrivedi
gagantrivedi previously approved these changes Oct 16, 2025
View reviewed changes
@emyller
emyller changed the base branch from feat/context-values-umbrella to mainOctober 16, 2025 14:02
@emyller
emyller dismissed stale reviews from gagantrivedi and khvn26October 16, 2025 14:02

The base branch was changed.

@emyller
emyller merged commit 4cb3481 into mainOct 17, 2025
4 checks passed
@emyller
emyller deleted the feat/context-values branch October 17, 2025 14:46
@flagsmithdevflagsmithdev mentioned this pull request Oct 17, 2025
Merged
@emylleremyller mentioned this pull request Nov 18, 2025
Merged
1 task
@emylleremyller mentioned this pull request Dec 3, 2025
Merged
4 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@khvn26khvn26khvn26 approved these changes
@gagantrivedigagantrivedigagantrivedi left review comments

Assignees

@emylleremyller

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@emyller@khvn26@gagantrivedi