Skip to content

feat(Local evaluation): Use the new context-based engine - #109

Merged
khvn26 merged 57 commits into
mainfrom
feat/context-values-client
Oct 20, 2025
Merged

feat(Local evaluation): Use the new context-based engine#109
khvn26 merged 57 commits into
mainfrom
feat/context-values-client

Conversation

@emyller

@emylleremyller commented Oct 2, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Contributes to #98

This is pass 2 of 3.

  1. Implement get_evaluation_result + engine tests passing. No deleted code. (PR)
  2. Use the new engine in the client local evaluation. Minimal changes. (this PR)
  3. Delete unused code. Minimal refactor. (future PR)

Warning

CANNOT MERGE before #108 (pass 1).

The client work is largely inspired by flagsmith-python-client.

@emyller
emyller requested a review from a team as a code ownerOctober 2, 2025 02:26
@emyller
emyller requested review from khvn26 and removed request for a teamOctober 2, 2025 02:26
@emylleremyller self-assigned this Oct 2, 2025
@emylleremyller changed the title WIP: First pass at using the new enginefeat(Local evaluation): Use the new context-based engineOct 2, 2025
@emyller
emyller marked this pull request as draft October 2, 2025 02:32
@emylleremyller mentioned this pull request Oct 3, 2025
Merged
emyller
emyller commented Oct 4, 2025
View reviewed changes
Comment threadsrc/Utils/Mappers.php Outdated
khvn26
khvn26 reviewed Oct 15, 2025
View reviewed changes
Comment threadsrc/Utils/Mappers.php Outdated
@emyller
emyller requested a review from khvn26October 16, 2025 18:14
khvn26

This comment was marked as outdated.

Sign in to view

khvn26
khvn26 reviewed Oct 16, 2025
View reviewed changes
Comment threadsrc/Flagsmith.php Outdated
khvn26
khvn26 requested changes Oct 16, 2025
View reviewed changes

@khvn26khvn26 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, one more comment from me to address.

@emyller
emyllerforce-pushed the feat/context-values-client branch from c5015d7 to a75e860CompareOctober 17, 2025 00:32
@emyller
emyller requested a review from khvn26October 17, 2025 00:50
khvn26
khvn26 previously approved these changes Oct 17, 2025
View reviewed changes

@khvn26khvn26 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥳

Base automatically changed from feat/context-values to mainOctober 17, 2025 14:46
@emyller
emyller dismissed khvn26’s stale reviewOctober 17, 2025 14:46

The base branch was changed.

@khvn26
khvn26 self-requested a review October 17, 2025 14:57
khvn26
khvn26 approved these changes Oct 17, 2025
View reviewed changes

@khvn26khvn26 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool.

gagantrivedi
gagantrivedi reviewed Oct 20, 2025
View reviewed changes
Comment threadsrc/Flagsmith.php
gagantrivedi
gagantrivedi reviewed Oct 20, 2025
View reviewed changes
Comment threadsrc/Utils/Mappers.php
@khvn26

khvn26 commented Oct 20, 2025

Copy link
Copy Markdown
Member

Created #111 to address @gagantrivedi's comments.

@khvn26
khvn26 merged commit 66435a6 into mainOct 20, 2025
3 checks passed
@khvn26
khvn26 deleted the feat/context-values-client branch October 20, 2025 13:11
@flagsmithdevflagsmithdev mentioned this pull request Oct 17, 2025
Merged
@emylleremyller mentioned this pull request Oct 30, 2025
Merged
@emylleremyller mentioned this pull request Nov 18, 2025
Merged
1 task
@emylleremyller mentioned this pull request Dec 3, 2025
Merged
4 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gagantrivedigagantrivedigagantrivedi approved these changes
@khvn26khvn26khvn26 approved these changes

Assignees

@emylleremyller

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@emyller@khvn26@gagantrivedi