Skip to content

chore: replacing-deprecated-methods - #143

Merged
Zaimwa9 merged 19 commits into
mainfrom
chore/use-get-evaluation-result
Aug 19, 2025
Merged

chore: replacing-deprecated-methods#143
Zaimwa9 merged 19 commits into
mainfrom
chore/use-get-evaluation-result

Conversation

@Zaimwa9

@Zaimwa9Zaimwa9 commented Aug 14, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Anticipating the deprecation of former feature_states methods in favor of get_evaluation_result

How did you test this code

  • Added tests on model
  • Improved existing test
  • Removed all deprecation warnings
image

@Zaimwa9
Zaimwa9 requested a review from khvn26August 14, 2025 10:43
@github-actionsgithub-actionsBot added chore and removed chore labels Aug 14, 2025
Zaimwa9
Zaimwa9 commented Aug 14, 2025
View reviewed changes
Comment threadflagsmith/flagsmith.py Outdated
khvn26
khvn26 reviewed Aug 14, 2025
View reviewed changes
Comment threadflagsmith/flagsmith.py Outdated
@github-actionsgithub-actionsBot added chore and removed chore labels Aug 14, 2025
@Zaimwa9
Zaimwa9 requested a review from khvn26August 14, 2025 14:02
@github-actionsgithub-actionsBot added chore and removed chore labels Aug 14, 2025
@github-actionsgithub-actionsBot added chore and removed chore labels Aug 14, 2025
khvn26
khvn26 reviewed Aug 14, 2025
View reviewed changes
Comment threadflagsmith/flagsmith.py
@github-actionsgithub-actionsBot added chore and removed chore labels Aug 14, 2025
Zaimwa9
Zaimwa9 commented Aug 14, 2025
View reviewed changes
Comment threadpyproject.toml Outdated
@github-actionsgithub-actionsBot added chore and removed chore labels Aug 14, 2025
@github-actionsgithub-actionsBot added chore and removed chore labels Aug 14, 2025
@khvn26khvn26 mentioned this pull request Aug 14, 2025
Merged
khvn26
khvn26 previously approved these changes Aug 15, 2025
View reviewed changes
@Zaimwa9Zaimwa9 mentioned this pull request Aug 15, 2025
Closed
@khvn26khvn26 mentioned this pull request Aug 15, 2025
Closed
@github-actionsgithub-actionsBot added chore and removed chore labels Aug 18, 2025
@github-actionsgithub-actionsBot added chore and removed chore labels Aug 18, 2025
@github-actionsgithub-actionsBot added chore and removed chore labels Aug 19, 2025
khvn26
khvn26 approved these changes Aug 19, 2025
View reviewed changes

@khvn26khvn26 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Zaimwa9
Zaimwa9 merged commit 03715ab into mainAug 19, 2025
7 checks passed
@Zaimwa9
Zaimwa9 deleted the chore/use-get-evaluation-result branch August 19, 2025 13:26
@flagsmithdevflagsmithdev mentioned this pull request Aug 21, 2025
Merged
@amleczkoamleczko mentioned this pull request Sep 12, 2025
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@khvn26khvn26khvn26 approved these changes

Assignees

@khvn26khvn26

Labels

chore

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Zaimwa9@khvn26