Skip to content

feat!: evaluation context mappers - #87

Merged
Zaimwa9 merged 25 commits into
mainfrom
feat/evaluation-context-mappers
Nov 12, 2025
Merged

feat!: evaluation context mappers#87
Zaimwa9 merged 25 commits into
mainfrom
feat/evaluation-context-mappers

Conversation

@Zaimwa9

@Zaimwa9Zaimwa9 commented Oct 23, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Contributes to #81

This is pass 1 of 4.

  • Implement document to evaluation context mappers (map_environment_model_to_evaluation_context, map_identity_overrides_to_segments, map_segment_rule_to_model, map_identity_model_to_identity_context)
  • Metadata consistently added to features and segment overrides
  • Add tests around the mappers
  • Preparation to implement evaluationResult
  • Tests inspired from PHP

How did you test this code?

  • Added tests

@Zaimwa9
Zaimwa9 requested a review from a team as a code ownerOctober 23, 2025 09:29
@Zaimwa9
Zaimwa9 requested review from gagantrivedi and removed request for a teamOctober 23, 2025 09:29
khvn26
khvn26 requested changes Oct 23, 2025
View reviewed changes

@khvn26khvn26 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, with a handful of comments.

Comment threadlib/flagsmith/engine/evaluation/mappers.rb Outdated
Comment threadlib/flagsmith/engine/evaluation/mappers.rb Outdated
Comment threadlib/flagsmith/engine/evaluation/mappers.rb Outdated
Comment threadlib/flagsmith/engine/evaluation/mappers.rb Outdated
Comment threadlib/flagsmith/engine/evaluation/mappers.rb Outdated
Zaimwa9
Zaimwa9 commented Nov 10, 2025
View reviewed changes
Comment threadlib/flagsmith/engine/evaluation/mappers/identity.rb Outdated
khvn26
khvn26 requested changes Nov 10, 2025
View reviewed changes

@khvn26khvn26 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on the whole. Just two comments.

Comment threadlib/flagsmith/engine/evaluation/mappers/environment.rb Outdated
Comment threadlib/flagsmith/engine/evaluation/mappers/environment.rb Outdated
gagantrivedi
gagantrivedi requested changes Nov 11, 2025
View reviewed changes
Comment threadlib/flagsmith/engine/mappers/environment.rb Outdated
Comment threadlib/flagsmith/engine/mappers/environment.rb Outdated
gagantrivedi
gagantrivedi previously approved these changes Nov 11, 2025
View reviewed changes
@matthewelwell

matthewelwell commented Nov 11, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

This should be feat!, right? Or, at least one of the 3 PRs here should be!

khvn26
khvn26 previously approved these changes Nov 11, 2025
View reviewed changes
@Zaimwa9@gagantrivedi@khvn26
feat: get evaluation get result (#88)
f1026a2
* feat: added-engine-function-signatures
* feat: moved-engine-to-core
* feat: implemented-process-segment-overrides
* feat: implemented-evalute-segments-partially
* feat: implemented-should-apply-override
* feat: implemented-get-identity-segments
* feat: implemented-new-in-and-fixed-remaining-tests
* feat: run-lint
* feat: misc
* feat: json-path-lib-implementation
* remove dup
* feat: made-legacy-functions-public
* feat: updated-tests-to-match-engine-in-operator-accepting-numbers
* feat: engine-agnostic-to-empty-identity-in-segment-evaluation
* feat: renamed-to-is-higher-priority
* feat: renamed-get-identity-segments-func
* feat: reverted-to-is-primitive
* feat: use-weakest-priority-constant
* feat: upgraded-engine-test-data-and-fixed-mv-evaluation-bug
* feat: removed-targeting-reason-func
* feat: linter-rubocop-autocorrect
* feat: linter
* feat: linter
* feat: moved-mappers-to-engine-namespace
* feat: enrich-context-with-identity-key
* feat: run-ci-on-all-branches
* feat: removed-comments
* feat!: sdk consumes context engine (#89)
* fix: sdk-uses-new-engine-methods
* feat: introduced-jsonpath-library
* feat: fixed-conflict
* Update lib/flagsmith/engine/segments/models.rb
Co-authored-by: Kim Gustyr <kim.gustyr@flagsmith.com>
* Update lib/flagsmith/engine/segments/models.rb
* feat: removed-normalize
* feat: linter
* feat: replaced-flagsmith-id-with-id
* feat: removed-comments
---------
Co-authored-by: Kim Gustyr <kim.gustyr@flagsmith.com>
---------
Co-authored-by: Gagan Trivedi <gagandeeptrivedi47@gmail.com>
Co-authored-by: Kim Gustyr <kim.gustyr@flagsmith.com>
@Zaimwa9
Zaimwa9 dismissed stale reviews from khvn26 and gagantrivedi via f1026a2November 12, 2025 09:19
@Zaimwa9Zaimwa9 changed the title feat: evaluation context mappersfeat!: evaluation context mappersNov 12, 2025
@Zaimwa9
Zaimwa9 merged commit 287ce6d into mainNov 12, 2025
5 checks passed
@flagsmithdevflagsmithdev mentioned this pull request Oct 21, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gagantrivedigagantrivedigagantrivedi approved these changes
@khvn26khvn26khvn26 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Zaimwa9@matthewelwell@khvn26@gagantrivedi