Skip to content

feat: get evaluation get result - #88

Merged
Zaimwa9 merged 34 commits into
feat/evaluation-context-mappersfrom
feat/evaluation-get-result
Nov 12, 2025
Merged

feat: get evaluation get result#88
Zaimwa9 merged 34 commits into
feat/evaluation-context-mappersfrom
feat/evaluation-get-result

Conversation

@Zaimwa9

@Zaimwa9Zaimwa9 commented Oct 27, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@Zaimwa9
Zaimwa9 requested a review from a team as a code ownerOctober 27, 2025 14:36
@Zaimwa9
Zaimwa9 requested review from khvn26 and removed request for a teamOctober 27, 2025 14:36
@Zaimwa9
Zaimwa9 changed the base branch from main to feat/evaluation-context-mappersOctober 27, 2025 14:36
@Zaimwa9
Zaimwa9 marked this pull request as draft October 27, 2025 14:36
Zaimwa9
Zaimwa9 commented Oct 28, 2025
View reviewed changes
Comment threadlib/flagsmith/engine/segments/models.rb Outdated
Comment on lines +84 to +91
'Integer' => ->(v) {
i = v.to_i;
i.to_s == v.to_s ? i : v
},
'Float' => ->(v) {
f = v.to_f;
f.to_s == v.to_s ? f : v
}

@Zaimwa9Zaimwa9Oct 28, 2025

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This implementation is problematic and was fixed in incoming PR.
This would end up coerciting 123abc to 123abc 🔴

Zaimwa9
Zaimwa9 commented Oct 28, 2025
View reviewed changes
Comment threadlib/flagsmith/engine/segments/evaluator.rb Outdated
@Zaimwa9
Zaimwa9 marked this pull request as ready for review October 29, 2025 09:41
@Zaimwa9Zaimwa9 changed the title feat: get evaluation get result [draft]feat: get evaluation get resultOct 29, 2025
khvn26
khvn26 requested changes Oct 30, 2025
View reviewed changes

@khvn26khvn26 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving some comments as a first pass.

I'd really like to see which engine tests fail for this PR — if it's something to better pursue locally rather than in CI, let me know, @Zaimwa9.

Comment threadlib/flagsmith/engine/evaluation/core.rb Outdated
Comment threadlib/flagsmith/engine/segments/evaluator.rb Outdated
Comment threadlib/flagsmith/engine/evaluation/core.rb Outdated
Comment threadlib/flagsmith/engine/evaluation/core.rb Outdated
Comment threadlib/flagsmith/engine/evaluation/core.rb Outdated
Comment threadlib/flagsmith/engine/evaluation/core.rb Outdated
Comment threadlib/flagsmith/engine/evaluation/core.rb Outdated
khvn26
khvn26 reviewed Nov 3, 2025
View reviewed changes
Comment threadlib/flagsmith/engine/segments/evaluator.rb Outdated
khvn26
khvn26 reviewed Nov 3, 2025
View reviewed changes
Comment threadlib/flagsmith/engine/segments/evaluator.rb Outdated
@khvn26khvn26 mentioned this pull request Nov 3, 2025
Merged
gagantrivedi
gagantrivedi approved these changes Nov 11, 2025
View reviewed changes
Comment threadlib/flagsmith/engine/evaluation/core.rb Outdated
Comment threadlib/flagsmith/engine/evaluation/core.rb
@Zaimwa9
Zaimwa9 requested a review from khvn26November 11, 2025 14:00
@Zaimwa9@khvn26
feat!: sdk consumes context engine (#89)
fc1369a
* fix: sdk-uses-new-engine-methods
* feat: introduced-jsonpath-library
* feat: fixed-conflict
* Update lib/flagsmith/engine/segments/models.rb
Co-authored-by: Kim Gustyr <kim.gustyr@flagsmith.com>
* Update lib/flagsmith/engine/segments/models.rb
* feat: removed-normalize
* feat: linter
* feat: replaced-flagsmith-id-with-id
* feat: removed-comments
---------
Co-authored-by: Kim Gustyr <kim.gustyr@flagsmith.com>
@Zaimwa9
Zaimwa9 merged commit f1026a2 into feat/evaluation-context-mappersNov 12, 2025
4 checks passed
Zaimwa9 added a commit that referenced this pull request Nov 12, 2025
@Zaimwa9@khvn26@gagantrivedi
feat!: evaluation context mappers (#87)
287ce6d
* fix: main-mappers-and-tests
* fix: added-metadata
* fix: renaming
* fix: comments
* fix: remoevd-redundant-test
* feat: reviewed-engine-test-todos
* Update lib/flagsmith/engine/evaluation/mappers.rb
Co-authored-by: Kim Gustyr <kim.gustyr@flagsmith.com>
* feat: use-overrides-key-hash
* feat: removed-identifiers-join
* feat: flagsmith-id-in-snake-case
* feat: run-lint
* feat: renamed-module-evaluation
* feat: fixed-priority-0-being-skipped
* feat: reverted-to-hash
* feat: linter
* feat: split-functions-and-module-for-linting
* feat: get-rid-of-extra-map-nested-rule-function
* feat: renaming-identity-methods
* feat: fixed-forgotten-func-renaming
* Update lib/flagsmith/engine/evaluation/mappers/environment.rb
Co-authored-by: Kim Gustyr <kim.gustyr@flagsmith.com>
* feat: added-name-env-model-and-fixture
* feat: moved-mappers-to-engine-namespace
* feat: removed-feature-key
* feat: linter
* feat: get evaluation get result (#88)
* feat: added-engine-function-signatures
* feat: moved-engine-to-core
* feat: implemented-process-segment-overrides
* feat: implemented-evalute-segments-partially
* feat: implemented-should-apply-override
* feat: implemented-get-identity-segments
* feat: implemented-new-in-and-fixed-remaining-tests
* feat: run-lint
* feat: misc
* feat: json-path-lib-implementation
* remove dup
* feat: made-legacy-functions-public
* feat: updated-tests-to-match-engine-in-operator-accepting-numbers
* feat: engine-agnostic-to-empty-identity-in-segment-evaluation
* feat: renamed-to-is-higher-priority
* feat: renamed-get-identity-segments-func
* feat: reverted-to-is-primitive
* feat: use-weakest-priority-constant
* feat: upgraded-engine-test-data-and-fixed-mv-evaluation-bug
* feat: removed-targeting-reason-func
* feat: linter-rubocop-autocorrect
* feat: linter
* feat: linter
* feat: moved-mappers-to-engine-namespace
* feat: enrich-context-with-identity-key
* feat: run-ci-on-all-branches
* feat: removed-comments
* feat!: sdk consumes context engine (#89)
* fix: sdk-uses-new-engine-methods
* feat: introduced-jsonpath-library
* feat: fixed-conflict
* Update lib/flagsmith/engine/segments/models.rb
Co-authored-by: Kim Gustyr <kim.gustyr@flagsmith.com>
* Update lib/flagsmith/engine/segments/models.rb
* feat: removed-normalize
* feat: linter
* feat: replaced-flagsmith-id-with-id
* feat: removed-comments
---------
Co-authored-by: Kim Gustyr <kim.gustyr@flagsmith.com>
---------
Co-authored-by: Gagan Trivedi <gagandeeptrivedi47@gmail.com>
Co-authored-by: Kim Gustyr <kim.gustyr@flagsmith.com>
---------
Co-authored-by: Kim Gustyr <kim.gustyr@flagsmith.com>
Co-authored-by: Gagan Trivedi <gagandeeptrivedi47@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@khvn26khvn26khvn26 approved these changes
@gagantrivedigagantrivedigagantrivedi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Zaimwa9@khvn26@gagantrivedi