feat!: sdk consumes context engine by Zaimwa9 · Pull Request #89 · Flagsmith/flagsmith-ruby-client

Zaimwa9 · 2025-10-28T15:03:21Z

Contributes to #81

In this 3/3 PR related to evaluation context in local evaluation mode

In this PR:

SDK layer uses the new engine in the client local evaluation
Implementation of a proper JSONPath library
Clean-up deprecated code and methods

khvn26

Left three comments.

Co-authored-by: Kim Gustyr <kim.gustyr@flagsmith.com>

…gsmith-ruby-client into feat/sdk-consumes-context-engine

khvn26 · 2025-11-11T11:53:42Z

I'm still reluctant to approve this without seeing tests pass in CI. Can we modify branches in .github/workflows/pull_request.yaml so tests are ran against all PRs, not just the ones to main/release* branches?

…gsmith-ruby-client into feat/sdk-consumes-context-engine

Zaimwa9 · 2025-11-11T13:57:13Z

@khvn26 done for both

khvn26 · 2025-11-11T14:03:48Z

@Zaimwa9 Can you resolve the merge conflict?

khvn26

Happy to approve 👍

* feat: added-engine-function-signatures * feat: moved-engine-to-core * feat: implemented-process-segment-overrides * feat: implemented-evalute-segments-partially * feat: implemented-should-apply-override * feat: implemented-get-identity-segments * feat: implemented-new-in-and-fixed-remaining-tests * feat: run-lint * feat: misc * feat: json-path-lib-implementation * remove dup * feat: made-legacy-functions-public * feat: updated-tests-to-match-engine-in-operator-accepting-numbers * feat: engine-agnostic-to-empty-identity-in-segment-evaluation * feat: renamed-to-is-higher-priority * feat: renamed-get-identity-segments-func * feat: reverted-to-is-primitive * feat: use-weakest-priority-constant * feat: upgraded-engine-test-data-and-fixed-mv-evaluation-bug * feat: removed-targeting-reason-func * feat: linter-rubocop-autocorrect * feat: linter * feat: linter * feat: moved-mappers-to-engine-namespace * feat: enrich-context-with-identity-key * feat: run-ci-on-all-branches * feat: removed-comments * feat!: sdk consumes context engine (#89) * fix: sdk-uses-new-engine-methods * feat: introduced-jsonpath-library * feat: fixed-conflict * Update lib/flagsmith/engine/segments/models.rb Co-authored-by: Kim Gustyr <kim.gustyr@flagsmith.com> * Update lib/flagsmith/engine/segments/models.rb * feat: removed-normalize * feat: linter * feat: replaced-flagsmith-id-with-id * feat: removed-comments --------- Co-authored-by: Kim Gustyr <kim.gustyr@flagsmith.com> --------- Co-authored-by: Gagan Trivedi <gagandeeptrivedi47@gmail.com> Co-authored-by: Kim Gustyr <kim.gustyr@flagsmith.com>

* fix: main-mappers-and-tests * fix: added-metadata * fix: renaming * fix: comments * fix: remoevd-redundant-test * feat: reviewed-engine-test-todos * Update lib/flagsmith/engine/evaluation/mappers.rb Co-authored-by: Kim Gustyr <kim.gustyr@flagsmith.com> * feat: use-overrides-key-hash * feat: removed-identifiers-join * feat: flagsmith-id-in-snake-case * feat: run-lint * feat: renamed-module-evaluation * feat: fixed-priority-0-being-skipped * feat: reverted-to-hash * feat: linter * feat: split-functions-and-module-for-linting * feat: get-rid-of-extra-map-nested-rule-function * feat: renaming-identity-methods * feat: fixed-forgotten-func-renaming * Update lib/flagsmith/engine/evaluation/mappers/environment.rb Co-authored-by: Kim Gustyr <kim.gustyr@flagsmith.com> * feat: added-name-env-model-and-fixture * feat: moved-mappers-to-engine-namespace * feat: removed-feature-key * feat: linter * feat: get evaluation get result (#88) * feat: added-engine-function-signatures * feat: moved-engine-to-core * feat: implemented-process-segment-overrides * feat: implemented-evalute-segments-partially * feat: implemented-should-apply-override * feat: implemented-get-identity-segments * feat: implemented-new-in-and-fixed-remaining-tests * feat: run-lint * feat: misc * feat: json-path-lib-implementation * remove dup * feat: made-legacy-functions-public * feat: updated-tests-to-match-engine-in-operator-accepting-numbers * feat: engine-agnostic-to-empty-identity-in-segment-evaluation * feat: renamed-to-is-higher-priority * feat: renamed-get-identity-segments-func * feat: reverted-to-is-primitive * feat: use-weakest-priority-constant * feat: upgraded-engine-test-data-and-fixed-mv-evaluation-bug * feat: removed-targeting-reason-func * feat: linter-rubocop-autocorrect * feat: linter * feat: linter * feat: moved-mappers-to-engine-namespace * feat: enrich-context-with-identity-key * feat: run-ci-on-all-branches * feat: removed-comments * feat!: sdk consumes context engine (#89) * fix: sdk-uses-new-engine-methods * feat: introduced-jsonpath-library * feat: fixed-conflict * Update lib/flagsmith/engine/segments/models.rb Co-authored-by: Kim Gustyr <kim.gustyr@flagsmith.com> * Update lib/flagsmith/engine/segments/models.rb * feat: removed-normalize * feat: linter * feat: replaced-flagsmith-id-with-id * feat: removed-comments --------- Co-authored-by: Kim Gustyr <kim.gustyr@flagsmith.com> --------- Co-authored-by: Gagan Trivedi <gagandeeptrivedi47@gmail.com> Co-authored-by: Kim Gustyr <kim.gustyr@flagsmith.com> --------- Co-authored-by: Kim Gustyr <kim.gustyr@flagsmith.com> Co-authored-by: Gagan Trivedi <gagandeeptrivedi47@gmail.com>

Zaimwa9 added 2 commits October 27, 2025 17:42

fix: sdk-uses-new-engine-methods
0f5250a

feat: introduced-jsonpath-library
60dfef6

Zaimwa9 requested a review from a team as a code owner October 28, 2025 15:03

Zaimwa9 requested review from khvn26 and removed request for a teamOctober 28, 2025 15:03

Zaimwa9 marked this pull request as draft October 28, 2025 15:03

Zaimwa9 added 2 commits October 28, 2025 17:55

feat: rebased
c645e79

feat: fixed-conflict
646a8fc

Zaimwa9 changed the title ~~feat: sdk consumes context engine [draft]~~feat: sdk consumes context engineOct 29, 2025

Zaimwa9 marked this pull request as ready for review October 29, 2025 09:41

khvn26 mentioned this pull request Oct 30, 2025
feat: get evaluation get result #88
Merged

khvn26 requested changes Nov 3, 2025
View reviewed changes

Comment threadlib/flagsmith/engine/segments/models.rb Outdated
Comment threadlib/flagsmith/sdk/models/flags.rb Outdated
Comment threadlib/flagsmith/engine/core.rb Outdated

khvn26 reviewed Nov 3, 2025
View reviewed changes

Comment threadlib/flagsmith/engine/segments/evaluator.rb

Update lib/flagsmith/engine/segments/models.rb
1f5a0a8
Co-authored-by: Kim Gustyr <kim.gustyr@flagsmith.com>

Zaimwa9 commented Nov 10, 2025
View reviewed changes

Comment threadlib/flagsmith/engine/segments/models.rb Outdated

Zaimwa9and others added 10 commits November 10, 2025 17:08

Update lib/flagsmith/engine/segments/models.rb
2dc4816

feat: moved-evaluation-engine-to-be-engine-entrypoint
5e20fa1

feat: pulled
4bf73bb

feat: rebased
d834910

feat: rebased
aafd27d

Merge branch 'feat/evaluation-get-result' of github.com:Flagsmith/fla…
9ddffec
…gsmith-ruby-client into feat/sdk-consumes-context-engine

feat: removed-normalize
9755939

feat: fixed-rebase-from-get-context-key
a5ef567

feat: linter
1bdaad6

feat: replaced-flagsmith-id-with-id
99f379c

khvn26 changed the title ~~feat: sdk consumes context engine~~feat!: sdk consumes context engineNov 11, 2025

Zaimwa9 requested a review from gagantrivedi November 11, 2025 12:25

Zaimwa9 marked this pull request as draft November 11, 2025 13:55

Zaimwa9 marked this pull request as ready for review November 11, 2025 13:55

Merge branch 'feat/evaluation-get-result' of github.com:Flagsmith/fla…
b073edd
…gsmith-ruby-client into feat/sdk-consumes-context-engine

Zaimwa9 requested a review from khvn26 November 11, 2025 13:57

feat: removed-comments
cefe981

feat: rebased
bde89c2

khvn26 approved these changes Nov 11, 2025
View reviewed changes

gagantrivedi approved these changes Nov 12, 2025
View reviewed changes

Zaimwa9 merged commit fc1369a into feat/evaluation-get-resultNov 12, 2025
4 checks passed

matthewelwell assigned Zaimwa9 Nov 12, 2025

Navigation Menu

Uh oh!

feat!: sdk consumes context engine - #89

feat!: sdk consumes context engine#89
Zaimwa9 merged 18 commits into
feat/evaluation-get-resultfrom
feat/sdk-consumes-context-engine

Zaimwa9 commented Oct 28, 2025•
edited
Loading

Uh oh!

khvn26 left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

khvn26 commented Nov 11, 2025

Uh oh!

Zaimwa9 commented Nov 11, 2025

Uh oh!

khvn26 commented Nov 11, 2025

Uh oh!

khvn26 left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

Zaimwa9 commented Oct 28, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

khvn26 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

khvn26 commented Nov 11, 2025

Uh oh!

Zaimwa9 commented Nov 11, 2025

Uh oh!

khvn26 commented Nov 11, 2025

Uh oh!

khvn26 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Zaimwa9 commented Oct 28, 2025•
edited
Loading