feat: import rules from LD flags by Dogacel · Pull Request #3233 · Flagsmith/flagsmith

Dogacel · 2024-01-03T17:48:31Z

Thanks for submitting a PR! Please check the boxes below:

I have run pre-commit to check linting
I have added information to docs/ if required so people know about the feature!
I have filled in the "Changes" section below?
I have filled in the "How did you test this code" section below?
I have used a Conventional Commit title for this Pull Request

Changes

Support importing segments from launch darkly
Support importing targeting rules for segments from launch darkly
Support importing targeting rules for feature flags from launch darkly

How did you test this code?

There are mock responses from launch darkly for importing segments and flag rules.

vercel · 2024-01-03T17:48:36Z

@Dogacel is attempting to deploy a commit to the Flagsmith Team on Vercel.

A member of the Team first needs to authorize it.

vercel · 2024-01-03T17:48:38Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 5, 2024 4:54pm

codecov-commenter · 2024-01-03T17:51:24Z

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (0ef4764) 95.95% compared to head (4b29514) 95.91%.
Report is 53 commits behind head on main.

Files	Patch %	Lines
api/integrations/launch_darkly/services.py	92.54%	12 Missing ⚠️
api/integrations/launch_darkly/client.py	50.00%	9 Missing ⚠️
api/integrations/launch_darkly/models.py	25.00%	3 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #3233 +/- ##
==========================================
- Coverage 95.95% 95.91% -0.05% 
==========================================
Files 1067 1077 +10 Lines 32704 33271 +567 ==========================================
+ Hits 31381 31911 +530 - Misses 1323 1360 +37

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-01-03T17:52:06Z

Uffizzi Preview deployment-45529 was deleted.

Dogacel · 2024-02-07T22:41:46Z

I am hoping the failing E2E will be handled by #3399

matthewelwell · 2024-02-09T15:33:26Z

Thanks again for this @Dogacel !

try importing rules from LD flags
29c2b86

github-actionsBot added the api Issue related to the REST API label Jan 3, 2024

vercelBotdeployed to Preview – docs January 3, 2024 17:49 View deployment

dabeeeenster changed the title ~~try importing rules from LD flags~~feat: try importing rules from LD flagsJan 3, 2024

khvn26 reviewed Jan 3, 2024
View reviewed changes

Comment threadapi/integrations/launch_darkly/services.py Outdated

khvn26 reviewed Jan 3, 2024
View reviewed changes

Comment threadapi/integrations/launch_darkly/services.py Outdated

khvn26 reviewed Jan 3, 2024
View reviewed changes

Comment threadapi/integrations/launch_darkly/services.py Outdated

Doğaç Eldenk added 2 commits January 3, 2024 13:47

try negating conditions + update objects
feb37ae

fix feature state
83ef5a2

vercelBotdeployed to Preview – docs January 3, 2024 19:53 View deployment

Dogacel commented Jan 4, 2024
View reviewed changes

Comment threadapi/integrations/launch_darkly/services.py Outdated

add segment endpoints and refine calls for rule imports
86f33a2

vercelBotdeployed to Preview – docs January 4, 2024 05:20 View deployment

add segment import code baseline
7a3fe59

vercelBotdeployed to Preview – docs January 4, 2024 14:46 View deployment

Dogacel commented Jan 4, 2024
View reviewed changes

Comment threadapi/integrations/launch_darkly/client.py Outdated

Dogacel commented Jan 4, 2024
View reviewed changes

Comment threadapi/integrations/launch_darkly/services.py Outdated

Dogacel commented Jan 4, 2024
View reviewed changes

Comment threadapi/integrations/launch_darkly/services.py

Dogacel commented Jan 4, 2024
View reviewed changes

Comment threadapi/integrations/launch_darkly/services.py Outdated

Dogacel commented Jan 4, 2024
View reviewed changes

Comment threadapi/integrations/launch_darkly/services.py Outdated

Dogacel commented Jan 4, 2024
View reviewed changes

Comment threadapi/ld-openapi-filter.yaml

more segment stuff and fixes
2a04d88

vercelBotdeployed to Preview – docs January 4, 2024 23:24 View deployment

Dogacel commented Jan 5, 2024
View reviewed changes

Comment threadapi/integrations/launch_darkly/services.py

Merge branch 'main' into import-ld-rules
10a1f4e

Dogacel commented Jan 8, 2024
View reviewed changes

Comment threadapi/integrations/launch_darkly/services.py

Dogacel marked this pull request as ready for review January 16, 2024 20:40

Dogacel requested review from dabeeeenster, khvn26 and matthewelwell January 16, 2024 20:40

final touches
9282ff6

github-actionsBot added the front-end Issue related to the React Front End Dashboard label Jan 22, 2024

vercelBotdeployed to Preview – docs January 22, 2024 21:43 View deployment

Merge branch 'main' into import-ld-rules
439f8fd

github-actionsBot removed the front-end Issue related to the React Front End Dashboard label Jan 22, 2024

vercelBotdeployed to Preview – docs January 22, 2024 21:55 View deployment

fix test failure
6abe8c3

vercelBotdeployed to Preview – docs January 24, 2024 15:31 View deployment

matthewelwell removed their request for review January 30, 2024 10:12

khvn26 requested changes Jan 30, 2024
View reviewed changes

comment resolutions
0e3d60a

vercelBotdeployed to Preview – docs January 31, 2024 20:33 View deployment

Dogacel mentioned this pull request Feb 5, 2024
Factor out _import_targets and _import_rules calls so they're invoked directly from process_import_request rather than as a side effect. #3383
Open

comment resolutions and todos
4b29514

vercelBotdeployed to Preview – docs February 5, 2024 16:54 View deployment

Dogacel requested review from khvn26 and matthewelwell February 5, 2024 16:54

khvn26 approved these changes Feb 8, 2024
View reviewed changes

matthewelwell added this pull request to the merge queue Feb 9, 2024

Merged via the queue into Flagsmith:main with commit 42634ecFeb 9, 2024

dabeeeenster mentioned this pull request Feb 8, 2024
chore(main): release 2.100.0 #3388
Merged

matthewelwell changed the title ~~feat: try importing rules from LD flags~~feat: import rules from LD flagsFeb 20, 2024

dabeeeenster mentioned this pull request Apr 18, 2024
chore(main): release 2.109.0 #3798
Closed

Uh oh!

Conversation

Dogacel commented Jan 3, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

How did you test this code?

Uh oh!

vercelBot commented Jan 3, 2024

Uh oh!

vercelBot commented Jan 3, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-commenter commented Jan 3, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actionsBot commented Jan 3, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Dogacel commented Feb 7, 2024

Uh oh!

matthewelwell commented Feb 9, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Dogacel commented Jan 3, 2024•
edited
Loading

vercelBot commented Jan 3, 2024•
edited
Loading

codecov-commenter commented Jan 3, 2024•
edited
Loading

github-actionsBot commented Jan 3, 2024•
edited
Loading