Skip to content

test: Solve flag and segments flaky tests - #3399

Closed
novakzaballa wants to merge 1 commit into
mainfrom
test/solve-flag-and-segment-flaky-tests
Closed

test: Solve flag and segments flaky tests#3399
novakzaballa wants to merge 1 commit into
mainfrom
test/solve-flag-and-segment-flaky-tests

Conversation

@novakzaballa

@novakzaballanovakzaballa commented Feb 7, 2024

Copy link
Copy Markdown
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Please describe.

How did you test this code?

Please describe.

@vercel

vercelBot commented Feb 7, 2024

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewCommentsUpdated (UTC)
docs✅ Ready (Inspect)Visit Preview💬 Add feedbackFeb 7, 2024 9:59pm
flagsmith-frontend-preview✅ Ready (Inspect)Visit Preview💬 Add feedbackFeb 7, 2024 9:59pm
flagsmith-frontend-staging✅ Ready (Inspect)Visit Preview💬 Add feedbackFeb 7, 2024 9:59pm

@github-actions

github-actionsBot commented Feb 7, 2024

Copy link
Copy Markdown
Contributor

Uffizzi Ephemeral Environment deployment-46136

☁️ https://app.uffizzi.com/github.com/Flagsmith/flagsmith/pull/3399

📄 View Application Logs etc.

What is Uffizzi? Learn more!

@DogacelDogacel mentioned this pull request Feb 7, 2024
5 tasks
@novakzaballanovakzaballa changed the title test: Solve flag and segments flaky tests WIPtest: Solve flag and segments flaky testsMar 25, 2024
@kyle-ssg

Copy link
Copy Markdown
Member

image

Does this suggest the flakiness has not been solved?

description = 'description',
) => {
await gotoFeatures()
await t.eval(() => {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, what's the theory behind this solving issues with e2e ?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That function will scroll down the screen. One issue is that I was trying to click on a component that wasn't visible.

@novakzaballa

Copy link
Copy Markdown
ContributorAuthor

image

Does this suggest the flakiness has not been solved?

@kyle-ssg This is another flaky issue. The problem here is that, for some reason, the ID 'email' was not found.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

front-endIssue related to the React Front End Dashboard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@novakzaballa@kyle-ssg