Skip to content

test: remove unnecessary fixture dependency - #5723

Merged
matthewelwell merged 3 commits into
mainfrom
test/remove-unnecessary-fixture-dependency
Jul 8, 2025
Merged

test: remove unnecessary fixture dependency#5723
matthewelwell merged 3 commits into
mainfrom
test/remove-unnecessary-fixture-dependency

Conversation

@matthewelwell

Copy link
Copy Markdown
Contributor

Changes

Removes the unnecessary dependency on the environment fixture in the feature fixture.

There were a few issues that arose from this that needed fixing - some were legitimate bugs that were picked up by this change, but others were just poorly written tests. Note that in resolving some of the resulting issues in the github integration logic, I also resolved a few typing issues that I noticed.

How did you test this code?

Ran the test suite.

@matthewelwell
matthewelwell requested a review from a team as a code ownerJuly 8, 2025 11:22
@matthewelwell
matthewelwell requested review from gagantrivedi and removed request for a teamJuly 8, 2025 11:22
@vercel

vercelBot commented Jul 8, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
NameStatusPreviewCommentsUpdated (UTC)
docs⬜️ Ignored (Inspect)Visit PreviewJul 8, 2025 0:08am
flagsmith-frontend-preview⬜️ Ignored (Inspect)Visit PreviewJul 8, 2025 0:08am
flagsmith-frontend-staging⬜️ Ignored (Inspect)Jul 8, 2025 0:08am

@github-actionsgithub-actionsBot added api Issue related to the REST API testing labels Jul 8, 2025
@github-actions

github-actionsBot commented Jul 8, 2025

Copy link
Copy Markdown
Contributor

Docker builds report

ImageBuild StatusSecurity report
ghcr.io/flagsmith/flagsmith-e2e:pr-5723Finished ✅Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-5723Finished ✅Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-5723Finished ✅Results
ghcr.io/flagsmith/flagsmith-api:pr-5723Finished ✅Results
ghcr.io/flagsmith/flagsmith:pr-5723Finished ✅Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5723Finished ✅Results

@codecov

codecovBot commented Jul 8, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.77%. Comparing base (a6a5b06) to head (9698e88).
Report is 3 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #5723 +/- ##
=======================================
Coverage 97.77% 97.77% =======================================
Files 1255 1255 Lines 44317 44317 =======================================
Hits 43331 43331 Misses 986 986 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@matthewelwell
matthewelwell requested review from a team and khvn26 and removed request for a team and gagantrivediJuly 8, 2025 11:50
Comment threadapi/tests/unit/environments/test_unit_environments_models.py
Comment threadapi/tests/unit/environments/test_unit_environments_models.py Outdated
Comment threadapi/integrations/github/tasks.py

@khvn26khvn26 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes LGTM, with one extremely minor comment.

@matthewelwell
matthewelwell merged commit 046b1b5 into mainJul 8, 2025
29 checks passed
@matthewelwell
matthewelwell deleted the test/remove-unnecessary-fixture-dependency branch July 8, 2025 12:21
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

apiIssue related to the REST APItesting

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@matthewelwell@khvn26