Skip to content

feat: enable feature versioning for new environments - #5108

Merged
matthewelwell merged 24 commits into
mainfrom
feat/enable-feature-versioning-by-default-for-new-environments
Jul 8, 2025
Merged

feat: enable feature versioning for new environments#5108
matthewelwell merged 24 commits into
mainfrom
feat/enable-feature-versioning-by-default-for-new-environments

Conversation

@matthewelwell

@matthewelwellmatthewelwell commented Feb 14, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Changes

Enable feature versioning for environments in newly created projects (based on a flag).

How did you test this code?

Added unit tests.

@vercel

vercelBot commented Feb 14, 2025•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
NameStatusPreviewCommentsUpdated (UTC)
docs⬜️ Ignored (Inspect)Visit PreviewJul 8, 2025 11:32am
flagsmith-frontend-preview⬜️ Ignored (Inspect)Visit PreviewJul 8, 2025 11:32am
flagsmith-frontend-staging⬜️ Ignored (Inspect)Visit PreviewJul 8, 2025 11:32am

@github-actionsgithub-actionsBot added api Issue related to the REST API feature New feature or request labels Feb 14, 2025
@github-actions

github-actionsBot commented Feb 14, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Uffizzi Ephemeral Environment deployment-60945

☁️ https://app.uffizzi.com/github.com/Flagsmith/flagsmith/pull/5108

📄 View Application Logs etc.

What is Uffizzi? Learn more!

@github-actionsgithub-actionsBot added feature New feature or request and removed feature New feature or request labels Feb 17, 2025
@codecov

codecovBot commented Feb 17, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.77%. Comparing base (a6a5b06) to head (5ae9249).
Report is 1 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #5108 +/- ##
=======================================
Coverage 97.77% 97.77% =======================================
Files 1255 1255 Lines 44317 44349 +32 =======================================
+ Hits 43331 43363 +32 
Misses 986 986

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actionsgithub-actionsBot added feature New feature or request and removed feature New feature or request labels Feb 17, 2025
@github-actionsgithub-actionsBot added feature New feature or request and removed feature New feature or request labels Jun 23, 2025
@matthewelwellmatthewelwell mentioned this pull request Jul 8, 2025
Open
khvn26
khvn26 reviewed Jul 8, 2025
View reviewed changes
Comment threadapi/tests/unit/environments/conftest.py Outdated
khvn26
khvn26 reviewed Jul 8, 2025
View reviewed changes
Comment threadapi/environments/models.py Outdated
@github-actionsgithub-actionsBot added feature New feature or request and removed feature New feature or request labels Jul 8, 2025
@matthewelwell
matthewelwellforce-pushed the feat/enable-feature-versioning-by-default-for-new-environments branch from 668c9bc to 5ae9249CompareJuly 8, 2025 11:32
@github-actionsgithub-actionsBot added feature New feature or request and removed feature New feature or request labels Jul 8, 2025
@matthewelwell

matthewelwell commented Jul 8, 2025

Copy link
Copy Markdown
ContributorAuthor

Ok, I think this PR is ready for review now @khvn26 .

I've made a few simplifications and I think it's a lot clearer now what the purpose of the PR is. I've removed some of the code which was resolving unrelated bad test code to another PR, and created a separate issue in the flagsmith-python-client repository to handle improving our testing capabilities.

@matthewelwell
matthewelwell marked this pull request as ready for review July 8, 2025 11:34
@matthewelwell
matthewelwell requested a review from a team as a code ownerJuly 8, 2025 11:34
@matthewelwell
matthewelwell requested review from emyller and removed request for a teamJuly 8, 2025 11:34
@github-actionsgithub-actionsBot added feature New feature or request and removed feature New feature or request labels Jul 8, 2025
@github-actions

github-actionsBot commented Jul 8, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Docker builds report

ImageBuild StatusSecurity report
ghcr.io/flagsmith/flagsmith-e2e:pr-5108Finished ✅Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-5108Finished ✅Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-5108Finished ✅Results ✅
ghcr.io/flagsmith/flagsmith-api:pr-5108Finished ✅Results ✅
ghcr.io/flagsmith/flagsmith:pr-5108Finished ✅Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5108Finished ✅Results ✅

khvn26
khvn26 approved these changes Jul 8, 2025
View reviewed changes

@khvn26khvn26 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👌

@matthewelwell
matthewelwell merged commit e9c16e1 into mainJul 8, 2025
56 of 57 checks passed
@matthewelwell
matthewelwell deleted the feat/enable-feature-versioning-by-default-for-new-environments branch July 8, 2025 12:08
@flagsmithdevflagsmithdev mentioned this pull request Jul 8, 2025
Merged
@khvn26khvn26 mentioned this pull request Aug 14, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@khvn26khvn26khvn26 approved these changes
@emylleremyllerAwaiting requested review from emylleremyller is a code owner automatically assigned from Flagsmith/flagsmith-back-end

Assignees

@matthewelwellmatthewelwell

Labels

apiIssue related to the REST APIfeatureNew feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@matthewelwell@khvn26@emyller