Fixing russian - #17
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi folks! 👋
I got an issue over on remarkjs/remark-validate-links#26 that Cyrillic wasn’t working like on GitHub.
After testing (see https://github.com/Flet/github-slugger/blob/checking-russian/russian.md, which should not be included when merging this PR), the issue is correct that GitHub now lowercases not just ASCII alphabetical letters, but Cyrillic as well.
This PR just adds a normal
string.toLowerCase()ifmaintainCaseis not given. It broke two tests, but I checked, and GitHub now uses lowercased values for them as well.