add slug with occurrences - #20
Merged
Merged
Conversation
wooorm
approved these changes
Dec 3, 2018
UziTech
commented
Dec 3, 2018
ContributorAuthor
right now I have it recursively check each slug with its occurrence to prevent collisions but I'm not sure if that is the best option. When a slug with an occurrence exists should it just add another occurrence or should it increment the occurrence. varGithubSlugger=require('github-slugger')varslugger=newGithubSlugger()slugger.slug('foo-1')// returns 'foo-1'slugger.slug('foo')// returns 'foo'slugger.slug('foo')// returns 'foo-1-1'// should it return 'foo-2'? |
wooorm
commented
Dec 3, 2018
Collaborator
UziTech
commented
Dec 3, 2018
ContributorAuthor
it looks like github sets the second foo to foo-2 |
UziTech
commented
Dec 3, 2018
ContributorAuthor
I changed it so it matches github varGithubSlugger=require('github-slugger')varslugger=newGithubSlugger()slugger.slug('foo-1')// returns 'foo-1'slugger.slug('foo')// returns 'foo'slugger.slug('foo')// returns 'foo-2' |
wooorm
approved these changes
Dec 3, 2018
4 tasks
styfle
approved these changes
Dec 21, 2018
6 tasks
5 tasks
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add slug with occurrences to the occurrences array to prevent collisions with text ending in a number
Fixes#19