Uh oh!
There was an error while loading. Please reload this page.
Refactor blockm* to use virtualfile_from_data and improve i/o - #1280
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
weiji14
commented
May 21, 2021
The docstring for |
maxrjones
commented
May 22, 2021
Since geopandas is now supported and included in {table-like} filler text, do I also need to add tests for geopandas input? |
seisman
commented
May 23, 2021
I think it's unnecessary. The geopandas support is independent with any specific modules and we already have it tested in the |
weiji14
left a comment
There was a problem hiding this comment.
Thanks Meghan for the work, I think we can close #1099 with this PR too no?
Since geopandas is now supported and included in {table-like} filler text, do I also need to add tests for geopandas input?
I think it's unnecessary. The geopandas support is independent with any specific modules and we already have it tested in the
test_geopandas.pyfile.
Agree that we don't need a geopandas input test here.
However, this got me to think about how the PyGMT I/O should work if a geopandas.GeoDataFrame is used as an input to blockm*. Should we yield a pandas.DataFrame output, or would users prefer a geopandas.GeoDataFrame to be returned here? Something to think about in a separate issue.
maxrjones
commented
May 24, 2021
Yes, it is now linked.
Some users would probably like the option. This could be a good SciPy sprint issue. |
seisman
commented
May 24, 2021
What's still missing is |
Ah ok, I've unlinked #1099 from being closed. We'll handle the x/y/z inputs for |
…cMappingTools#1280) - Enables blockm* to work with table-like inputs besides pandas.DataFrame - Makes outfile parameter optional - Loads output data as a pandas.DataFrame when outfile is unset - Updates unit tests accordingly
Description of proposed changes
This PR makes the changes corresponding to #1189 for blockmean and blockmedian.
Related to #949. Addresses #1099
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version