Uh oh!
There was an error while loading. Please reload this page.
WIP: Wrap xyz2grd - #1286
Conversation
willschlitzer
commented
May 23, 2021
I wasn't sure about the etiquette/procedures for taking on another author's pull request (in this case #636), so I opened this PR to wrap |
weiji14
commented
May 23, 2021
@willschlitzer, I would suggest continuing work on that #636 PR instead of starting a new one here. People (especially newcomers) put a lot of work into making a Pull Request and it is best to give them credit for their original work. There could also be reviews in the orginal PR that we want to keep (though not much in this case). As a maintainer, you should be able to commit directly to that branch, and I would start with a branch update from master (though maybe ping the original author first to check). C.f. #525 where I continued work on someone's old PR after asking for permission. |
This pull request wraps the gmt module
xyz2grd.Fixes #
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version