Skip to content

Wrap xyz2grd - #636

Merged
willschlitzer merged 48 commits into
GenericMappingTools:mainfrom
carocamargo:newfeature_xyz2grd
Aug 9, 2021
Merged

Wrap xyz2grd#636
willschlitzer merged 48 commits into
GenericMappingTools:mainfrom
carocamargo:newfeature_xyz2grd

Conversation

@carocamargo

@carocamargocarocamargo commented Sep 29, 2020•
edited by willschlitzer
Loading

Copy link
Copy Markdown
Contributor

This PR wraps the function, xyz2grd and some of its parameters.

Closes#635

carocamargoand others added 18 commits September 17, 2020 21:36
@carocamargo
added gridfilter function
884bde7
@carocamargo
added to call gridfilter from grdops.py
c2a7d3e
@carocamargo
added grdfilter caller
2cb715d
@carocamargo
corrected indentation in grdfilter docstring, and made each function …
6139c17
…with each owns decorators
@carocamargo
added usage example to grdfilter
d2e0aee
@carocamargo@weiji14
Update pygmt/gridops.py
db2cdc7
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
@carocamargo@weiji14
Update pygmt/gridops.py
8b84039
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
@carocamargo
added more optional aliases
a8dd55c
@carocamargo
Merge remote-tracking branch 'upstream/master' into newfeature
452d4f7
@carocamargo
Merge branch 'newfeature' ofhttps://github.com/carocamargo/pygmtint…
269ce62
…o newfeature
@carocamargo
added more optional aliases
9f47f01
@carocamargo
Update gridops.py
874bca4
removed header from local conflict
@carocamargo@seisman
Update pygmt/gridops.py
0373c32
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
@carocamargo@seisman
Update pygmt/gridops.py
fd64a4e
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
@carocamargo@seisman
Update pygmt/gridops.py
df53508
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
@carocamargo
formated code with black
6fae103
@carocamargo
added xyz2grd function to gridding.py
e653fa5
@carocamargo
modified __init__.py to import xyz2grd from gridding.py
3cfff68
@seismanseisman added the feature Brand new feature label Sep 29, 2020
@weiji14weiji14 mentioned this pull request Oct 24, 2020
Merged
5 tasks
@weiji14

weiji14 commented Oct 24, 2020

Copy link
Copy Markdown
Member

Sorry for the force-pushes, had to resolve a tricky merge conflict. If you run git switch newfeature_xyz2grd locally, and then git pull, this should bring in the resolved changes. It's getting late for me now, but I'll try and take a closer look at this next week.

@seismanseisman changed the title Newfeature xyz2grd wrapperWrap xyz2grdNov 4, 2020
@carocamargo

carocamargo commented Nov 27, 2020

Copy link
Copy Markdown
ContributorAuthor

I'm sorry I disappeared, I kind that forgot about this :X .. Do I still need to push the changes, or not anymore?

@willschlitzer

willschlitzer commented Aug 5, 2021

Copy link
Copy Markdown
Contributor

I removed some of the optional parameters to simplify this PR. I figure it's easier to get it merged and then add additional parameters in separate pull requests.

@maxrjones

maxrjones commented Aug 5, 2021

Copy link
Copy Markdown
Member

I removed some of the optional parameters to simplify this PR. I figure it's easier to get it merged and then add additional parameters in separate pull requests.

Thanks for working on this! Sorry for the slowness in reviewing your PRs, they have been lower on my to-do list since we are at a feature pause until v0.4.1. I will take a look after the release.

@willschlitzer

willschlitzer commented Aug 5, 2021

Copy link
Copy Markdown
Contributor

Thanks for working on this! Sorry for the slowness in reviewing your PRs, they have been lower on my to-do list since we are at a feature pause until v0.4.1. I will take a look after the release.

No worries, I expected a v0.4.1, but looking forward to getting them wrapped up!

@willschlitzer
willschlitzer marked this pull request as ready for review August 7, 2021 06:48
weiji14
weiji14 approved these changes Aug 8, 2021
View reviewed changes

@weiji14weiji14 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some formatting stuff, otherwise good for final review!

Comment threadpygmt/src/xyz2grd.py Outdated
Comment threadpygmt/src/xyz2grd.py Outdated
Comment threadpygmt/src/xyz2grd.py Outdated
Comment threadpygmt/src/xyz2grd.py
@weiji14weiji14 added the final review call This PR requires final review and approval from a second reviewer label Aug 8, 2021
@willschlitzer@weiji14
Apply suggestions from code review
cae8e04
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
seisman
seisman approved these changes Aug 8, 2021
View reviewed changes

@seismanseisman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

weiji14
weiji14 reviewed Aug 8, 2021
View reviewed changes
Comment threadpygmt/src/xyz2grd.py Outdated
@willschlitzer
willschlitzer merged commit 097c807 into GenericMappingTools:mainAug 9, 2021
@willschlitzerwillschlitzer removed the final review call This PR requires final review and approval from a second reviewer label Aug 9, 2021
@willschlitzerwillschlitzer mentioned this pull request Aug 9, 2021
Closed
This was referenced Oct 4, 2021
Merged
Merged
@weiji14weiji14 mentioned this pull request Mar 12, 2022
Merged
6 tasks
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
@carocamargo@seisman
@weiji14@willschlitzerMeghan JonesJosh Sixsmith
Wrap xyz2grd (GenericMappingTools#636)
3c9f03b
*Wrap the GMT module xyz2grd
*Add tests for xyz2grd
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Wei Ji <weiji.leong@vuw.ac.nz>
Co-authored-by: Will Schlitzer <schlitzer90@gmail.com>
Co-authored-by: Meghan Jones <meghanj@alum.mit.edu>
@seismanseisman mentioned this pull request Apr 11, 2026
Closed
3 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@weiji14weiji14weiji14 approved these changes
@willschlitzerwillschlitzerwillschlitzer left review comments
@seismanseismanseisman approved these changes

Assignees

@willschlitzerwillschlitzer

Labels

featureBrand new feature

Projects

None yet

Milestone

0.5.0

Development

Successfully merging this pull request may close these issues.

xyz2grd wrapper

5 participants

@carocamargo@weiji14@seisman@willschlitzer@maxrjones