Skip to content

Add download_test_data to download data files used in tests - #1310

Merged
seisman merged 11 commits into
masterfrom
download-test-data
Jun 2, 2021
Merged

Add download_test_data to download data files used in tests#1310
seisman merged 11 commits into
masterfrom
download-test-data

Conversation

@seisman

@seismanseisman commented May 29, 2021

Copy link
Copy Markdown
Member

Description of proposed changes

Fixes#1111.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

weiji14
weiji14 reviewed Jun 1, 2021
View reviewed changes
Comment threadpygmt/helpers/testing.py Outdated
@weiji14weiji14 mentioned this pull request Jun 1, 2021
Merged
5 tasks
weiji14
weiji14 reviewed Jun 1, 2021
View reviewed changes
Comment threadpygmt/helpers/testing.py Outdated
Comment threadpygmt/helpers/testing.py Outdated
@seisman@weiji14
Update pygmt/helpers/testing.py
4ac6769
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
weiji14
weiji14 reviewed Jun 2, 2021
View reviewed changes
Comment threadpygmt/helpers/testing.py Outdated
Comment threadpygmt/helpers/testing.py Outdated
Comment threadpygmt/helpers/testing.py Outdated
@seisman@weiji14
Apply suggestions from code review
828b299
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
weiji14
weiji14 reviewed Jun 2, 2021
View reviewed changes

@weiji14weiji14 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll tag on the final-review-call label. Would appreciate it if @meghanrjones can give this a review before merging to see if the download_test_data() function does resolve the issue opened in #1111.

Comment threadpygmt/helpers/testing.py
@weiji14weiji14 added the final review call This PR requires final review and approval from a second reviewer label Jun 2, 2021
@seismanseisman added this to the 0.4.0 milestone Jun 2, 2021
@seismanseisman added the maintenance Boring but important stuff for the core devs label Jun 2, 2021
@seisman
seismanforce-pushed the download-test-data branch from 4ea5727 to c99bd96CompareJune 2, 2021 03:54
@seisman
seismanforce-pushed the download-test-data branch from c99bd96 to 270e3eaCompareJune 2, 2021 04:05
@seisman
seisman marked this pull request as ready for review June 2, 2021 04:30
core-man
core-man reviewed Jun 2, 2021
View reviewed changes
Comment threadpygmt/helpers/testing.py Outdated
maxrjones
maxrjones approved these changes Jun 2, 2021
View reviewed changes
Comment threadpygmt/helpers/testing.py Outdated
Comment threadpygmt/helpers/testing.py Outdated
Comment threadpygmt/helpers/testing.py Outdated
@seismanMeghan Jones@core-man
Apply suggestions from reviewers
a3fc38e
Co-authored-by: Meghan Jones <meghanrjones@users.noreply.github.com>
Co-authored-by: Yao Jiayuan <coreman.seism@gmail.com>
@seismanseisman removed the final review call This PR requires final review and approval from a second reviewer label Jun 2, 2021
@seisman
seisman merged commit 1ab551d into masterJun 2, 2021
@seisman
seisman deleted the download-test-data branch June 2, 2021 17:53
@weiji14weiji14 mentioned this pull request Mar 18, 2022
Merged
6 tasks
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
@seisman@weiji14
Meghan Jones@core-manJosh Sixsmith
Add download_test_data to download data files used in tests (GenericM…
1909675
…appingTools#1310)
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
Co-authored-by: Meghan Jones <meghanrjones@users.noreply.github.com>
Co-authored-by: Yao Jiayuan <coreman.seism@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@weiji14weiji14weiji14 approved these changes
@core-mancore-mancore-man left review comments
@maxrjonesmaxrjonesmaxrjones approved these changes

Assignees

No one assigned

Labels

maintenanceBoring but important stuff for the core devs

Projects

None yet

Milestone

0.4.0

Development

Successfully merging this pull request may close these issues.

Providing a datasets.download_test_data() method

4 participants

@seisman@maxrjones@weiji14@core-man