Skip to content

Use the build package to build sdist and wheel distributions - #1823

Merged
seisman merged 2 commits into
mainfrom
deprecate-setup-build
Mar 19, 2022
Merged

Use the build package to build sdist and wheel distributions#1823
seisman merged 2 commits into
mainfrom
deprecate-setup-build

Conversation

@seisman

Copy link
Copy Markdown
Member

Description of proposed changes

Fixes#1797.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seismanseisman added the maintenance Boring but important stuff for the core devs label Mar 16, 2022
@seismanseisman added this to the 0.6.1 milestone Mar 16, 2022
@seisman
seismanforce-pushed the deprecate-setup-build branch from 8b609ba to 732cce1CompareMarch 16, 2022 05:09
mamba install gmt=6.3.0 \
numpy pandas xarray netCDF4 packaging matplotlib
mamba install gmt=6.3.0 numpy pandas xarray netCDF4 packaging \
build matplotlib

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit unrelated, but why is matplotlib needed in the cache_data workflow? Isn't this GitHub Actions workflow just used to download files?

I see that the matplotlib dependency was added at 270e3ea in #1310, but can't see exactly why this is needed.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

frommatplotlib.testing.compareimportcompare_images

matplotlib is imported in testing.py so when we run the download_test_data function, matplotlib must be imported.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok. Seems like that import line could just be put inside the check_figures_equal function, but let's just keep things the way it is right now.


- name: Install dependencies
run: python -m pip install setuptools wheel
run: python -m pip install build

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, and just noting that we should double check that the wheel and source files on TestPyPI look ok once this PR is merged.

@weiji14weiji14 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me on Linux. Might pay to know if this works locally on macOS and Windows as well, but the CI does look ok.

@weiji14weiji14 added the final review call This PR requires final review and approval from a second reviewer label Mar 18, 2022
@seisman
seisman merged commit 813142b into mainMar 19, 2022
@seisman
seisman deleted the deprecate-setup-build branch March 19, 2022 04:12
@seismanseisman removed the final review call This PR requires final review and approval from a second reviewer label Mar 19, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenanceBoring but important stuff for the core devs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

python setup.py gives deprecation warnings

2 participants

@seisman@weiji14