Uh oh!
There was an error while loading. Please reload this page.
Use the build package to build sdist and wheel distributions - #1823
Conversation
8b609ba to
732cce1Compareba25ca1 to
079753fCompare| mamba install gmt=6.3.0 \ | ||
| numpy pandas xarray netCDF4 packaging matplotlib | ||
| mamba install gmt=6.3.0 numpy pandas xarray netCDF4 packaging \ | ||
| build matplotlib |
There was a problem hiding this comment.
pygmt/pygmt/helpers/testing.py
Line 8 in 8fe2d33
matplotlib is imported in testing.py so when we run the download_test_data function, matplotlib must be imported.
There was a problem hiding this comment.
Ah ok. Seems like that import line could just be put inside the check_figures_equal function, but let's just keep things the way it is right now.
| - name: Install dependencies | ||
| run: python -m pip install setuptools wheel | ||
| run: python -m pip install build |
There was a problem hiding this comment.
Oh, and just noting that we should double check that the wheel and source files on TestPyPI look ok once this PR is merged.
weiji14
left a comment
There was a problem hiding this comment.
Ok for me on Linux. Might pay to know if this works locally on macOS and Windows as well, but the CI does look ok.
Description of proposed changes
Fixes#1797.
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version