Skip to content

Wrap grdproject - #1377

Merged
seisman merged 19 commits into
mainfrom
wrap-grdproject
Aug 28, 2021
Merged

Wrap grdproject#1377
seisman merged 19 commits into
mainfrom
wrap-grdproject

Conversation

@willschlitzer

@willschlitzerwillschlitzer commented Jul 7, 2021•
edited by weiji14
Loading

Copy link
Copy Markdown
Contributor

This pull requests wraps the GMT module grdproject.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@willschlitzerwillschlitzer added the feature Brand new feature label Jul 7, 2021
@willschlitzerwillschlitzer added this to the 0.5.0 milestone Jul 7, 2021
@willschlitzerwillschlitzer self-assigned this Jul 7, 2021
@willschlitzerwillschlitzer changed the title WIP: Wrap grdprojectWrap grdprojectJul 11, 2021
@willschlitzer
willschlitzer marked this pull request as ready for review July 22, 2021 19:54
@maxrjones

maxrjones commented Aug 9, 2021

Copy link
Copy Markdown
Member

Thanks for wrapping this module!

What do you think about adding a value-based check to the tests (using npt.assert_allclose(), similar to grdgradient tests), in addition to the current metadata-based checks?

seisman
seisman reviewed Aug 10, 2021
View reviewed changes
Comment threadpygmt/tests/test_grdproject.py
@willschlitzer

willschlitzer commented Aug 10, 2021

Copy link
Copy Markdown
ContributorAuthor

Thanks for wrapping this module!

What do you think about adding a value-based check to the tests (using npt.assert_allclose(), similar to grdgradient tests), in addition to the current metadata-based checks?

I'll add them in!

weiji14
weiji14 reviewed Aug 11, 2021
View reviewed changes
Comment threadpygmt/tests/test_grdproject.py Outdated
Comment threadpygmt/src/grdproject.py Outdated
Comment threadpygmt/src/grdproject.py
Comment threadpygmt/src/grdproject.py
@willschlitzer@weiji14
Apply suggestions from code review
f00135e
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
seisman
seisman approved these changes Aug 26, 2021
View reviewed changes

@seismanseisman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@seismanseisman added the final review call This PR requires final review and approval from a second reviewer label Aug 26, 2021
@seisman

seisman commented Aug 26, 2021

Copy link
Copy Markdown
Member

@willschlitzer Please resolve the conflicts.

maxrjones
maxrjones approved these changes Aug 26, 2021
View reviewed changes

@maxrjonesmaxrjones left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@seisman

seisman commented Aug 27, 2021

Copy link
Copy Markdown
Member

/format

seisman
seisman reviewed Aug 27, 2021
View reviewed changes
Comment threadpygmt/tests/test_grdproject.py Outdated
@seisman

seisman commented Aug 27, 2021

Copy link
Copy Markdown
Member

@willschlitzer Please see my above suggestion. Otherwise, I think this PR is ready to merge.

@willschlitzer@seisman
Update pygmt/tests/test_grdproject.py
90476cd
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
@seismanseisman removed the final review call This PR requires final review and approval from a second reviewer label Aug 28, 2021
@seisman
seisman merged commit fb90068 into mainAug 28, 2021
@seisman
seisman deleted the wrap-grdproject branch August 28, 2021 16:59
@weiji14weiji14 mentioned this pull request Sep 2, 2021
Merged
5 tasks
@willschlitzerwillschlitzer mentioned this pull request Sep 16, 2021
Merged
5 tasks
@weiji14weiji14 mentioned this pull request Jan 31, 2022
Merged
6 tasks
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
@willschlitzer@weiji14
@seismanJosh Sixsmith
Wrap grdproject (GenericMappingTools#1377)
9db2838
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seismanseismanseisman approved these changes
@weiji14weiji14weiji14 left review comments
@maxrjonesmaxrjonesmaxrjones approved these changes

Assignees

@willschlitzerwillschlitzer

Labels

featureBrand new feature

Projects

None yet

Milestone

0.5.0

Development

Successfully merging this pull request may close these issues.

5 participants

@willschlitzer@maxrjones@seisman@weiji14@actions-bot