Skip to content

Wrap sphinterpolate - #1418

Merged
weiji14 merged 24 commits into
mainfrom
wrap-sphinterpolate
Sep 27, 2021
Merged

Wrap sphinterpolate#1418
weiji14 merged 24 commits into
mainfrom
wrap-sphinterpolate

Conversation

@willschlitzer

@willschlitzerwillschlitzer commented Aug 7, 2021•
edited by weiji14
Loading

Copy link
Copy Markdown
Contributor

This pull request wraps the module sphinterpolate.

Fixes #

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@willschlitzerwillschlitzer added the feature Brand new feature label Aug 7, 2021
@willschlitzerwillschlitzer added this to the 0.5.0 milestone Aug 7, 2021
@willschlitzerwillschlitzer self-assigned this Aug 7, 2021
@willschlitzerwillschlitzer mentioned this pull request Aug 9, 2021
Merged
5 tasks
@willschlitzerwillschlitzer changed the title WIP: Wrap sphinterpolateWrap sphinterpolateAug 11, 2021
@willschlitzer
willschlitzer marked this pull request as ready for review August 11, 2021 08:55
weiji14
weiji14 reviewed Sep 2, 2021
View reviewed changes
Comment threadpygmt/src/sphinterpolate.py Outdated
Comment threadpygmt/src/sphinterpolate.py Outdated
Comment threadpygmt/src/sphinterpolate.py
Comment threadpygmt/tests/test_sphinterpolate.py Outdated
@willschlitzer@weiji14
Apply suggestions from code review
947d8ad
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
@willschlitzer

willschlitzer commented Sep 7, 2021

Copy link
Copy Markdown
ContributorAuthor

I would prefer to have #1420 merged before this PR so that these tests can import the Mars data in a Python format.

@willschlitzer@weiji14
Apply suggestions from code review
25cad5e
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
weiji14
weiji14 reviewed Sep 20, 2021
View reviewed changes
Comment threadpygmt/src/sphinterpolate.py Outdated
Comment threadpygmt/__init__.py Outdated
Comment threadpygmt/src/__init__.py Outdated
Comment threadpygmt/src/sphinterpolate.py Outdated
Comment threadpygmt/src/sphinterpolate.py Outdated
Comment threadpygmt/src/sphinterpolate.py Outdated
Comment threadpygmt/tests/test_sphinterpolate.py Outdated
Comment threadpygmt/tests/test_sphinterpolate.py Outdated
@willschlitzer@weiji14
Apply suggestions from code review
fb43d6f
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
weiji14
weiji14 approved these changes Sep 25, 2021
View reviewed changes

@weiji14weiji14 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright to me 🚀

@weiji14weiji14 added the final review call This PR requires final review and approval from a second reviewer label Sep 25, 2021
weiji14
weiji14 reviewed Sep 25, 2021
View reviewed changes
Comment threadpygmt/src/sphinterpolate.py
@willschlitzer@weiji14
Apply suggestions from code review
10083cf
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
seisman
seisman reviewed Sep 26, 2021
View reviewed changes
Comment threadpygmt/src/sphinterpolate.py Outdated
seisman
seisman approved these changes Sep 26, 2021
View reviewed changes

@seismanseisman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me except a suggestion on the docstrings.

@willschlitzer@seisman
Apply suggestions from code review
c0cfcb6
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
seisman
seisman reviewed Sep 26, 2021
View reviewed changes
Comment threadpygmt/src/sphinterpolate.py
V="verbose",
)
@kwargs_to_strings(I="sequence", R="sequence")
def sphinterpolate(data, **kwargs):

@seismanseismanSep 26, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to support x, y, z input following #1479, but can be done in a separate PR.

weiji14
weiji14 reviewed Sep 26, 2021
View reviewed changes
Comment threadpygmt/src/sphinterpolate.py Outdated
@willschlitzer@weiji14
Apply suggestions from code review
e7887c3
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
@weiji14
weiji14 merged commit 0926206 into mainSep 27, 2021
@weiji14
weiji14 deleted the wrap-sphinterpolate branch September 27, 2021 21:47
@weiji14weiji14 removed the final review call This PR requires final review and approval from a second reviewer label Sep 27, 2021
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
@willschlitzer@weiji14
@seismanJosh Sixsmith
Wrap sphinterpolate (GenericMappingTools#1418)
d3353df
Wrapping the sphinterpolate function which creates spherical
grid files in tension of data. Official GMT documentation is at https://docs.generic-mapping-tools.org/6.2/sphdistance.html.
Aliased outgrid (G), spacing (I), region (R), verbose (V).
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
@seismanseisman mentioned this pull request Apr 11, 2026
Closed
6 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seismanseismanseisman approved these changes
@weiji14weiji14weiji14 approved these changes

Assignees

@willschlitzerwillschlitzer

Labels

featureBrand new feature

Projects

None yet

Milestone

0.5.0

Development

Successfully merging this pull request may close these issues.

3 participants

@willschlitzer@seisman@weiji14