Skip to content

Add Mars dataset - #1420

Merged
weiji14 merged 12 commits into
mainfrom
add-mars-dataset
Sep 20, 2021
Merged

Add Mars dataset#1420
weiji14 merged 12 commits into
mainfrom
add-mars-dataset

Conversation

@willschlitzer

@willschlitzerwillschlitzer commented Aug 8, 2021

Copy link
Copy Markdown
Contributor

This pull request adds a function to the dataset samples for the mars370d.txt file used in the sphinterpolate example.

Fixes #

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@willschlitzerwillschlitzer added the feature Brand new feature label Aug 8, 2021
@willschlitzerwillschlitzer added this to the 0.5.0 milestone Aug 8, 2021
@willschlitzerwillschlitzer self-assigned this Aug 8, 2021
@willschlitzerwillschlitzer mentioned this pull request Sep 7, 2021
5 tasks
@willschlitzer
willschlitzer marked this pull request as ready for review September 9, 2021 12:00

@weiji14weiji14 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor docstring suggested change to apply (you'll need to resolve the merge conflict with load_hotspot first though).

Catching up on the discussion at #1436 (comment), if we're moving to follow the seaborn.load_dataset model, then this PR would need substantial changes. Do you want to do the refactoring here or separately?

Comment threadpygmt/datasets/samples.py Outdated
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
@willschlitzer

Copy link
Copy Markdown
ContributorAuthor

Just one minor docstring suggested change to apply (you'll need to resolve the merge conflict with load_hotspot first though).

Catching up on the discussion at #1436 (comment), if we're moving to follow the seaborn.load_dataset model, then this PR would need substantial changes. Do you want to do the refactoring here or separately?

My thought is to handle it with a separate PR. While I don't want to duplicate efforts, this seems like a pretty substantial change for follow seaborn.load_dataset, and I think it's easier for this to be merged first before it is refactored to follow a new way of doing things.

@weiji14weiji14 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor docstring suggested change to apply (you'll need to resolve the merge conflict with load_hotspot first though).
Catching up on the discussion at #1436 (comment), if we're moving to follow the seaborn.load_dataset model, then this PR would need substantial changes. Do you want to do the refactoring here or separately?

My thought is to handle it with a separate PR. While I don't want to duplicate efforts, this seems like a pretty substantial change for follow seaborn.load_dataset, and I think it's easier for this to be merged first before it is refactored to follow a new way of doing things.

Ok to approve then, and refactor later.

@weiji14weiji14 added the final review call This PR requires final review and approval from a second reviewer label Sep 19, 2021
@weiji14

Copy link
Copy Markdown
Member

/format

Comment threadpygmt/datasets/samples.py Outdated

@seismanseisman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@weiji14

weiji14 commented Sep 20, 2021

Copy link
Copy Markdown
Member

@willschlitzer, before you merge this, could you please add an entry under https://github.com/GenericMappingTools/pygmt/blob/main/doc/api/index.rst#datasets? (Also would be nice to sort the entries alphabetically). Thanks!

@weiji14
weiji14 merged commit 8414b7e into mainSep 20, 2021
@weiji14
weiji14 deleted the add-mars-dataset branch September 20, 2021 22:17
@weiji14weiji14 removed the final review call This PR requires final review and approval from a second reviewer label Sep 20, 2021
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
Sample data table for the shape of Mars. This is the
`@mars370d.txt` dataset used in GMT examples, with data
and information from Smith, D. E., and M. T. Zuber (1996).
The shape of Mars and the topographic signature of the
hemispheric dichotomy. Data columns are "longitude",
"latitude", and "radius (meters)."
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

featureBrand new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@willschlitzer@weiji14@seisman@actions-bot