Uh oh!
There was an error while loading. Please reload this page.
Add missing aliases to pygmt.xyz2grd - #1506
Conversation
maxrjones
commented
Sep 17, 2021
Please change: to |
willschlitzer
commented
Sep 19, 2021
changed |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
maxrjones
commented
Sep 23, 2021
I think xyz2grd should go under "operations on tabular data" rather than "operations on grids" in |
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Meghan Jones <meghanj@alum.mit.edu>
willschlitzer
commented
Sep 24, 2021
changed in fda29eb |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Meghan Jones <meghanj@alum.mit.edu>
maxrjones
left a comment
There was a problem hiding this comment.
Looks good! Just three suggestions - two for adding missing lower-case common options and one for referring to an alias rather than short option.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Meghan Jones <meghanj@alum.mit.edu>
willschlitzer
commented
Oct 28, 2021
When I run |
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Meghan Jones <meghanj@alum.mit.edu>
weiji14
left a comment
There was a problem hiding this comment.
One suggestion to add alias for projection -J, but still missing aliases for -D/-S/-Z from https://docs.generic-mapping-tools.org/6.2/xyz2grd. If you're not adding those 3 (which is fine if you're in a rush to get this merged before v0.5.0), then please edit the first post to change "Fixes #1424" to "Addresses #1424".
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
Add missing aliases duplicate (A), projection (J), convention (Z), binary (b), nodata (d), find (e), coltypes (f), header (h), incols (i), registration (r), and wrap (w) to pygmt.xyz2grd. Co-authored-by: Meghan Jones <meghanj@alum.mit.edu> Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
This pull request adds missing aliases for
xyz2grd.Continuation of #635 and #636. Addresses #1424.
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version