Skip to content

Add missing aliases to grd2xyz - #1537

Merged
seisman merged 10 commits into
mainfrom
add-params-grd2xyz
Oct 28, 2021
Merged

Add missing aliases to grd2xyz#1537
seisman merged 10 commits into
mainfrom
add-params-grd2xyz

Conversation

@willschlitzer

Copy link
Copy Markdown
Contributor

This is a follow up to #1284 and wraps additional parameters.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@willschlitzerwillschlitzer added documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog labels Sep 23, 2021
@willschlitzerwillschlitzer added this to the 0.5.0 milestone Sep 23, 2021
@willschlitzerwillschlitzer self-assigned this Sep 23, 2021
@willschlitzer
willschlitzer marked this pull request as ready for review September 25, 2021 07:29
@willschlitzerwillschlitzer changed the title Add optional parameters to grd2xyzAdd missing aliases to grd2xyzOct 5, 2021
Comment threadpygmt/src/grd2xyz.py Outdated
Comment threadpygmt/src/grd2xyz.py Outdated
Comment threadpygmt/src/grd2xyz.py Outdated
R="region",
V="verbose",
W="weight",
Z="binary",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

binary is already used as the name of a common option. Please select a different alias for Z and add b="binary".

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to z_convention and added b

@maxrjonesmaxrjones mentioned this pull request Oct 6, 2021
5 tasks
@willschlitzerwillschlitzer mentioned this pull request Oct 7, 2021
35 tasks
Co-authored-by: Meghan Jones <meghanj@alum.mit.edu>
@weiji14weiji14 mentioned this pull request Oct 21, 2021
5 tasks
@maxrjonesmaxrjones added the final review call This PR requires final review and approval from a second reviewer label Oct 27, 2021

@weiji14weiji14 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few more common aliases to add, otherwise all good!

Comment threadpygmt/src/grd2xyz.py
Comment threadpygmt/src/grd2xyz.py
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
@seisman
seisman merged commit 9e95a4e into mainOct 28, 2021
@seisman
seisman deleted the add-params-grd2xyz branch October 28, 2021 06:50
@willschlitzerwillschlitzer removed the final review call This PR requires final review and approval from a second reviewer label Dec 7, 2021
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
Co-authored-by: Meghan Jones <meghanj@alum.mit.edu>
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentationImprovements or additions to documentationskip-changelogSkip adding Pull Request to changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@willschlitzer@seisman@maxrjones@michaelgrund@weiji14