Skip to content

Move matplotlib import inside the check_figures_equal function - #1877

Merged
seisman merged 3 commits into
mainfrom
optional-matplotlib
Apr 13, 2022
Merged

Move matplotlib import inside the check_figures_equal function#1877
seisman merged 3 commits into
mainfrom
optional-matplotlib

Conversation

@seisman

Copy link
Copy Markdown
Member

Description of proposed changes

Move matplotlib import statement inside the check_figures_equal function, so that the cache_data workflow doesn't need matplotlib installed.

Address #1823 (comment)

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seismanseisman added the maintenance Boring but important stuff for the core devs label Apr 11, 2022
@seismanseisman added this to the 0.6.1 milestone Apr 11, 2022
@seismanseisman added the skip-changelog Skip adding Pull Request to changelog label Apr 11, 2022
Comment thread.github/workflows/cache_data.yaml Outdated
@seisman

Copy link
Copy Markdown
MemberAuthor

Now the cache_data works well without matplotlib (https://github.com/GenericMappingTools/pygmt/runs/5971739015?check_suite_focus=true).

@seismanseisman modified the milestones: 0.6.1, 0.7.0Apr 11, 2022
@seisman
seisman requested a review from weiji14April 11, 2022 15:58
@seismanseisman added final review call This PR requires final review and approval from a second reviewer and removed final review call This PR requires final review and approval from a second reviewer labels Apr 12, 2022
@seisman
seisman merged commit d68b6b5 into mainApr 13, 2022
@seisman
seisman deleted the optional-matplotlib branch April 13, 2022 04:14
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenanceBoring but important stuff for the core devsskip-changelogSkip adding Pull Request to changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@seisman@weiji14