Skip to content

Bump the GMT version in CI to 6.4.0 - #1990

Merged
seisman merged 11 commits into
mainfrom
bump-gmt-6.4.0
Aug 4, 2022
Merged

Bump the GMT version in CI to 6.4.0#1990
seisman merged 11 commits into
mainfrom
bump-gmt-6.4.0

Conversation

@seisman

@seismanseisman commented Jul 5, 2022•
edited
Loading

Copy link
Copy Markdown
Member

Description of proposed changes

Address #1989

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seismanseisman added the maintenance Boring but important stuff for the core devs label Jul 5, 2022
@seismanseisman added this to the 0.8.0 milestone Jul 5, 2022
@seismanseisman mentioned this pull request Jul 5, 2022
Closed
8 tasks
@weiji14weiji14 mentioned this pull request Jul 11, 2022
Merged
6 tasks
@seismanseisman changed the title Bump the minimum required GMT version to 6.4.0Bump the GMT version in CI to 6.4.0Jul 16, 2022
@seisman

seisman commented Jul 16, 2022•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

I've updated this PR based on the comment in #1991 (comment).

Now this PR only bumps the GMT version in CI to 6.4.0. The minimum required GMT version is still 6.3.0.

@seisman
seisman requested a review from a teamJuly 19, 2022 01:00
@seismanseisman added the final review call This PR requires final review and approval from a second reviewer label Aug 2, 2022
@seismanseisman removed the final review call This PR requires final review and approval from a second reviewer label Aug 4, 2022
seisman
seisman commented Aug 4, 2022
View reviewed changes
Comment thread.github/ISSUE_TEMPLATE/bump_gmt_checklist.md Outdated
Comment thread.github/ISSUE_TEMPLATE/bump_gmt_checklist.md
@seisman
seisman merged commit 25e9df4 into mainAug 4, 2022
@seisman
seisman deleted the bump-gmt-6.4.0 branch August 4, 2022 02:21
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
@seismanJosh Sixsmith
Bump the GMT version in CI to 6.4.0 (GenericMappingTools#1990)
386d070
@weiji14weiji14 mentioned this pull request Jan 7, 2024
Merged
7 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maxrjonesmaxrjonesmaxrjones approved these changes

Assignees

No one assigned

Labels

maintenanceBoring but important stuff for the core devs

Projects

None yet

Milestone

0.8.0

Development

Successfully merging this pull request may close these issues.

2 participants

@seisman@maxrjones