Skip to content

Bump the GMT version in CI to 6.4.0#1990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seisman merged 11 commits into from
Aug 4, 2022
Merged

Bump the GMT version in CI to 6.4.0 #1990

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
d707a0d
Bump the minimum required GMT version to 6.4.0
seisman Jul 5, 2022
f8d9c50
Merge branch 'main' into bump-gmt-6.4.0
seisman Jul 16, 2022
f1b8bf7
Change the minimum required GMT version back to 6.3.0
seisman Jul 16, 2022
2cf0faf
Update the checklist for bumping GMT
seisman Jul 16, 2022
253a85f
Merge branch 'main' into bump-gmt-6.4.0
seisman Jul 19, 2022
50fd706
Merge branch 'main' into bump-gmt-6.4.0
seisman Jul 31, 2022
546e201
Bump the GMT version used in building docs to 6.4.0
seisman Jul 31, 2022
a5bb860
Update the checklist
seisman Jul 31, 2022
2dc33ae
Merge branch 'main' into bump-gmt-6.4.0
seisman Aug 2, 2022
562ddb2
Merge branch 'main' into bump-gmt-6.4.0
seisman Aug 3, 2022
d3c20f4
Apply suggestions from code review
seisman Aug 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions .github/ISSUE_TEMPLATE/bump_gmt_checklist.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,16 +14,23 @@ assignees: ''

<!-- Please add specific checklist items for the tests, xfail pytest markers, and deprecated syntax that need to be updated. -->

**To-Do**:
- [ ] Bump the minimum required GMT version (1 PR)
**To-Do for bumping the GMT version in CI**:

- [ ] Bump the GMT version in CI (1 PR)
- [ ] Update `.github/workflows/cache_data.yaml`
- [ ] Update `.github/workflows/ci_docs.yml`
- [ ] Update `.github/workflows/ci_tests.yaml`
- [ ] Update `doc/install.rst`
- [ ] Update `ci/requirements/docs.yml`
- [ ] Update `environment.yml`
- [ ] Fix failing tests (1 or more PRs)
- [ ] Fix [xfail](https://docs.pytest.org/en/stable/skipping.html#xfail-mark-test-functions-as-expected-to-fail) pytest markers on tests that are now xpass

**To-Do for bumping the minimum required GMT version**:

- [ ] Bump the minimum required GMT version (1 PR)
- [ ] Update `doc/install.rst`
- [ ] Update `required_version` in `pygmt/clib/session.py`
- [ ] Update `test_get_default` in `pygmt/tests/test_clib.py`
- [ ] Update compatibility table in `README.rst`
- [ ] Fix failing tests (1 or more PRs)
- [ ] Remove [xfail](https://docs.pytest.org/en/stable/skipping.html#xfail-mark-test-functions-as-expected-to-fail) pytest markers on tests that are now xpass
Comment thread
seisman marked this conversation as resolved.
- [ ] Update deprecated syntax in source code and examples based on the [GMT Changelog](https://docs.generic-mapping-tools.org/latest/changes.html)
2 changes: 1 addition & 1 deletion .github/workflows/cache_data.yaml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -38,7 +38,7 @@ jobs:
# Install GMT and other required dependencies from conda-forge
- name: Install dependencies
run: |
mamba install gmt=6.3.0 numpy pandas xarray netCDF4 packaging \
mamba install gmt=6.4.0 numpy pandas xarray netCDF4 packaging \
build

# Install the package that we want to test
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci_docs.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -70,7 +70,7 @@ jobs:
# Install GMT and other required dependencies from conda-forge
- name: Install dependencies
run: |
mamba install gmt=6.3.0 numpy pandas xarray netCDF4 packaging \
mamba install gmt=6.4.0 numpy pandas xarray netCDF4 packaging \
build ipython make myst-parser geopandas \
sphinx sphinx-copybutton sphinx-design sphinx-gallery sphinx_rtd_theme

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci_tests.yaml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -90,7 +90,7 @@ jobs:
# Install GMT and other required dependencies from conda-forge
- name: Install dependencies
run: |
mamba install gmt=6.3.0 numpy=${{ matrix.numpy-version }} \
mamba install gmt=6.4.0 numpy=${{ matrix.numpy-version }} \
pandas xarray netCDF4 packaging \
${{ matrix.optional-packages }} \
build dvc make pytest>=6.0 \
Expand Down
2 changes: 1 addition & 1 deletion ci/requirements/docs.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,7 +5,7 @@ channels:
dependencies:
# Required dependencies
- pip
- gmt=6.3.0
- gmt=6.4.0
- numpy>=1.20
- pandas
- xarray
Expand Down
2 changes: 1 addition & 1 deletion environment.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,7 +5,7 @@ channels:
dependencies:
# Required dependencies
- pip
- gmt=6.3.0
- gmt=6.4.0
- numpy>=1.20
- pandas
- xarray
Expand Down