Uh oh!
There was an error while loading. Please reload this page.
feat: name the HTTP status when the error body is not JSON - #58
Merged
Conversation
An unparseable error body produced the message "failed to parse error response", which hid the HTTP status. The message now appends the status to that text, so prefix matching and substring matching both keep working. The status code, the raw response body and the parse cause do not change.
mogitaforce-pushed
the
fix/cha-4641-error-status-in-message
branch
from
August 12, 2026 18:01
676013d to
fd5ef00CompareUh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
https://linear.app/stream/issue/CHA-4641/generated-sdks-report-the-http-status-when-the-error-body-is-not-json
Summary
When an error body is not JSON, the SDK reported only the parse failure and hid the HTTP status. A customer saw
failed to parse error responsefor a 503 that the edge proxy returned as plain text, plus a JSON parse stack trace, and could not tell which status they got. The message now appends the status:failed to parse error response: unexpected server response code 503.getStatusCode(),getRawResponseBody()and the\JsonExceptioncause do not change.The old text is still the prefix of the new message, so prefix matching and substring matching on it both keep working. The integration assertion that uses
str_containsstill holds.Verification
make lint(PHPStan): no errors.vendor/bin/phpunit tests/Exceptions/ErrorHandlingTest.php: 16 tests, 47 assertions, pass.make test-unit: 2 errors inClientTest, which needSTREAM_API_SECRET. The base commit gives the same 2 errors.