Skip to content

feat: name the HTTP status when the error body is not JSON#58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mogita merged 1 commit into from
Aug 12, 2026
Merged

feat: name the HTTP status when the error body is not JSON #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Http/GuzzleHttpClient.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -467,7 +467,7 @@ private function buildApiException(

if (!$parsedEnvelope) {
// HTTP layer succeeded, body is unparseable as APIError.
$message = 'failed to parse error response';
$message = sprintf('failed to parse error response: unexpected server response code %d', $statusCode);
}

if ($statusCode === 429) {
Expand Down
2 changes: 1 addition & 1 deletion tests/Exceptions/ErrorHandlingTest.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -106,7 +106,7 @@ public function unparseableErrorResponseFallsBackToSentinelMessage(): void
self::assertSame(500, $e->getStatusCode());
self::assertSame(500, $e->getCode(), 'getCode() returns HTTP status (back-compat)');
self::assertSame(0, $e->getApiErrorCode(), 'APIError.code is 0 on unparseable body');
self::assertSame('failed to parse error response', $e->getMessage());
self::assertSame('failed to parse error response: unexpected server response code 500', $e->getMessage());
self::assertSame('<<<not json>>>', $e->getRawResponseBody());
self::assertNotNull($e->getPrevious(), 'cause chain must point to the JSON parse error');
self::assertInstanceOf(\JsonException::class, $e->getPrevious());
Expand Down
Loading