Uh oh!
There was an error while loading. Please reload this page.
test: read the channel back when asserting partial updates - #83
Merged
Conversation
The channel returned by updateChannelPartial can lag the write it just applied, so testPartialUpdateChannel and testFreezeUnfreezeChannel failed intermittently on the value they had just set. A probe over 8 rounds saw a stale partial-update response 4 times and a stale read-back none. The two tests now assert against a fresh read of the channel.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
testPartialUpdateChannelandtestFreezeUnfreezeChannelfail intermittently in CI. Both asserted on the channel carried in theupdateChannelPartialresponse, and that channel can lag the write it just applied: two updates in quick succession come back with the same body and the sameupdated_at, so the second response is missing the change it made.A probe of 8 set/unset rounds saw a stale partial-update response 4 times and a stale read-back 0 times, so both tests now assert against a fresh read of the channel.
Verify:
./gradlew test --tests 'io.getstream.ChatChannelIntegrationTest' --rerun. The class failed on both runs before this change and passed on three runs after.The API behaviour itself is tracked separately and is unchanged here.