Skip to content

test: read the channel back when asserting partial updates#83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mogita merged 1 commit into from
Aug 17, 2026
Merged

test: read the channel back when asserting partial updates #83

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions src/test/java/io/getstream/ChatChannelIntegrationTest.java
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -170,7 +170,8 @@ void testPartialUpdateChannel() throws Exception {

assertNotNull(setResp.getData(), "PartialUpdate (set) response should not be null");
assertNotNull(setResp.getData().getChannel(), "Channel in response should not be null");
var custom = setResp.getData().getChannel().getCustom();

var custom = readChannel(channelId).getCustom();
assertNotNull(custom, "Custom data should not be null after set");
assertEquals("red", custom.get("color"), "Custom field 'color' should be 'red'");

Expand All@@ -184,12 +185,25 @@ void testPartialUpdateChannel() throws Exception {

assertNotNull(unsetResp.getData(), "PartialUpdate (unset) response should not be null");
assertNotNull(unsetResp.getData().getChannel(), "Channel in response should not be null");
var customAfterUnset = unsetResp.getData().getChannel().getCustom();

var customAfterUnset = readChannel(channelId).getCustom();
assertTrue(
customAfterUnset == null || !customAfterUnset.containsKey("color"),
"Custom field 'color' should be removed after unset");
}

/**
* Reads the channel back from the API. The channel returned by a partial update can lag the write
* it just applied, so state assertions read the channel instead of trusting that response.
*/
private ChannelResponse readChannel(String channelId) throws Exception {
return chat.getOrCreateChannel(
"messaging", channelId, GetOrCreateChannelRequest.builder().build())
.execute()
.getData()
.getChannel();
}

@Test
@Order(9)
void testAddRemoveMembers() throws Exception {
Expand DownExpand Up@@ -793,7 +807,7 @@ void testFreezeUnfreezeChannel() throws Exception {
assertNotNull(freezeResp.getData(), "Freeze response should not be null");
assertNotNull(
freezeResp.getData().getChannel(), "Channel in freeze response should not be null");
Boolean frozenAfterFreeze = freezeResp.getData().getChannel().getFrozen();
Boolean frozenAfterFreeze = readChannel(channelId).getFrozen();
assertNotNull(frozenAfterFreeze, "Frozen field should not be null after freeze");
assertTrue(frozenAfterFreeze, "Channel should be frozen after setting frozen=true");

Expand All@@ -808,7 +822,7 @@ void testFreezeUnfreezeChannel() throws Exception {
assertNotNull(unfreezeResp.getData(), "Unfreeze response should not be null");
assertNotNull(
unfreezeResp.getData().getChannel(), "Channel in unfreeze response should not be null");
Boolean frozenAfterUnfreeze = unfreezeResp.getData().getChannel().getFrozen();
Boolean frozenAfterUnfreeze = readChannel(channelId).getFrozen();
assertNotNull(frozenAfterUnfreeze, "Frozen field should not be null after unfreeze");
assertFalse(frozenAfterUnfreeze, "Channel should be unfrozen after setting frozen=false");
}
Expand Down
Loading