use MaybeUninit::as_ptr instead of transmute - #46
Merged
Conversation
RalfJung
commented
Aug 9, 2020
CollaboratorAuthor
Ah, we have to wait until Miri gets an update to work with the newer rustc that has |
RalfJung
marked this pull request as draft
August 9, 2020 17:06
Gilnaa
commented
Aug 9, 2020
Owner
Cool. Does that mean waiting for the next nightly or the next release? |
RalfJung
commented
Aug 9, 2020
CollaboratorAuthor
It means waiting for rust-lang/rust#75274 to be fixed, which is currently blocked on rust-lang/rust#75339. |
RalfJung
commented
Aug 11, 2020
CollaboratorAuthor
Miri got that update, so CI should pass now. Cycling the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With rust-lang/rust#75250 having landed, we can finally get rid of the
transmutehere.