Uh oh!
There was an error while loading. Please reload this page.
make MaybeUninit::as_(mut_)ptr const - #75250
Merged
Merged
Conversation
rust-highfive
commented
Aug 7, 2020
Contributor
r? @shepmaster (rust_highfive has picked a reviewer for you, use r? to override) |
Closed
3 tasks
RalfJungforce-pushed
the
uninit-const-ptr
branch
2 times, most recently
from
August 7, 2020 10:29
bc4dc26 to
fcf4b35Compareoli-obk
commented
Aug 7, 2020
Contributor
bors
commented
Aug 7, 2020
Collaborator
📌 Commit fcf4b35515343db6361a4ed63ce1d77bf74e038f has been approved by |
oli-obk
commented
Aug 7, 2020
Contributor
@bors rollup |
RalfJung
commented
Aug 7, 2020
MemberAuthor
blessed fmt |
bors
commented
Aug 7, 2020
Collaborator
📌 Commit ec5d78d has been approved by |
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 8, 2020
Rollup of 7 pull requests Successful merges: - rust-lang#75224 (Don't call a function in function-arguments-naked.rs) - rust-lang#75237 (Display elided lifetime for non-reference type in doc) - rust-lang#75250 (make MaybeUninit::as_(mut_)ptr const) - rust-lang#75253 (clean up const-hacks in int endianess conversion functions) - rust-lang#75259 (Add missing backtick) - rust-lang#75267 (Small cleanup) - rust-lang#75270 (fix a couple of clippy findings) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think it was just an oversight that they are not const yet.
I also changed their implementation as the old one created references to uninitialized memory.^^