') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Lint the getting started sample. by tswast · Pull Request #7 · GoogleCloudPlatform/appengine-try-java · GitHub
Skip to content
This repository was archived by the owner on Apr 13, 2022. It is now read-only.

Lint the getting started sample. - #7

Merged
lesv merged 23 commits into
masterfrom
use-java-repo-tools
Apr 12, 2016
Merged

Lint the getting started sample.#7
lesv merged 23 commits into
masterfrom
use-java-repo-tools

Conversation

@tswast

@tswasttswast commented Apr 12, 2016

Copy link
Copy Markdown
Contributor

Uses shared https://github.com/GoogleCloudPlatform/java-repo-tools to
configure checkstyle and test plugins.

CC @ludoch

tswastand others added 22 commits March 1, 2016 20:42
@tswastGerrit Code Review
Initial empty repository
26e3280
@tswast
Initialize the repository.
f8b4964
Adds shared pom.xml and google-checks.xml. I also add a test directory
to check that the pom works / is well-formed.
@tswast
Add Travis configuration.
7d5661d
@tswast
Merge pull request#1from GoogleCloudPlatform/travis
750e456
Add Travis configuration.
@tswast
Remove unnecessary properties.
cf3de1a
@tswast
Merge pull request#2from GoogleCloudPlatform/pom
99e2d6c
Remove unnecessary properties.
@tswast
Ignore generated AutoValue classes from checkstyle.
ac6ce48
@tswast
Ignore JavaDoc rules in test classes.
8d4b9a3
@tswast
Merge pull request#3from GoogleCloudPlatform/suppress
5c9a316
Ignore JavaDoc rules in test classes.
@tswast
Ignore service account file.
344227c
@tswast
Merge pull request#4from GoogleCloudPlatform/java-repo-tools
108bbd2
Ignore service account file.
@tswast
Add license header to POM.
3c48097
@tswast
Merge pull request#6from GoogleCloudPlatform/license
237c693
Remove extra XML stuff from POM.
@tswast
Add instructions for using with subtrees.
7c9d494
Subtrees are the primary way I expect people to use the
`java-repo-tools` repository. Since it's not a super common workflow, I
document the needed steps in the README.
@tswast
Merge pull request#7from GoogleCloudPlatform/readme
bc24c2b
Add instructions for using with subtrees.
@tswast
Remove extra newline in README
c3264a5
@tswast
Remove another extra newline.
fcbbca5
@tswast
Checkstyle fixes.
2e5da26
I modify the checkstyle config to have SAME_PACKAGE imports appear
before third-party imports. I think this better matches the intent of
the import ordering rules in the style guide.
https://google.github.io/styleguide/javaguide.html#s3.3.3-import-ordering-and-spacing
Expecially since it says the `com.google` imports only appear after
static imports if the source file is in the `com.google` package space.
(cherry picked from commit 7ca0e7564d4d1a39714d8c90e71d5e408f30f4da)
@lesv
Merge pull request#8from GoogleCloudPlatform/import-order
79d5d11
Checkstyle: have SAME_PACKAGE imports appear before third-party imports
@tswast
Remove command that was copy-paste error.
638b601
The pulling changes from Java Repository Tools instructions can now be followed verbatim.
@tswast
Update README.md
810d4a7
@tswast
Add much easier steps for pulling in changes
d156201
The instructions here are much easier to follow and avoid unnecessary conflicts: https://help.github.com/articles/about-git-subtree-merges/
@googlebot

googlebot commented Apr 12, 2016

Copy link
Copy Markdown

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@tswast

tswast commented Apr 12, 2016

Copy link
Copy Markdown
ContributorAuthor

@googlebot I'm merging histories with https://github.com/GoogleCloudPlatform/java-repo-tools which is covered under CLA.

See also GoogleCloudPlatform/getting-started-java#80 for a similar change.

@tswast
Lint the getting started sample.
62d200a
Uses shared https://github.com/GoogleCloudPlatform/java-repo-tools to
configure checkstyle and test plugins.
Merge remote-tracking branch 'java-repo-tools/master' into use-java-repo-tools
@tswast
tswastforce-pushed the use-java-repo-tools branch from d074ec0 to 62d200aCompareApril 12, 2016 21:20
@tswasttswast mentioned this pull request Apr 12, 2016
Merged
@lesv

lesv commented Apr 12, 2016

Copy link
Copy Markdown
Contributor

LGTM

@lesv
lesv merged commit 5260ddf into masterApr 12, 2016
@tswast
tswast deleted the use-java-repo-tools branch April 12, 2016 23:08
@waprinwaprin mentioned this pull request Apr 12, 2016
Closed
6 tasks
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@lesvlesv

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tswast@googlebot@lesv