Uh oh!
There was an error while loading. Please reload this page.
Initial vision API addition. - #1803
Conversation
| _topicality = None | ||
| _bounding_poly = None | ||
| _locations = [] | ||
| _properties = [] |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
theacodes
commented
May 17, 2016
I'd prefer constants over strings, even if they semantically mean the same thing: |
| def as_dict(self): | ||
| return { | ||
| "image": self.image, | ||
| "features": self.features |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
dhermes
commented
May 17, 2016
Rather than writing and dumping all this code, please draft a Once we agree on something, try to land them feature by feature so review doesn't become unmanageable. (e.g. you couldn't just sent a tiny PR with the (PS I know I "broke the rules" in #1772 however the entire API is contained in three methods so I did it "on purpose" / was aware it was a bit of a brain dump.) |
tseaver
commented
May 17, 2016
dhermes
commented
May 17, 2016
@tseaver I totally agree and wish I had done that. |
daspecster
commented
May 17, 2016
Ok, I'll make a PR with just a vision-usage.rst and then we can talk about it there. |
tseaver
commented
May 23, 2016
In favor of #1809 ans subsequent. |
Fairly rough and a lot of conversation to be had.
Examples to play with