Initial Vision usage docs for discussion by daspecster · Pull Request #1809 · googleapis/google-cloud-python

daspecster · 2016-05-18T17:46:02Z

Here is a rough outline of the Vision usage RST.

Originally mentioned here.

The usage here essentially implies direct conversion of the responses to objects.
I think we have room here to add helper methods which could add value.

Let's discuss!

Sign in to view

+
+.. doctest::
+
+ >>> images = (('./image.jpg', [vision.FeatureTypes.LABEL_DETECTION,


theacodes · 2016-05-18T17:52:56Z

/cc @jerjou

Sign in to view

+ >>> annotated_images = []
+ >>> for image, feature_types in images:
+ ... annotated_images.append(
+ ... vision_client.annotate(


jgeewax · 2016-05-18T19:44:10Z

Can you take a look at our Vision docs for Ruby that do things slightly differently? https://quartzmo.github.io/gcloud-ruby/#/docs/master/gcloud/vision

daspecster · 2016-05-18T20:00:38Z

@jgeewax I like their examples!

Are you saying to look at their docs as an example for the usage layout or for how their API is defined...or both I suppose?

I can condense this down a bit. I wanted to layout the cases here so we could discuss the API surface.

quartzmo · 2016-05-18T20:01:54Z

@jgeewax @daspecster I'm working on updating our Vision docs demo with googleapis/google-cloud-ruby#696 and another pending PR, just FYI.

daspecster · 2016-05-18T20:02:27Z

One thing that I'm not sure about in gcloud-ruby is that the way they do the multiple images example. I think it actually would cost more since there would be multiple API requests?

However I guess since the charging is based on the feature types that in their example it wouldn't make any difference?

analyses=vision.annotatedo |annotate|
annotate.annotateface_image,faces: 10,labels: 10annotate.annotatelandmark_image,landmarks: 10annotate.annotatetext_image,text: trueend

In that case I guess the only part in question is request overhead. I think the batching discussion will get there though.

quartzmo · 2016-05-18T20:04:20Z

We have changed our API to accept booleans as well as max results, so when updated, most examples will use this new syntax:

annotation=vision.annotateimage,faces: true,labels: true

daspecster · 2016-05-18T20:10:38Z

@quartzmo, I like changing the max_results to true, since with some feature types rarely if ever would more than one result be returned.

I could take that out here and just make the default max_results=1 and then not that in the docs but leave it out of most of the examples.

quartzmo · 2016-05-18T20:15:14Z

@daspecster The batch example you mention above results in a single API request. Nothing happens until the block execution completes.

daspecster · 2016-05-18T22:06:37Z

@quartzmo, I see now. Thanks!

quartzmo · 2016-05-19T22:35:57Z

@daspecster We released our Vision support today in case you want to try it.

daspecster · 2016-05-20T16:54:39Z

@quartzmo thanks! I'll give it a go this weekend.

Sign in to view

+
+- In addition to any authentication configuration, you should also set the
+ :envvar:`GCLOUD_PROJECT` environment variable for the project you'd like
+ to interact with. If you are Google App Engine or Google Compute Engine


dhermes · 2016-05-23T16:21:03Z

General comment: Though there is only one method provided by the backend API, we can and should have many methods in our API, matching the concepts at the level you provide in each docs subsection.

daspecster · 2016-05-27T17:18:31Z

@dhermes @tseaver, the doc was updated with convenience methods like detect_labels() etc.
Not sure why it days they were added 9 days ago though? I pushed it on one of those github outage days.

If you guys want to take a look at it again and let me know what you think that would be awesome!

daspecster · 2016-05-31T16:03:13Z

@dhermes @tseaver, just wanted to try and keep this alive. Let me know if you have any comments! If not then I'll start working on implementing this Thursday(June 2nd).

Thanks!

tseaver · 2016-05-31T20:51:03Z

LGTM to go forward with the surface as described.

daspecster · 2016-05-31T22:35:06Z

Closing since we shouldn't have a usage doc with no surface methods available yet.

Reopen if we want to chat more about any of this!

daspecster · 2016-06-20T19:11:04Z

/cc @jgeewax

* feat: Add trust boundary support for external accounts. * Add trust boundary support to external account authorized users. * Fix lint issues * Implement additional unit tests for external account authorized user. * fix formatting issue * Add a unit test with invalid audiance * add missing unit tests

🤖 I have created a release *beep* *boop* --- ## [2.42.0](googleapis/google-auth-library-python@v2.41.1...v2.42.0) (2025-10-24) ### Features * Add trust boundary support for external accounts. ([#1809](googleapis/google-auth-library-python#1809)) ([36ecb1d](googleapis/google-auth-library-python@36ecb1d)) ### Bug Fixes * Read scopes from ADC json for impersoanted cred ([#1820](googleapis/google-auth-library-python#1820)) ([62c0fc8](googleapis/google-auth-library-python@62c0fc8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* fix: add google-auth as a direct dependency * update constraints * fix(deps): Require `google-api-core>=1.34.1, >=2.11.0` * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Lingqing Gan <lingqing.gan@gmail.com> Co-authored-by: Chalmer Lowe <chalmerlowe@google.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* use mocks.create_bigquery_session * chore: implement compile_readtable

daspecster added do not merge Indicates a pull request not ready for merge, due to either quality or timing. api: vision Issues related to the Cloud Vision API. labels May 18, 2016

daspecster added this to the Vision Alpha milestone May 18, 2016

googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 18, 2016

theacodes reviewed May 18, 2016
View reviewed changes

Comment threaddocs/vision-usage.rst Outdated

.. doctest::

>>> images = (('./image.jpg', [vision.FeatureTypes.LABEL_DETECTION,
This comment was marked as spam.
Sign in to view

jerjou reviewed May 18, 2016
View reviewed changes

tseaver mentioned this pull request May 23, 2016
Initial vision API addition. #1803
Closed
6 tasks

dhermes reviewed May 23, 2016
View reviewed changes

daspecster added 2 commits May 23, 2016 23:52

Initial Vision usage docs for discussion
bf38cf3

Update usage examples to batch.
196e229

daspecster force-pushed the vision-usage branch from f43179d to 196e229Compare May 24, 2016 03:52

daspecster closed this May 31, 2016

dhermes mentioned this pull request Aug 19, 2016
Add Vision API usage documentation. #2148
Merged

daspecster deleted the vision-usage branch January 24, 2017 15:17

parthea pushed a commit that referenced this pull request Apr 1, 2026
chore: implement compile_readtable (#1809)
d7dbbb8
* use mocks.create_bigquery_session * chore: implement compile_readtable


		.. doctest::

		>>> images = (('./image.jpg', [vision.FeatureTypes.LABEL_DETECTION,

Uh oh!

Conversation

daspecster commented May 18, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as spam.

Uh oh!

theacodes commented May 18, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

jgeewax commented May 18, 2016

Uh oh!

daspecster commented May 18, 2016

Uh oh!

quartzmo commented May 18, 2016

Uh oh!

daspecster commented May 18, 2016

Uh oh!

quartzmo commented May 18, 2016

Uh oh!

daspecster commented May 18, 2016

Uh oh!

quartzmo commented May 18, 2016

Uh oh!

daspecster commented May 18, 2016

Uh oh!

quartzmo commented May 19, 2016

Uh oh!

daspecster commented May 20, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

dhermes commented May 23, 2016

Uh oh!

daspecster commented May 27, 2016

Uh oh!

daspecster commented May 31, 2016

Uh oh!

tseaver commented May 31, 2016

Uh oh!

daspecster commented May 31, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

daspecster commented Jun 20, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

daspecster commented May 18, 2016•
edited
Loading

daspecster commented May 31, 2016•
edited
Loading