Skip to content

refactor: use new verify token functionality from google-auth-library - #2986

Merged
chingor13 merged 6 commits into
GoogleCloudPlatform:masterfrom
chingor13:verify-iap-auth-library
Jun 25, 2020
Merged

refactor: use new verify token functionality from google-auth-library#2986
chingor13 merged 6 commits into
GoogleCloudPlatform:masterfrom
chingor13:verify-iap-auth-library

Conversation

@chingor13

@chingor13chingor13 commented May 28, 2020•
edited
Loading

Copy link
Copy Markdown
Member

google-auth-library 0.21.0 is available, so this is ready to go.

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label May 28, 2020
@chingor13
chingor13 requested a review from bshafferMay 28, 2020 22:04
bshaffer
bshaffer reviewed May 29, 2020
View reviewed changes

@bshafferbshaffer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it's a draft but this looks fantastic, nice work.

Comment threadiap/src/main/java/com/example/iap/VerifyIapRequestHeader.java
bshaffer
bshaffer reviewed May 29, 2020
View reviewed changes
Comment threadiap/src/main/java/com/example/iap/VerifyIapRequestHeader.java Outdated
bshaffer
bshaffer reviewed May 29, 2020
View reviewed changes
Comment threadiap/src/main/java/com/example/iap/VerifyIapRequestHeader.java
averikitsch
averikitsch approved these changes Jun 10, 2020
View reviewed changes
Comment threadiap/src/main/java/com/example/iap/VerifyIapRequestHeader.java Outdated
@chingor13
chingor13 marked this pull request as ready for review June 24, 2020 20:53
@chingor13
chingor13 requested a review from a teamJune 24, 2020 20:53
@chingor13chingor13 mentioned this pull request Jun 24, 2020
Merged
9 tasks
@chingor13
chingor13 requested a review from bshafferJune 24, 2020 21:22
@chingor13chingor13 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 24, 2020
@kokoro-teamkokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 24, 2020
bshaffer
bshaffer approved these changes Jun 25, 2020
View reviewed changes

@bshafferbshaffer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor suggestion and totally up to you. Otherwise, this is double-approved. The net removal of 60 lines of code makes me quite happy.

Comment threadiap/src/main/java/com/example/iap/VerifyIapRequestHeader.java
@chingor13
chingor13 merged commit 8fd9669 into GoogleCloudPlatform:masterJun 25, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bshafferbshafferbshaffer approved these changes
@averikitschaverikitschaverikitsch approved these changes

Assignees

@averikitschaverikitsch

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@chingor13@bshaffer@averikitsch@googlebot@kokoro-team