Skip to content

chore(iap): cleanup spotbugs warnings - #3239

Merged
lesv merged 5 commits into
GoogleCloudPlatform:masterfrom
chingor13:cleanup-iap-warnings
Jun 24, 2020
Merged

chore(iap): cleanup spotbugs warnings#3239
lesv merged 5 commits into
GoogleCloudPlatform:masterfrom
chingor13:cleanup-iap-warnings

Conversation

@chingor13

Copy link
Copy Markdown
Member

Fixes the warning from #2986

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • API's need to be enabled to test (tell us)
  • Environment Variables need to be set (ask us to set them)
  • Tests pass: mvn clean verifyrequired
  • Lint passes: mvn -P lint checkstyle:checkrequired
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:checkadvisory only
  • Please merge this PR for me once it is approved.

@chingor13
chingor13 requested a review from a teamJune 24, 2020 21:04
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 24, 2020
@chingor13

Copy link
Copy Markdown
MemberAuthor

Other failing spot bugs errors are no longer present in #2986

@lesv
lesv merged commit c3826df into GoogleCloudPlatform:masterJun 24, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@chingor13@lesv@googlebot