Skip to content

DO NOT MERGE vision: v1 logo detection samples - #3094

Closed
czahedi wants to merge 3 commits into
masterfrom
vision-v1-logo
Closed

DO NOT MERGE vision: v1 logo detection samples#3094
czahedi wants to merge 3 commits into
masterfrom
vision-v1-logo

Conversation

@czahedi

Copy link
Copy Markdown
Contributor

v1 logo detection samples. Service not rolled out yet so DO NOT MERGE

@czahediczahedi added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 12, 2020
@czahedi
czahedi requested a review from nnegreyMarch 12, 2020 18:57
@czahedi
czahedi requested review from a team and sirtorry as code ownersMarch 12, 2020 18:57
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 12, 2020
import io

# [START video_detect_logo_beta]
# [START video_detect_logo]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we try not to do this as it will break docs. Prefer to create a new GA file rather than rename beta files.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah dang good point. Do we then follow up and delete the beta files?

@czahedi

Copy link
Copy Markdown
ContributorAuthor

Closing will rebase with appropriate names

@czahediczahedi closed this Mar 12, 2020
@czahedi
czahedi deleted the vision-v1-logo branch March 12, 2020 21:22
@czahedi

Copy link
Copy Markdown
ContributorAuthor

See #3098

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yesThis human has signed the Contributor License Agreement.do not mergeIndicates a pull request not ready for merge, due to either quality or timing.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@czahedi@nnegrey@googlebot@leahecole