Skip to content

video: adding GA samples for logo detection - #3098

Merged
czahedi merged 14 commits into
masterfrom
vision-logo-v1-attempt2
Mar 20, 2020
Merged

video: adding GA samples for logo detection#3098
czahedi merged 14 commits into
masterfrom
vision-logo-v1-attempt2

Conversation

@czahedi

@czahediczahedi commented Mar 12, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

New PR to undo issues caused by #3094

Adds samples for GA of logo detection

DO NOT MERGE until prod rollout. Tests are passing locally.

@czahedi
czahedi requested review from a team, nnegrey and sirtorry as code ownersMarch 12, 2020 21:32
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 12, 2020
@czahediczahedi added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 12, 2020
@czahediczahedi mentioned this pull request Mar 12, 2020
Closed
nnegrey
nnegrey suggested changes Mar 13, 2020
View reviewed changes
Comment threadvideo/cloud-client/analyze/video_detect_logo.py Outdated
Comment threadvideo/cloud-client/analyze/video_detect_logo.py Outdated
Comment threadvideo/cloud-client/analyze/video_detect_logo.py Outdated
Comment threadvideo/cloud-client/analyze/video_detect_logo.py Outdated
Comment threadvideo/cloud-client/analyze/video_detect_logo.py Outdated
@czahediczahedi changed the title DO NOT MERGE. vision: adding GA samples for logo detectionvision: adding GA samples for logo detectionMar 16, 2020
@czahediczahedi added automerge Merge the pull request once unit tests and other checks pass. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Mar 16, 2020
@czahedi
czahedi requested review from nnegrey and removed request for sirtorryMarch 16, 2020 23:27
@gcf-merge-on-green

gcf-merge-on-greenBot commented Mar 17, 2020

Copy link
Copy Markdown
Contributor

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

1 similar comment
@gcf-merge-on-green

gcf-merge-on-greenBot commented Mar 17, 2020

Copy link
Copy Markdown
Contributor

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

@gcf-merge-on-green

gcf-merge-on-greenBot commented Mar 17, 2020

Copy link
Copy Markdown
Contributor

Your PR was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. See required reviews for your repo here: https://github.com/googleapis/sloth/blob/master/required-checks.json

nnegrey
nnegrey reviewed Mar 17, 2020
View reviewed changes
Comment threadvideo/cloud-client/analyze/video_detect_logo.py Outdated
nnegrey
nnegrey reviewed Mar 17, 2020
View reviewed changes
Comment threadvideo/cloud-client/analyze/video_detect_logo.py Outdated
nnegrey
nnegrey reviewed Mar 17, 2020
View reviewed changes
Comment threadvideo/cloud-client/analyze/video_detect_logo.py
nnegrey
nnegrey reviewed Mar 17, 2020
View reviewed changes
Comment threadvideo/cloud-client/analyze/video_detect_logo.py
nnegrey
nnegrey reviewed Mar 17, 2020
View reviewed changes
Comment threadvideo/cloud-client/analyze/video_detect_logo.py
nnegrey
nnegrey reviewed Mar 17, 2020
View reviewed changes
Comment threadvideo/cloud-client/analyze/video_detect_logo.py
nnegrey
nnegrey reviewed Mar 17, 2020
View reviewed changes
Comment threadvideo/cloud-client/analyze/video_detect_logo_gcs_test.py Outdated
nnegrey
nnegrey reviewed Mar 17, 2020
View reviewed changes
Comment threadvideo/cloud-client/analyze/video_detect_logo_test.py Outdated
@gcf-merge-on-green

gcf-merge-on-greenBot commented Mar 19, 2020

Copy link
Copy Markdown
Contributor

Your PR was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. See required reviews for your repo here: https://github.com/googleapis/sloth/blob/master/required-checks.json

@nnegreynnegrey changed the title vision: adding GA samples for logo detectionvideo: adding GA samples for logo detectionMar 19, 2020
nnegrey
nnegrey reviewed Mar 19, 2020
View reviewed changes
Comment threadvideo/cloud-client/analyze/video_detect_logo_gcs.py Outdated
nnegrey
nnegrey approved these changes Mar 19, 2020
View reviewed changes

@nnegreynnegrey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (one last thing on the extra comma)

czahediand others added 2 commits March 19, 2020 15:19
@czahedi@nnegrey
Update video/cloud-client/analyze/video_detect_logo_gcs.py
25cb250
Deleting comma :)
Co-Authored-By: Noah Negrey <nnegrey@users.noreply.github.com>
@czahedi
Merge branch 'master' into vision-logo-v1-attempt2
b96be92
@czahediczahedi added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 20, 2020
@kokoro-teamkokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 20, 2020
nnegrey
nnegrey suggested changes Mar 20, 2020
View reviewed changes
Comment threadvideo/cloud-client/analyze/beta_snippets_test.py Outdated
@czahedi
czahedi merged commit f1e2d04 into masterMar 20, 2020
@czahedi
czahedi deleted the vision-logo-v1-attempt2 branch March 20, 2020 21:35
@munkhuushmglmunkhuushmgl mentioned this pull request Mar 24, 2020
Merged
@sirtorry

sirtorry commented Mar 25, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

triple nested for loops :'(

edit: quadruple :O

gcf-merge-on-greenBot pushed a commit that referenced this pull request Apr 16, 2020
@czahedi
vision: delete obsolete beta snippets for logo detection (#3114)
8f045c7
v1 snippets are published, via #3098 and shown on this docs page: https://cloud.google.com/video-intelligence/docs/logo-recognition
So we're deleting the beta snippets which are now obsolete. [Set up pre-launch as _draft_, will push this change through once the above PR is complete and the docs are updated]
busunkim96 pushed a commit to busunkim96/python-videointelligence that referenced this pull request May 20, 2020
@czahedi@nnegrey
video: adding GA samples for logo detection [(#3098)](GoogleCloudPlat…
a065417
…form/python-docs-samples#3098)
* DO NOT MERGE. vision: adding GA samples for logo detection
* fixing linter issues across several sample files
* responding to Noah's comments
* responding to comments - fixing whitespace and file references
* Addressing comments
* Update video/cloud-client/analyze/video_detect_logo_gcs.py
Deleting comma :)
Co-Authored-By: Noah Negrey <nnegrey@users.noreply.github.com>
* fixing broken test
* typo
Co-authored-by: Noah Negrey <nnegrey@users.noreply.github.com>
busunkim96 pushed a commit to busunkim96/python-videointelligence that referenced this pull request May 20, 2020
@czahedi
vision: delete obsolete beta snippets for logo detection [(#3114)](Go…
e978160
…ogleCloudPlatform/python-docs-samples#3114)
v1 snippets are published, via GoogleCloudPlatform/python-docs-samples#3098 and shown on this docs page: https://cloud.google.com/video-intelligence/docs/logo-recognition
So we're deleting the beta snippets which are now obsolete. [Set up pre-launch as _draft_, will push this change through once the above PR is complete and the docs are updated]
danoscarmike pushed a commit to googleapis/python-videointelligence that referenced this pull request Sep 30, 2020
@czahedi@nnegrey@danoscarmike
video: adding GA samples for logo detection [(#3098)](GoogleCloudPlat…
1b907ac
…form/python-docs-samples#3098)
* DO NOT MERGE. vision: adding GA samples for logo detection
* fixing linter issues across several sample files
* responding to Noah's comments
* responding to comments - fixing whitespace and file references
* Addressing comments
* Update video/cloud-client/analyze/video_detect_logo_gcs.py
Deleting comma :)
Co-Authored-By: Noah Negrey <nnegrey@users.noreply.github.com>
* fixing broken test
* typo
Co-authored-by: Noah Negrey <nnegrey@users.noreply.github.com>
danoscarmike pushed a commit to googleapis/python-videointelligence that referenced this pull request Sep 30, 2020
@czahedi@danoscarmike
vision: delete obsolete beta snippets for logo detection [(#3114)](Go…
afce253
…ogleCloudPlatform/python-docs-samples#3114)
v1 snippets are published, via GoogleCloudPlatform/python-docs-samples#3098 and shown on this docs page: https://cloud.google.com/video-intelligence/docs/logo-recognition
So we're deleting the beta snippets which are now obsolete. [Set up pre-launch as _draft_, will push this change through once the above PR is complete and the docs are updated]
dizcology pushed a commit that referenced this pull request Sep 11, 2023
@czahedi@nnegrey@danoscarmike
video: adding GA samples for logo detection [(#3098)](#3098)
89ce098
* DO NOT MERGE. vision: adding GA samples for logo detection
* fixing linter issues across several sample files
* responding to Noah's comments
* responding to comments - fixing whitespace and file references
* Addressing comments
* Update video/cloud-client/analyze/video_detect_logo_gcs.py
Deleting comma :)
Co-Authored-By: Noah Negrey <nnegrey@users.noreply.github.com>
* fixing broken test
* typo
Co-authored-by: Noah Negrey <nnegrey@users.noreply.github.com>
dizcology pushed a commit that referenced this pull request Sep 11, 2023
@czahedi@danoscarmike
vision: delete obsolete beta snippets for logo detection [(#3114)](#3114
dff7ccc
)
v1 snippets are published, via #3098 and shown on this docs page: https://cloud.google.com/video-intelligence/docs/logo-recognition
So we're deleting the beta snippets which are now obsolete. [Set up pre-launch as _draft_, will push this change through once the above PR is complete and the docs are updated]
@dizcologydizcology mentioned this pull request Sep 11, 2023
Merged
9 tasks
leahecole pushed a commit that referenced this pull request Sep 15, 2023
@czahedi@nnegrey@leahecole
video: adding GA samples for logo detection [(#3098)](#3098)
c305ea8
* DO NOT MERGE. vision: adding GA samples for logo detection
* fixing linter issues across several sample files
* responding to Noah's comments
* responding to comments - fixing whitespace and file references
* Addressing comments
* Update video/cloud-client/analyze/video_detect_logo_gcs.py
Deleting comma :)
Co-Authored-By: Noah Negrey <nnegrey@users.noreply.github.com>
* fixing broken test
* typo
Co-authored-by: Noah Negrey <nnegrey@users.noreply.github.com>
leahecole pushed a commit that referenced this pull request Sep 15, 2023
@czahedi@leahecole
vision: delete obsolete beta snippets for logo detection [(#3114)](#3114
1ff2c42
)
v1 snippets are published, via #3098 and shown on this docs page: https://cloud.google.com/video-intelligence/docs/logo-recognition
So we're deleting the beta snippets which are now obsolete. [Set up pre-launch as _draft_, will push this change through once the above PR is complete and the docs are updated]
parthea pushed a commit to googleapis/google-cloud-python that referenced this pull request Sep 22, 2023
@czahedi@nnegrey@danoscarmike
video: adding GA samples for logo detection [(#3098)](GoogleCloudPlat…
c105c1b
…form/python-docs-samples#3098)
* DO NOT MERGE. vision: adding GA samples for logo detection
* fixing linter issues across several sample files
* responding to Noah's comments
* responding to comments - fixing whitespace and file references
* Addressing comments
* Update video/cloud-client/analyze/video_detect_logo_gcs.py
Deleting comma :)
Co-Authored-By: Noah Negrey <nnegrey@users.noreply.github.com>
* fixing broken test
* typo
Co-authored-by: Noah Negrey <nnegrey@users.noreply.github.com>
parthea pushed a commit to googleapis/google-cloud-python that referenced this pull request Sep 22, 2023
@czahedi@danoscarmike
vision: delete obsolete beta snippets for logo detection [(#3114)](Go…
13554d6
…ogleCloudPlatform/python-docs-samples#3114)
v1 snippets are published, via GoogleCloudPlatform/python-docs-samples#3098 and shown on this docs page: https://cloud.google.com/video-intelligence/docs/logo-recognition
So we're deleting the beta snippets which are now obsolete. [Set up pre-launch as _draft_, will push this change through once the above PR is complete and the docs are updated]
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leahecoleleahecoleleahecole approved these changes
+1 more reviewer
@nnegreynnegreynnegrey approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@leahecoleleahecole

Labels

automergeMerge the pull request once unit tests and other checks pass.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@czahedi@sirtorry@leahecole@nnegrey@googlebot@kokoro-team