Skip to content

fix(composer): use separate airflow db file per session - #5515

Merged
leahecole merged 6 commits into
GoogleCloudPlatform:masterfrom
tmatsuo:fix-composer
Mar 16, 2021
Merged

fix(composer): use separate airflow db file per session#5515
leahecole merged 6 commits into
GoogleCloudPlatform:masterfrom
tmatsuo:fix-composer

Conversation

@tmatsuo

@tmatsuotmatsuo commented Mar 12, 2021

Copy link
Copy Markdown
Contributor

fixes#5482

@tmatsuo
tmatsuo requested a review from leahecoleMarch 12, 2021 20:24
@tmatsuo
tmatsuo requested a review from a team as a code ownerMarch 12, 2021 20:24
@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label Mar 12, 2021
@product-auto-labelproduct-auto-labelBot added api: composer Issues related to the Managed Service for Apache Airflow API. samples Issues that are directly related to samples. labels Mar 12, 2021
tswast
tswast reviewed Mar 12, 2021
View reviewed changes
Comment threadcomposer/conftest.py Outdated
@tmatsuotmatsuo changed the title fix(composer): use separate AIRFLOW_HOME per sessionfix(composer): use separate airflow db file per sessionMar 12, 2021
leahecole
leahecole approved these changes Mar 16, 2021
View reviewed changes

@leahecoleleahecole left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try it! Thanks for putting this fix in, Takashi!! (also, TIL about tempfile - so useful!)

@leahecole

leahecole commented Mar 16, 2021

Copy link
Copy Markdown
Collaborator

Ugh, I'm seeing these test failures in another PR. I'll investigate after lunch.

@leahecoleleahecole mentioned this pull request Mar 16, 2021
Merged
8 tasks
@leahecole
leahecole merged commit ca9cd09 into GoogleCloudPlatform:masterMar 16, 2021
This was linked to issues Mar 16, 2021
composer.blog.gcp-tech-blog.unit-test-dags-cloud-build.dags.example_dag_test: test_dag_import failed #5502
Closed
composer.workflows.unit_testing_test: test_dag_with_variables failed #5487
Closed
composer.workflows.hadoop_tutorial_test: test_dag_import failed #5479
Closed
composer.workflows.dataproc_workflow_template_instantiate_operator_tutorial_test: test_dag_import failed #5478
Closed
composer.workflows.dataflowtemplateoperator_tutorial_test: test_dag_import failed #5477
Closed
composer.workflows.bq_notify_test: test_dag_import failed #5474
Closed
composer.workflows.bq_copy_across_locations_test: test_dag failed #5473
Closed
composer.workflows.airflow_db_cleanup_test: test_dag_import failed #5471
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment