Skip to content

Explicitly pin SQLAlchemy for composer samples - #5530

Merged
leahecole merged 1 commit into
masterfrom
pin-sqlalchemy-airflow
Mar 16, 2021
Merged

Explicitly pin SQLAlchemy for composer samples#5530
leahecole merged 1 commit into
masterfrom
pin-sqlalchemy-airflow

Conversation

@leahecole

@leahecoleleahecole commented Mar 16, 2021

Copy link
Copy Markdown
Collaborator

Description

Unblocks #5515 and #5521

I merged a PR this morning that bumped sqlalchemy dependencies in other samples to 1.4. It seems like we're using the cached version of that dependency by the time we get to Composer samples, and Airflow does not play well with SQLalchemy 1.4, so we need to explicitly pin to the latest 1.3.* version until at least Airflow 2.0.

Checklist

@leahecole
leahecole requested a review from a team as a code ownerMarch 16, 2021 20:33
@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label Mar 16, 2021
@product-auto-labelproduct-auto-labelBot added the samples Issues that are directly related to samples. label Mar 16, 2021
@leahecole

Copy link
Copy Markdown
CollaboratorAuthor

If on this PR we see failures like alembic.util.exc.CommandError: Can't locate revision identified by '03afc6b6f902' or values talking about key value pairs, that's okay. That's what's being addressed in #5515. This should fix the sqlalchemy.ext.declarative.clsregistry errors.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yesThis human has signed the Contributor License Agreement.samplesIssues that are directly related to samples.

Projects

None yet

3 participants

@leahecole@tmatsuo@engelke