Add PAF whole functionality including reviewer roles, dashboard listing, and set permissions by sandeepsajan0 · Pull Request #2943 · HyphaApp/hypha

sandeepsajan0 · 2022-08-09T05:08:13Z

Patched Paf PR #2927 over Wagtail upgrade PR #2934

FixesPM can create and submit Project Approval Form (PAF) OpenTechFund/apply-app#3
FixesCompliance Attorney can review Project Approval Form OpenTechFund/apply-app#4
FixesCompliance Attorney can request changes to Project Approval Form OpenTechFund/apply-app#5
FixesGC, CFO, CEO can approve the Project Approval Form OpenTechFund/apply-app#6
FixesGC, CFO, CEO can request changes to PAF OpenTechFund/apply-app#7

Issues fixed via PR #2935:

codecov · 2022-08-09T05:22:34Z

Codecov Report

Base: 81.97% // Head: 82.02% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (e8d109e) compared to base (7374b8d).
Patch coverage: 92.50% of modified lines in pull request are covered.

Additional details and impacted files

@@ Coverage Diff @@## main #2943 +/- ##
==========================================
+ Coverage 81.97% 82.02% +0.05% 
==========================================
Files 704 705 +1 Lines 24958 25178 +220 ==========================================
+ Hits 20459 20653 +194 - Misses 4499 4525 +26

Impacted Files	Coverage Δ
hypha/apply/projects/admin.py	`75.00% <ø> (ø)`
hypha/apply/projects/forms/__init__.py	`100.00% <ø> (ø)`
hypha/apply/projects/views/__init__.py	`100.00% <ø> (ø)`
hypha/apply/dashboard/views.py	`75.44% <38.88%> (-4.56%)`	⬇️
...ypha/apply/projects/templatetags/approval_tools.py	`71.42% <56.25%> (-28.58%)`	⬇️
hypha/apply/projects/models/project.py	`91.10% <86.95%> (-1.18%)`	⬇️
hypha/apply/projects/views/project.py	`87.84% <95.08%> (+0.24%)`	⬆️
hypha/apply/dashboard/tests/test_views.py	`100.00% <100.00%> (ø)`
hypha/apply/funds/admin.py	`85.34% <100.00%> (+0.12%)`	⬆️
hypha/apply/projects/forms/project.py	`99.15% <100.00%> (+0.81%)`	⬆️
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

…ting and finance

…notifications

…roject

… Manage section to Apply section in admin ui

…ting and finance

…notifications

…roject

… Manage section to Apply section in admin ui

frjo · 2022-08-29T13:49:26Z

This is deploying to test now.

frjo changed the base branch from maintenance/theskumar/update-wagtail-3 to mainAugust 15, 2022 13:50

sandeepsajan0 changed the title ~~Feature/wagtail3 paf~~Add PAF whole functionality including reviewer roles, dashboard listing, set permissionsAug 16, 2022

sandeepsajan0 changed the title ~~Add PAF whole functionality including reviewer roles, dashboard listing, set permissions~~Add PAF whole functionality including reviewer roles, dashboard listing, and set permissionsAug 16, 2022

sandeepsajan0 added 18 commits August 16, 2022 15:20

Update Dasboards for finance and contracting
78fbdaf

Add model for PAF reviewers roles, and manage permissions for contrac…
8f17f8e
…ting and finance

Add PAF status Change form and view with dynamic roles
dbac1e0

Fix Send for Approval view test
3e0641a

Update users role in approval form tests
7156dd8

Add request change functionality, send to compliance mail, and added …
bbbc11c
…notifications

fix update status permissions
0182cf2

Add update status form(request change option) for final approver of p…
d43e776
…roject

Make comments and actions non-editable
45a280a

Fix existing tests of Final approval form
0c949c8

Remove RejectionView from projects
4aaf300

Remove RejectionForm and its tests, and Move ProjectApprovalForm from…
8e4c6cf
… Manage section to Apply section in admin ui

Update tests for FinalApproval and PAFStatus Views and forms
836fcad

resolve lint issues
33ca76b

Fix tests for roles by creating PafReviewerRoles via settings
5afc297

Resolve migration conflicts
9cd657f

Fix lint issues
d796154

Serve fancybox and search param js file locally
5425836

sandeepsajan0 force-pushed the feature/wagtail3-paf branch from b95f5b4 to 5425836Compare August 16, 2022 11:16

sandeepsajan0 added 7 commits August 29, 2022 10:18

Update Dasboards for finance and contracting
98fcd01

Add model for PAF reviewers roles, and manage permissions for contrac…
436d06b
…ting and finance

Add PAF status Change form and view with dynamic roles
ef81bcc

Fix Send for Approval view test
b11ac6b

Update users role in approval form tests
c360d3b

Add request change functionality, send to compliance mail, and added …
79addd5
…notifications

fix update status permissions
d278d1f

sandeepsajan0 added 11 commits August 29, 2022 10:18

Add update status form(request change option) for final approver of p…
2f94aa4
…roject

Make comments and actions non-editable
7a04946

Fix existing tests of Final approval form
ec00445

Remove RejectionView from projects
1a6622e

Remove RejectionForm and its tests, and Move ProjectApprovalForm from…
f39c937
… Manage section to Apply section in admin ui

Update tests for FinalApproval and PAFStatus Views and forms
b4d5fb8

resolve lint issues
484e0d4

Fix tests for roles by creating PafReviewerRoles via settings
48c93ba

Resolve migration conflicts
5e3f9c6

Fix lint issues
b376202

Serve fancybox and search param js file locally
272ea89

frjo force-pushed the feature/wagtail3-paf branch from 5425836 to 272ea89Compare August 29, 2022 08:18

frjo mentioned this pull request Aug 29, 2022
Add model for PAF reviewers role, add dashboard view for contracting role #2927
Closed

frjo temporarily deployed to test-hypha-app August 29, 2022 12:26 Inactive

sandeepsajan0 added 2 commits August 29, 2022 18:37

Fix editable issue and update tests accordingly
96efe67

Resolve conflicts
e8d109e

frjo requested a deployment to test-hypha-app August 29, 2022 13:47 Abandoned

frjo added Type: Feature This is something new (not an enhancement of an existing thing). Type: Minor Minor change, used in release drafter labels Sep 12, 2022

frjo merged commit 0acb382 into mainSep 12, 2022

sandeepsajan0 mentioned this pull request Sep 13, 2022
Contracting Role: PAF to approve table #2925
Closed

frjo deleted the feature/wagtail3-paf branch December 7, 2022 08:38

Navigation Menu

Uh oh!

Add PAF whole functionality including reviewer roles, dashboard listing, and set permissions - #2943

Add PAF whole functionality including reviewer roles, dashboard listing, and set permissions#2943
frjo merged 38 commits into
mainfrom
feature/wagtail3-paf

sandeepsajan0 commented Aug 9, 2022•
edited
Loading

Uh oh!

codecovBot commented Aug 9, 2022•
edited
Loading

Uh oh!

frjo commented Aug 29, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

sandeepsajan0 commented Aug 9, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecovBot commented Aug 9, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

frjo commented Aug 29, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sandeepsajan0 commented Aug 9, 2022•
edited
Loading

codecovBot commented Aug 9, 2022•
edited
Loading